From: Steve Youngs <steve@sxemacs.org>
Subject: [PATCH] Fix gnus-message-citation-mode for (S)XEmacs
Date: Sun, 31 Dec 2006 17:18:10 +1000 [thread overview]
Message-ID: <microsoft-free.87zm944jpp.fsf@youngs.au.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4426 bytes --]
This fixes a problem reported by Norbert Koch and Nelson Ferreira in
regards to `gnus-message-citation-mode' and (S)XEmacs.
Reiner, I guess your solution fixed it too, but this one doesn't just
turn it off for (S)XEmacs. :-) Hope you don't mind.
NOTE: This patch has been committed.
Gnus patch:
ChangeLog files diff command: cvs -q diff -U 0
Files affected: lisp/ChangeLog
Source files diff command: cvs -q diff -uN
Files affected: lisp/gnus-msg.el lisp/gnus-cite.el
Index: lisp/ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 7.1454
diff -u -p -U0 -r7.1454 ChangeLog
--- lisp/ChangeLog 31 Dec 2006 00:57:08 -0000 7.1454
+++ lisp/ChangeLog 31 Dec 2006 07:14:47 -0000
@@ -0,0 +1,13 @@
+2006-12-31 Steve Youngs <steve@sxemacs.org>
+
+ * gnus-cite.el: Load easy-mmode at compile time for (S)XEmacs to get
+ `define-minor-mode' macro definition expanded properly.
+ (gnus-message-citation-mode): This is now OK for (S)XEmacs so don't
+ exclude it there.
+
+ * gnus-msg.el (gnus-message-highlight-citation): Revert Reiner's patch
+ of 2006-12-30. The default is nil on (S)XEmacs already because of the
+ `fboundp' test.
+ (gnus-message-citation-mode): Revert Reiner's patch of 2006-12-30.
+ This is OK to autoload in (S)XEmacs now.
+
Index: lisp/gnus-cite.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-cite.el,v
retrieving revision 7.21
diff -u -p -u -r7.21 gnus-cite.el
--- lisp/gnus-cite.el 30 Dec 2006 21:03:37 -0000 7.21
+++ lisp/gnus-cite.el 31 Dec 2006 07:14:42 -0000
@@ -27,6 +27,9 @@
;;; Code:
(eval-when-compile (require 'cl))
+(eval-when-compile
+ (when (featurep 'xemacs)
+ (require 'easy-mmode))) ; for `define-minor-mode'
(require 'gnus)
(require 'gnus-range)
@@ -1159,20 +1162,19 @@ Returns nil if there is no such line bef
(font-lock-remove-keywords nil gnus-message-citation-keywords)
(gnus-message 1 "`font-lock-remove-keywords' not supported.")))
-(unless (featurep 'xemacs)
- (define-minor-mode gnus-message-citation-mode
- "Toggle `gnus-message-citation-mode' in current buffer.
+(define-minor-mode gnus-message-citation-mode
+ "Toggle `gnus-message-citation-mode' in current buffer.
This buffer local minor mode provides additional font-lock support for
nested citations.
With prefix ARG, turn `gnus-message-citation-mode' on if and only if ARG is
positive."
- nil ;; init-value
- "" ;; lighter
- nil ;; keymap
- (if gnus-message-citation-mode
- (gnus-message-add-citation-keywords)
- (gnus-message-remove-citation-keywords))
- (font-lock-fontify-buffer)))
+ nil ;; init-value
+ "" ;; lighter
+ nil ;; keymap
+ (if gnus-message-citation-mode
+ (gnus-message-add-citation-keywords)
+ (gnus-message-remove-citation-keywords))
+ (font-lock-fontify-buffer))
(defun turn-on-gnus-message-citation-mode ()
"Turn on `gnus-message-citation-mode'."
Index: lisp/gnus-msg.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-msg.el,v
retrieving revision 7.44
diff -u -p -u -r7.44 gnus-msg.el
--- lisp/gnus-msg.el 30 Dec 2006 13:50:57 -0000 7.44
+++ lisp/gnus-msg.el 31 Dec 2006 07:14:42 -0000
@@ -290,8 +290,7 @@ If nil, the address field will always be
:type 'boolean)
(defcustom gnus-message-highlight-citation
- (and (not (featurep 'xemacs))
- ;; gnus-treat-highlight-citation ;; gnus-cite dependency
+ (and t ;; gnus-treat-highlight-citation ;; gnus-cite dependency
(fboundp 'font-lock-add-keywords))
"Enable highlighting of different citation levels in message-mode."
:version "23.0" ;; No Gnus
@@ -299,8 +298,7 @@ If nil, the address field will always be
:group 'gnus-message
:type 'boolean)
-(unless (featurep 'xemacs)
- (autoload 'gnus-message-citation-mode "gnus-cite" nil t))
+(autoload 'gnus-message-citation-mode "gnus-cite" nil t)
;;; Internal variables.
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| SXEmacs - The only _______ you'll ever need. |
| Fill in the blank, yes, it's THAT good! |
|------------------------------------<steve@sxemacs.org>---|
[-- Attachment #2: Type: application/pgp-signature, Size: 312 bytes --]
next reply other threads:[~2006-12-31 7:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 7:18 Steve Youngs [this message]
2006-12-31 11:52 ` Reiner Steib
2007-01-01 7:26 ` Katsumi Yamaoka
2007-02-07 9:25 ` Katsumi Yamaoka
2007-02-07 15:33 ` Dave Goldberg
2007-02-08 4:42 ` Katsumi Yamaoka
2007-02-08 17:48 ` Dave Goldberg
2007-02-08 23:29 ` Katsumi Yamaoka
2007-02-13 12:46 ` Katsumi Yamaoka
2007-02-13 19:49 ` Dave Goldberg
2007-02-14 0:29 ` Katsumi Yamaoka
2007-02-28 21:14 ` Dave Goldberg
2007-02-28 22:32 ` Katsumi Yamaoka
2007-03-01 16:29 ` Dave Goldberg
2007-03-02 15:28 ` Dave Goldberg
2007-02-09 23:48 ` Steve Youngs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=microsoft-free.87zm944jpp.fsf@youngs.au.com \
--to=steve@sxemacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).