This fixes a problem reported by Norbert Koch and Nelson Ferreira in regards to `gnus-message-citation-mode' and (S)XEmacs. Reiner, I guess your solution fixed it too, but this one doesn't just turn it off for (S)XEmacs. :-) Hope you don't mind. NOTE: This patch has been committed. Gnus patch: ChangeLog files diff command: cvs -q diff -U 0 Files affected: lisp/ChangeLog Source files diff command: cvs -q diff -uN Files affected: lisp/gnus-msg.el lisp/gnus-cite.el Index: lisp/ChangeLog =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v retrieving revision 7.1454 diff -u -p -U0 -r7.1454 ChangeLog --- lisp/ChangeLog 31 Dec 2006 00:57:08 -0000 7.1454 +++ lisp/ChangeLog 31 Dec 2006 07:14:47 -0000 @@ -0,0 +1,13 @@ +2006-12-31 Steve Youngs + + * gnus-cite.el: Load easy-mmode at compile time for (S)XEmacs to get + `define-minor-mode' macro definition expanded properly. + (gnus-message-citation-mode): This is now OK for (S)XEmacs so don't + exclude it there. + + * gnus-msg.el (gnus-message-highlight-citation): Revert Reiner's patch + of 2006-12-30. The default is nil on (S)XEmacs already because of the + `fboundp' test. + (gnus-message-citation-mode): Revert Reiner's patch of 2006-12-30. + This is OK to autoload in (S)XEmacs now. + Index: lisp/gnus-cite.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-cite.el,v retrieving revision 7.21 diff -u -p -u -r7.21 gnus-cite.el --- lisp/gnus-cite.el 30 Dec 2006 21:03:37 -0000 7.21 +++ lisp/gnus-cite.el 31 Dec 2006 07:14:42 -0000 @@ -27,6 +27,9 @@ ;;; Code: (eval-when-compile (require 'cl)) +(eval-when-compile + (when (featurep 'xemacs) + (require 'easy-mmode))) ; for `define-minor-mode' (require 'gnus) (require 'gnus-range) @@ -1159,20 +1162,19 @@ Returns nil if there is no such line bef (font-lock-remove-keywords nil gnus-message-citation-keywords) (gnus-message 1 "`font-lock-remove-keywords' not supported."))) -(unless (featurep 'xemacs) - (define-minor-mode gnus-message-citation-mode - "Toggle `gnus-message-citation-mode' in current buffer. +(define-minor-mode gnus-message-citation-mode + "Toggle `gnus-message-citation-mode' in current buffer. This buffer local minor mode provides additional font-lock support for nested citations. With prefix ARG, turn `gnus-message-citation-mode' on if and only if ARG is positive." - nil ;; init-value - "" ;; lighter - nil ;; keymap - (if gnus-message-citation-mode - (gnus-message-add-citation-keywords) - (gnus-message-remove-citation-keywords)) - (font-lock-fontify-buffer))) + nil ;; init-value + "" ;; lighter + nil ;; keymap + (if gnus-message-citation-mode + (gnus-message-add-citation-keywords) + (gnus-message-remove-citation-keywords)) + (font-lock-fontify-buffer)) (defun turn-on-gnus-message-citation-mode () "Turn on `gnus-message-citation-mode'." Index: lisp/gnus-msg.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-msg.el,v retrieving revision 7.44 diff -u -p -u -r7.44 gnus-msg.el --- lisp/gnus-msg.el 30 Dec 2006 13:50:57 -0000 7.44 +++ lisp/gnus-msg.el 31 Dec 2006 07:14:42 -0000 @@ -290,8 +290,7 @@ If nil, the address field will always be :type 'boolean) (defcustom gnus-message-highlight-citation - (and (not (featurep 'xemacs)) - ;; gnus-treat-highlight-citation ;; gnus-cite dependency + (and t ;; gnus-treat-highlight-citation ;; gnus-cite dependency (fboundp 'font-lock-add-keywords)) "Enable highlighting of different citation levels in message-mode." :version "23.0" ;; No Gnus @@ -299,8 +298,7 @@ If nil, the address field will always be :group 'gnus-message :type 'boolean) -(unless (featurep 'xemacs) - (autoload 'gnus-message-citation-mode "gnus-cite" nil t)) +(autoload 'gnus-message-citation-mode "gnus-cite" nil t) ;;; Internal variables. -- |---------------------| | SXEmacs - The only _______ you'll ever need. | | Fill in the blank, yes, it's THAT good! | |---------------------------------------|