Gnus development mailing list
 help / color / mirror / Atom feed
* [PATCH] XEmacs uses 'manual-entry' not 'man'.
@ 2002-10-17 14:45 Steve Youngs
  2002-10-18  3:19 ` Simon Josefsson
  0 siblings, 1 reply; 4+ messages in thread
From: Steve Youngs @ 2002-10-17 14:45 UTC (permalink / raw)


Love the new buttons for man links.  This patch makes man page buttons
work out of the box for XEmacs.


NOTE: This patch has been committed.


Gnus patch:
ChangeLog files diff command: cvs -q diff -U 0
Files affected:               lisp/ChangeLog
Source files diff command:    cvs -q diff -uN
Files affected:               lisp/gnus-art.el

Index: lisp/ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.1615
diff -u -U0 -r6.1615 ChangeLog
--- lisp/ChangeLog	2002/10/16 13:29:25	6.1615
+++ lisp/ChangeLog	2002/10/17 15:35:48
@@ -0,0 +1,5 @@
+2002-10-17  Steve Youngs  <youngs@xemacs.org>
+
+	* gnus-art.el (gnus-button-man-handler): Add 'manual-entry' for
+	XEmacs, default to it if featurep 'xemacs.
+
Index: lisp/gnus-art.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v
retrieving revision 6.248
diff -u -u -r6.248 gnus-art.el
--- lisp/gnus-art.el	2002/09/27 08:09:05	6.248
+++ lisp/gnus-art.el	2002/10/17 15:35:04
@@ -5314,11 +5314,14 @@
   :group 'gnus-article-buttons
   :type 'regexp)
 
-(defcustom gnus-button-man-handler 'man
+(defcustom gnus-button-man-handler (if (featurep 'xemacs)
+				       'manual-entry
+				     'man)
   "Function to use for displaying man pages.
 The function must take at least one argument with a string naming the
 man page."
-  :type '(choice (function-item :tag "Man" man)
+  :type '(choice (function-item :tag "Man (Emacs)" man)
+	         (function-item :tag "Man (XEmacs)" manual-entry)
 		 (function-item :tag "Woman" woman)
 		 (function :tag "Other"))
   :group 'gnus-article-buttons)

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
|            XEmacs - It's not just an editor.             |
|                    It's a way of life.                   |
|------------------------------------<youngs@xemacs.org>---|




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] XEmacs uses 'manual-entry' not 'man'.
  2002-10-17 14:45 [PATCH] XEmacs uses 'manual-entry' not 'man' Steve Youngs
@ 2002-10-18  3:19 ` Simon Josefsson
  2002-10-19  0:04   ` Steve Youngs
  0 siblings, 1 reply; 4+ messages in thread
From: Simon Josefsson @ 2002-10-18  3:19 UTC (permalink / raw)


Steve Youngs <youngs@xemacs.org> writes:

> +(defcustom gnus-button-man-handler (if (featurep 'xemacs)
> +				       'manual-entry
> +				     'man)

I changed this to not check which emacs is used.  Since `manual-entry'
is defined in Emacs too, using manual-entry semes like a better
solution.  XEmacs' man.el should probably be synced though.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] XEmacs uses 'manual-entry' not 'man'.
  2002-10-18  3:19 ` Simon Josefsson
@ 2002-10-19  0:04   ` Steve Youngs
  2002-10-22 10:04     ` Simon Josefsson
  0 siblings, 1 reply; 4+ messages in thread
From: Steve Youngs @ 2002-10-19  0:04 UTC (permalink / raw)


|--==> "SJ" == Simon Josefsson <jas@extundo.com> writes:

  SJ> Steve Youngs <youngs@xemacs.org> writes:
  >>+(defcustom gnus-button-man-handler (if (featurep 'xemacs)
  >>+				       'manual-entry
  >>+				     'man)

  SJ> I changed this to not check which emacs is used.  Since
  SJ> `manual-entry' is defined in Emacs too

Cool.  I noticed that 'manual-entry' was in latest CVS Emacs, but
wasn't sure if it was in older versions.

Thanks Simon.

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
|            XEmacs - It's not just an editor.             |
|                    It's a way of life.                   |
|------------------------------------<youngs@xemacs.org>---|




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] XEmacs uses 'manual-entry' not 'man'.
  2002-10-19  0:04   ` Steve Youngs
@ 2002-10-22 10:04     ` Simon Josefsson
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Josefsson @ 2002-10-22 10:04 UTC (permalink / raw)


Steve Youngs <youngs@xemacs.org> writes:

> |--==> "SJ" == Simon Josefsson <jas@extundo.com> writes:
>
>   SJ> Steve Youngs <youngs@xemacs.org> writes:
>   >>+(defcustom gnus-button-man-handler (if (featurep 'xemacs)
>   >>+				       'manual-entry
>   >>+				     'man)
>
>   SJ> I changed this to not check which emacs is used.  Since
>   SJ> `manual-entry' is defined in Emacs too
>
> Cool.  I noticed that 'manual-entry' was in latest CVS Emacs, but
> wasn't sure if it was in older versions.

`manual-entry' has existed since at least 1985, so I think it is
safe. ;-)




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-10-22 10:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-17 14:45 [PATCH] XEmacs uses 'manual-entry' not 'man' Steve Youngs
2002-10-18  3:19 ` Simon Josefsson
2002-10-19  0:04   ` Steve Youngs
2002-10-22 10:04     ` Simon Josefsson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).