Gnus development mailing list
 help / color / mirror / Atom feed
From: Didier Verna <didier@lrde.epita.fr>
Subject: spam.el simplified but wrong logic
Date: Tue, 27 Apr 2004 12:39:48 +0200	[thread overview]
Message-ID: <muxfzaphfgr.fsf@uzeb.lrde.epita.fr> (raw)


        Hi !

I think there's a bug introduced by:

2004-04-16  Teodor Zlatanov  <tzz@lifelogs.com>

	* spam.el (spam-summary-prepare-exit): simplified logic


on the following part of the code:

 ,----
|     (unless (and spam-move-spam-nonspam-groups-only
|                  (not (spam-group-spam-contents-p gnus-newsgroup-name)))
|       (gnus-message 5 "Marking spam as expired and moving it to %s"
|                     gnus-newsgroup-name)
|       (spam-mark-spam-as-expired-and-move-routine
|        (gnus-parameter-spam-process-destination gnus-newsgroup-name)))
`-----

The "logic" should rather be: 

(unless (and spam-move-spam-nonspam-groups-only
             (spam-group-spam-contents-p gnus-newsgroup-name))
   ...

right ?

I can apply a patch if you whish.

-- 
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 53 14 59 22   didier@xemacs.org



             reply	other threads:[~2004-04-27 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-27 10:39 Didier Verna [this message]
2004-04-27 19:11 ` Johan Bockgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=muxfzaphfgr.fsf@uzeb.lrde.epita.fr \
    --to=didier@lrde.epita.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).