Re: Faces of the wrong order

[Didier Verna <didier@lrde.epita.fr>]

Katsumi Yamaoka <yamaoka@jpl.org> wrote:

> I don't think you corrected the order. This article contains three Faces and
> three X-Faces in order of Face-1, Face-2, Face-3, X-Face-1, X-Face-2 and
> X-Face-3 in the header. WDYT?

        Sorry, I can't see them right now, I'm on a tty (who wants to hack
konsole to display the faces by modifying the background pixmap ? :-)

        However, I'm suspicious about your own order of face insertion. This
actually fixed a problem for me, and if you look at the code of
article-display[-x]-face, you'll see that previously, the faces and x-faces
lists were built in a different order. So my patch actually builds these lists
in the same order now (admitedly, in the opposite order from insertion in the
message, but AFAICR that was the case when this feature was first
implemented).

So, I'm not strongly opposed to revert the face order again (although I
believe that would break old code like mine), but then, the x-face order
should also be reverted in order to stay consistent.


-- 
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 53 14 59 22   didier@xemacs.org