Gnus development mailing list
 help / color / mirror / Atom feed
From: Colin Rafferty <craffert@ml.com>
Subject: Re: two minor patches, and expiry inefficiency
Date: 05 Mar 1998 12:28:38 -0500	[thread overview]
Message-ID: <ocr7m69gi7t.fsf@ml.com> (raw)
In-Reply-To: Ken Raeburn's message of "Wed, 4 Mar 1998 21:21:50 -0500"

Ken Raeburn writes:

> Sat Feb 28 23:33:40 1998  Ken Raeburn  <raeburn@cygnus.com>

> 	* nnml.el (nnml-article-to-file): Don't add extra "/" when
> 	building pathname.

> Index: nnml.el
> ===================================================================
> RCS file: /0h/users/raeburn/.cvsfiles/lib/elisp/gnus/lisp/nnml.el,v
> retrieving revision 1.1.1.39
> diff -p -u -r1.1.1.39 nnml.el
> --- nnml.el	1998/02/26 04:10:28	1.1.1.39
> +++ nnml.el	1998/03/05 01:51:07
> @@ -480,7 +480,7 @@ all.  This may very well take some time.
>        ;; Just to make sure nothing went wrong when reading over NFS --
>        ;; check once more.
>        (when (file-exists-p
> -	     (setq file (concat nnml-current-directory "/"
> +	     (setq file (concat nnml-current-directory
>  				(number-to-string article))))
>  	(nnml-update-file-alist t)
>  	file))))

This should probably use `expand-file-name' instead of `concat', so that 
it totally avoids all the the issues of trailing slashes.

-- 
Colin


  reply	other threads:[~1998-03-05 17:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-03-05  2:21 Ken Raeburn
1998-03-05 17:28 ` Colin Rafferty [this message]
1998-03-06  6:19   ` Ken Raeburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ocr7m69gi7t.fsf@ml.com \
    --to=craffert@ml.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).