latest change to mm-util.el causes failure

latest change to mm-util.el causes failure

[Robert Pluim]

This change:

    revno: 103715
    author: Julien Danjou <julien@danjou.info>
    committer: Katsumi Yamaoka <yamaoka@jpl.org>
    branch nick: trunk
    timestamp: Tue 2011-03-22 13:40:41 +0000
    message:
    mm-view.el (mm-display-inline-fontify): Make mode optional, and call normal-mode if not set. Set temp buffer unmodified to avoid kill-buffer query.
    (mm-inline-text): Render normal text with fontification whenever possible.
    gnus-sum.el (gnus-summary-save-parts-1):
    gnus-art.el (gnus-article-browse-html-save-cid-content)
    (gnus-article-browse-html-parts, gnus-mime-delete-part)
    (gnus-mime-copy-part, gnus-mime-inline-part, gnus-insert-mime-button):
    Use `mm-handle-filename'.
    mm-util.el (mm-handle-filename): New function, return the filename of an handle.

introduces 

(defun mm-handle-filename (handle)
  "Return filename of HANDLE if any."
  (or (mail-content-type-get (mm-handle-type handle)
                             'name)
      (mail-content-type-get (mm-handle-disposition handle)
                             'filename)))


But mm-handle-type is a macro, so I get:

Debugger entered--Lisp error: (invalid-function mm-handle-type)
  mm-handle-type((#<buffer  *mm*> ("text/html" (charset . "utf-8")) 8bit nil nil nil nil nil))
  mm-handle-filename((#<buffer  *mm*> ("text/html" (charset . "utf-8")) 8bit nil nil nil nil nil))

This is with the bzr head of the gnus that's part of Emacs. It's entirely
possible that the issue lies in the way Emacs is compiling gnus.

Robert

Re: latest change to mm-util.el causes failure

[Leonidas Tsampros]

Robert Pluim <rpluim@gmail.com> writes:
> This change:
>
>     revno: 103715
>     author: Julien Danjou <julien@danjou.info>
>     committer: Katsumi Yamaoka <yamaoka@jpl.org>
>     branch nick: trunk
>     timestamp: Tue 2011-03-22 13:40:41 +0000
>     message:
>     mm-view.el (mm-display-inline-fontify): Make mode optional, and call normal-mode if not set. Set temp buffer unmodified to avoid kill-buffer query.
>     (mm-inline-text): Render normal text with fontification whenever possible.
>     gnus-sum.el (gnus-summary-save-parts-1):
>     gnus-art.el (gnus-article-browse-html-save-cid-content)
>     (gnus-article-browse-html-parts, gnus-mime-delete-part)
>     (gnus-mime-copy-part, gnus-mime-inline-part, gnus-insert-mime-button):
>     Use `mm-handle-filename'.
>     mm-util.el (mm-handle-filename): New function, return the filename of an handle.
>
> introduces 
>
> (defun mm-handle-filename (handle)
>   "Return filename of HANDLE if any."
>   (or (mail-content-type-get (mm-handle-type handle)
>                              'name)
>       (mail-content-type-get (mm-handle-disposition handle)
>                              'filename)))
>
>
> But mm-handle-type is a macro, so I get:
>
> Debugger entered--Lisp error: (invalid-function mm-handle-type)
>   mm-handle-type((#<buffer  *mm*> ("text/html" (charset . "utf-8")) 8bit nil nil nil nil nil))
>   mm-handle-filename((#<buffer  *mm*> ("text/html" (charset . "utf-8")) 8bit nil nil nil nil nil))
>
> This is with the bzr head of the gnus that's part of Emacs. It's entirely
> possible that the issue lies in the way Emacs is compiling gnus.
>
> Robert

I faced exactly the same problem with bzr head, removed the relevant elc
file, and everything seems fine now :)

Thanks.

Re: latest change to mm-util.el causes failure

[Lars Magne Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> This is with the bzr head of the gnus that's part of Emacs. It's entirely
> possible that the issue lies in the way Emacs is compiling gnus.

You probably have to do a "make clean" to get function<->macro changes
to work in Emacs.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: latest change to mm-util.el causes failure

[Robert Pluim]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>> This is with the bzr head of the gnus that's part of Emacs. It's entirely
>> possible that the issue lies in the way Emacs is compiling gnus.
>
> You probably have to do a "make clean" to get function<->macro changes
> to work in Emacs.

*grumble* Why don't the makefiles take care of this? *mutter* *mutter*
 :)

BTW 'make clean' is not something I like doing in an Emacs build, since
it takes forever and a day to recompile all the elisp.

Robert

Re: latest change to mm-util.el causes failure

[Olivier Sirven]

On 2011-03-29 20:20:46, Robert Pluim <rpluim@gmail.com> wrote:
> BTW 'make clean' is not something I like doing in an Emacs build, since
> it takes forever and a day to recompile all the elisp.

Agreed but the gnus build is quite fast to clean ;)

-- 
Olivier