From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/72254 Path: news.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Introduce gnus-completing-read Date: Thu, 30 Sep 2010 05:42:48 -0400 Organization: not if I can help it Message-ID: References: <1285688153-19680-1-git-send-email-julien@danjou.info> <87wrq5ammm.fsf@tardis.home.perldition.org> <87eicdacn6.fsf@tardis.home.perldition.org> <87hbh9tx2x.fsf@keller.adm.naquadah.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285839792 6017 80.91.229.12 (30 Sep 2010 09:43:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 30 Sep 2010 09:43:12 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M20628=ding+2Daccount=gmane.org@lists.math.uh.edu Thu Sep 30 11:43:09 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P1FfR-0006US-Hr for ding-account@gmane.org; Thu, 30 Sep 2010 11:43:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1P1FfQ-0000yZ-0C for ding-account@gmane.org; Thu, 30 Sep 2010 04:43:08 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1P1FfO-0000yU-IX for ding@lists.math.uh.edu; Thu, 30 Sep 2010 04:43:06 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1P1FfM-00066K-N2 for ding@lists.math.uh.edu; Thu, 30 Sep 2010 04:43:06 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1P1FfM-00035E-00 for ; Thu, 30 Sep 2010 11:43:04 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1P1FfK-0006SS-46 for ding@gnus.org; Thu, 30 Sep 2010 11:43:02 +0200 Original-Received: from lns-bzn-49f-81-56-191-143.adsl.proxad.net ([81.56.191.143]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 30 Sep 2010 11:43:02 +0200 Original-Received: from rpluim by lns-bzn-49f-81-56-191-143.adsl.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 30 Sep 2010 11:43:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-Lines: 42 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: lns-bzn-49f-81-56-191-143.adsl.proxad.net Mail-Copies-To: never User-Agent: Gnus/5.110011 (No Gnus v0.11) XEmacs/21.5-b29 (cygwin32) Cancel-Lock: sha1:LzgPNeu5cUCu6nlp2zx25ZC7It8= X-Spam-Score: 0.5 (/) X-Spam-Report: SpamAssassin (3.3.1 2010-03-16) analysis follows Bayesian score: 0.0000 Ham tokens: 0.000-1514--2810h-0s--0d--100644, 0.000-875--1624h-0s--0d--H*M:fsf, 0.000-759--1408h-0s--0d--H*u:Gnus, 0.000-492--912h-0s--0d--H*r:sk:1AlnuQ-, 0.000-492--912h-0s--0d--HX-Spam-Relays-External:80.91.229.12 Spam tokens: 0.881-1--1h-22s--0d--HX-Spam-Relays-External:sk:lns-bzn, 0.881-1--1h-22s--0d--H*RU:sk:lns-bzn, 0.860-144--1227h-22282s--0d--HX-Spam-Relays-External:quimby.gnus.org, 0.860-144--1227h-22282s--0d--H*RU:quimby.gnus.org, 0.851-1--1h-17s--0d--H*r:sk:lns-bzn Autolearn status: no 0.0 FREEMAIL_FROM Sender email is freemail (rpluim[at]gmail.com) 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED 1.5 URIBL_RHS_DOB Contains an URI of a new domain (Day Old Bread) [URIs: danjou.info] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.9 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list 0.0 T_TO_NO_BRKTS_FREEMAIL T_TO_NO_BRKTS_FREEMAIL List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:72254 Archived-At: Julien Danjou writes: > On Wed, Sep 29 2010, Lars Magne Ingebrigtsen wrote: > >> One comment -- you're using `remove-if-not', and that's a function from >> cl-seq, which we're Not Allowed to use. Could you rewrite without >> calling that function? I'm getting the following when doing J-a (gnus-agent-add-group) in the *Group* buffer. Debugger entered--Lisp error: (wrong-type-argument char-or-string-p t) read-from-minibuffer("Add to category: " t # nil nil nil nil) completing-read("Add to category: " ("default") nil nil t nil nil) gnus-std-completing-read("Add to category: " ("default") nil t nil nil) funcall(gnus-std-completing-read "Add to category: " ("default") nil t nil nil) (let ((completion-styles gnus-completion-styles)) (funcall gnus-completing-read-function (concat prompt ... ": ") collection require-match initial-input history def)) gnus-completing-read("Add to category" ("default") nil t) (intern (gnus-completing-read "Add to category" (mapcar ... gnus-category-alist) nil t)) (list (intern (gnus-completing-read "Add to category" ... nil t)) current-prefix-arg) call-interactively(gnus-agent-add-group) (dispatch-event "[internal]") Eyeballing gnus-completing-read suggests the following (untested) diff --git a/lisp/gnus-util.el b/lisp/gnus-util.el index 2f9bdd6..e736669 100644 --- a/lisp/gnus-util.el +++ b/lisp/gnus-util.el @@ -1633,7 +1633,7 @@ SPEC is a predicate specifier that contains stuff like `or', `and', (concat prompt (when def (concat " (default " def ")")) ": ") - collection require-match initial-input history def))) + collection initial-input require-match history def))) (defun gnus-graphic-display-p () (if (featurep 'xemacs) Regards Robert