Gnus development mailing list
 help / color / mirror / Atom feed
From: Xavier Maillard <zedek@gnu-rox.org>
Subject: Bad defcustom ?
Date: Thu, 04 Dec 2003 23:24:08 +0100	[thread overview]
Message-ID: <plop87fzg0te5z.fsf@gnu-rox.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi,

Dunno If I am right, but look into the code of spam.el revealed this to
me :

(defcustom spam-bogofilter-database-directory nil
  "Directory path of the Bogofilter databases."
  :type '(choice (directory 
                  :tag "Location of the Bogofilter database directory")
                 (const :tag "Use the default"))
  :group 'spam-ifile)
            ^^^^^^^^^^

Correct me if I am wrong but I think it would be better to have it in
the right customization group aka 'spam-bogofilter', no ?

If yes, then here is a small patch (my 1st contribution for Gnus :))

Cheers,

zeDek


[-- Attachment #2: Patch --]
[-- Type: application/octet-stream, Size: 366 bytes --]

--- spam.el.orig	2003-12-04 23:22:29.000000000 +0100
+++ spam.el	2003-12-04 23:22:50.000000000 +0100
@@ -374,7 +374,7 @@
   :type '(choice (directory 
 		  :tag "Location of the Bogofilter database directory")
 		 (const :tag "Use the default"))
-  :group 'spam-ifile)
+  :group 'spam-bogofilter)
 
 (defgroup spam-spamoracle nil
   "Spam spamoracle configuration."

             reply	other threads:[~2003-12-04 22:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-04 22:24 Xavier Maillard [this message]
2003-12-09 22:54 ` Ted Zlatanov
2003-12-10  0:08   ` Xavier Maillard
2003-12-10  1:03   ` Xavier Maillard
2003-12-10 20:07     ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=plop87fzg0te5z.fsf@gnu-rox.org \
    --to=zedek@gnu-rox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).