[PATCH]: Do not fetch nnrss url when unplugged

[PATCH]: Do not fetch nnrss url when unplugged

[Xavier Maillard]

Hello,

As discussed earlier this week, I had to "modify" nnrss.el to allow
offline reading of nnrss feeds.

The patch consists on checking 'gnus-plugged` value and if 't', let
fetch-nnrss function fetch the url.

Here is the patch:

--- nnrss.el.orig       2004-03-05 08:52:55.000000000 +0100
+++ nnrss.el    2004-03-03 08:24:56.000000000 +0100
@@ -259,7 +259,8 @@
       (if local
          (let ((coding-system-for-read 'binary))
            (insert-file-contents url))
-             (mm-url-insert url))
+       (if gnus-plugged
+             (mm-url-insert url)))
 
 ;; Because xml-parse-region can't deal with anything that isn't
 ;; xml and w3-parse-buffer can't deal with some xml, we have to

I don't think you need my FSF papers for such a so tiny patch ;-)
(though I should send 'em).

Regards,

zeDek
-- 
GNUSFR.ORG                       http://gnusfr.org/
EMACSFR.ORG                      http://emacsfr.org/
Xavier Maillard                  Tel: +33 6 68 04 64 37

Re: [PATCH]: Do not fetch nnrss url when unplugged

[Kevin Greiner]

Xavier Maillard <zedek@gnu-rox.org> writes:

> Hello,
>
> As discussed earlier this week, I had to "modify" nnrss.el to allow
> offline reading of nnrss feeds.
>
> The patch consists on checking 'gnus-plugged` value and if 't', let
> fetch-nnrss function fetch the url.

This patch is inappropriate.  The variable gnus-plugged should not be
visible to the backends.  Looking back at your previous thread, I
don't know why you are unable to agentize your nnrss backend.  Can you
send your nnrss server method?  Also, since I've never used nnrss, can
you point me to a public server so that I can try to reproduce your
problems here?

Kevin

Re: [PATCH]: Do not fetch nnrss url when unplugged

[Xavier Maillard]

Kevin Greiner <kgreiner <at> xpediantsolutions.com> writes:

> 
> Xavier Maillard <zedek <at> gnu-rox.org> writes:
> 
> > Hello,
> >
> > As discussed earlier this week, I had to "modify" nnrss.el to allow
> > offline reading of nnrss feeds.
> >
> > The patch consists on checking 'gnus-plugged` value and if 't', let
> > fetch-nnrss function fetch the url.
> 
> This patch is inappropriate.  The variable gnus-plugged should not be
> visible to the backends.  Looking back at your previous thread, I

Oups. I didn't know about that. What is the appropriate way to achieve this task
then ? I don't see anything about agent in 'nnrss.el'.

> don't know why you are unable to agentize your nnrss backend.  Can you

In fact when agentizing (ie adding it to the agent), it works partially. But
whenever you try to deagentize it, it fails with an error telling you this was
not handled by the agent.

Regards,

zeDek

Re: [PATCH]: Do not fetch nnrss url when unplugged

[Kevin Greiner]

Xavier Maillard <zedek@gnu-rox.org> writes:

> Kevin Greiner <kgreiner <at> xpediantsolutions.com> writes:
>
>> 
>> Xavier Maillard <zedek <at> gnu-rox.org> writes:
>> 
>> > Hello,
>> >
>> > As discussed earlier this week, I had to "modify" nnrss.el to allow
>> > offline reading of nnrss feeds.
>> >
>> > The patch consists on checking 'gnus-plugged` value and if 't', let
>> > fetch-nnrss function fetch the url.
>> 
>> This patch is inappropriate.  The variable gnus-plugged should not be
>> visible to the backends.  Looking back at your previous thread, I
>
> Oups. I didn't know about that. What is the appropriate way to achieve this task
> then ? I don't see anything about agent in 'nnrss.el'.

The agent is part of the gnus internals so a backend shouldn't need to
directly reference it.

>> don't know why you are unable to agentize your nnrss backend.  Can you
>
> In fact when agentizing (ie adding it to the agent), it works partially. But
> whenever you try to deagentize it, it fails with an error telling you this was
> not handled by the agent.

Right now, I don't know whether the agentize server (J a) failed (in
which case the J r should fail) or the remove agentized server (J r)
is failing as you indicated.  Does 'J a' update the server buffer to
display '(agent)' after the nnrss server's name?

Would you mind doing some lite debugging?  I'd like to know the value
of named-server in both gnus-agent-add-server and
gnus-agent-remove-server.

Kevin

Re: [PATCH]: Do not fetch nnrss url when unplugged

[Xavier Maillard]

On 10 mar 2004, Kevin Greiner wrote:

> > Oups. I didn't know about that. What is the appropriate way to
> > achieve this task then ? I don't see anything about agent in
> > 'nnrss.el'.
> 
> The agent is part of the gnus internals so a backend shouldn't need to
> directly reference it.

That's ok.
 
> > > don't know why you are unable to agentize your nnrss backend. Can
> > > you
> > 
> > In fact when agentizing (ie adding it to the agent), it works
> > partially. But whenever you try to deagentize it, it fails with an
> > error telling you this was not handled by the agent.
> 
> Right now, I don't know whether the agentize server (J a) failed (in
> which case the J r should fail) or the remove agentized server (J r)
> is failing as you indicated.  Does 'J a' update the server buffer to
> display '(agent)' after the nnrss server's name?

Alright. My problem seems to be fixed but don't know how. The agent
handles now correctly my nnrss entries. I think I had problem using the
'G r' method. Using 'G m' did the job. 
 
Regards
-- 
.o.                     | zedek (at) gnu-rox.org
..o Hacker Wonderland   | 
ooo                     |