Gnus development mailing list
 help / color / mirror / Atom feed
From: Max Froumentin <masmef@bath.ac.uk>
Subject: Re: URL button question
Date: 29 Jun 2000 16:01:59 +0100	[thread overview]
Message-ID: <ptvr99gedjs.fsf@mary.bath.ac.uk> (raw)
In-Reply-To: <200006281712.SAA00732@djlvig.dl.ac.uk>

Dave Love <d.love@dl.ac.uk> writes:

> The problem with the new-window-p stuff in your copy is probably
> fairly obvious.  It wasn't deemed a serious enough bug to be fixed
> post-20.4.

Although my knowledge of elisp is very small, I've had a look at
gnus-art.el and browse-url.el. What happens is that gnus calls
browse-url with only the url as an argument.  browse-url itself calls
browse-url-netscape with the same arg, so the 'new-window' arg is never set.

The obvious fix is be to have gnus call browse-url with a second
argument. What I did is replace the call to browse-url in
gnus-button-alist with 'my-browse-url-new-window' defined as:

(defun my-browse-url-new-window (url)
  (browse-url url t))

It's definitely not the best way of doing it. When I'm confident about
writing correct elisp (if that ever happens) I'll try and find a
better fix (a popup menu would be nice).

Max.



  reply	other threads:[~2000-06-29 15:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-06-13 13:57 M E Froumentin
2000-06-27 12:51 ` Dave Love
2000-06-27 13:19   ` Max Froumentin
2000-06-27 13:30     ` Kai Großjohann
2000-06-27 16:06       ` Max Froumentin
2000-06-28 17:12     ` Dave Love
2000-06-29 15:01       ` Max Froumentin [this message]
2000-06-30  0:30         ` Daniel Pittman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ptvr99gedjs.fsf@mary.bath.ac.uk \
    --to=masmef@bath.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).