From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/31563
Path: main.gmane.org!not-for-mail
From: Max Froumentin <masmef@bath.ac.uk>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: URL button question
Date: 29 Jun 2000 16:01:59 +0100
Organization: BWEMAN News server, UK
Sender: owner-ding@hpc.uh.edu
Message-ID: <ptvr99gedjs.fsf@mary.bath.ac.uk>
References: <ptvaegpk7jd.fsf@mary.bath.ac.uk> <200006271251.NAA32738@djlvig.dl.ac.uk> <ptv3dlztg6n.fsf@mary.bath.ac.uk> <200006281712.SAA00732@djlvig.dl.ac.uk>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1035167958 14827 80.91.224.250 (21 Oct 2002 02:39:18 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 02:39:18 +0000 (UTC)
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from karazm.math.uh.edu (karazm.math.uh.edu [129.7.128.1])
	by mailhost.sclp.com (Postfix) with ESMTP id 56BC7D0545
	for <jason@mailhost.sclp.com>; Thu, 29 Jun 2000 11:07:19 -0400 (EDT)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by karazm.math.uh.edu (8.9.3/8.9.3) with ESMTP id KAC27388;
	Thu, 29 Jun 2000 10:02:41 -0500 (CDT)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 29 Jun 2000 10:01:40 -0500 (CDT)
Original-Received: from mailhost.sclp.com (postfix@sclp3.sclp.com [204.252.123.139])
	by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id KAA21225
	for <ding@hpc.uh.edu>; Thu, 29 Jun 2000 10:01:29 -0500 (CDT)
Original-Received: from quimby.gnus.org (quimby.gnus.org [193.69.4.139])
	by mailhost.sclp.com (Postfix) with ESMTP id 656D7D0545
	for <ding@gnus.org>; Thu, 29 Jun 2000 11:02:02 -0400 (EDT)
Original-Received: (from news@localhost)
	by quimby.gnus.org (8.9.3/8.9.3) id RAA29147
	for ding@gnus.org; Wed, 28 Jun 2000 17:03:46 +0200 (CEST)
Original-To: ding@gnus.org
Original-Path: not-for-mail
Original-Newsgroups: gnus.ding
Original-Lines: 23
Original-NNTP-Posting-Host: mary.bath.ac.uk
Original-X-Trace: quimby.gnus.org 962204626 2524 138.38.32.14 (28 Jun 2000 15:03:46 GMT)
Original-X-Complaints-To: usenet@quimby.gnus.org
Original-NNTP-Posting-Date: 28 Jun 2000 15:03:46 GMT
User-Agent: Gnus/5.0803 (Gnus v5.8.3) Emacs/20.3
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:31563
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:31563

Dave Love <d.love@dl.ac.uk> writes:

> The problem with the new-window-p stuff in your copy is probably
> fairly obvious.  It wasn't deemed a serious enough bug to be fixed
> post-20.4.

Although my knowledge of elisp is very small, I've had a look at
gnus-art.el and browse-url.el. What happens is that gnus calls
browse-url with only the url as an argument.  browse-url itself calls
browse-url-netscape with the same arg, so the 'new-window' arg is never set.

The obvious fix is be to have gnus call browse-url with a second
argument. What I did is replace the call to browse-url in
gnus-button-alist with 'my-browse-url-new-window' defined as:

(defun my-browse-url-new-window (url)
  (browse-url url t))

It's definitely not the best way of doing it. When I'm confident about
writing correct elisp (if that ever happens) I'll try and find a
better fix (a popup menu would be nice).

Max.