From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/72524 Path: news.gmane.org!not-for-mail From: Lawrence Mitchell Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus-completing-read vs XEmacs 21.4 Date: Mon, 04 Oct 2010 17:54:39 +0100 Message-ID: References: <84bp7aujik.fsf@davestoy.home> <8462xiugqp.fsf@davestoy.home> <84zkuut1bj.fsf@davestoy.home> <84iq1ikkpp.fsf@davestoy.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1286211355 11580 80.91.229.12 (4 Oct 2010 16:55:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 4 Oct 2010 16:55:55 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M20896@lists.math.uh.edu Mon Oct 04 18:55:51 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P2oKM-0005XA-LV for ding-account@gmane.org; Mon, 04 Oct 2010 18:55:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1P2oKF-0007Zd-AO; Mon, 04 Oct 2010 11:55:43 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1P2oKD-0007ZO-VT for ding@lists.math.uh.edu; Mon, 04 Oct 2010 11:55:41 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1P2oKC-0004Cq-MK for ding@lists.math.uh.edu; Mon, 04 Oct 2010 11:55:41 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1P2oKB-0007JP-00 for ; Mon, 04 Oct 2010 18:55:39 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1P2oKB-0005Uc-Pm for ding@gnus.org; Mon, 04 Oct 2010 18:55:39 +0200 Original-Received: from garnet.epcc.ed.ac.uk ([129.215.56.222]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 Oct 2010 18:55:39 +0200 Original-Received: from wence by garnet.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 Oct 2010 18:55:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: garnet.epcc.ed.ac.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (usg-unix-v) Cancel-Lock: sha1:xrOIFLe8x1k8PpQ5PXFUNxhjUqE= X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:72524 Archived-At: Julien Danjou wrote: > On Mon, Oct 04 2010, Lawrence Mitchell wrote: >> This is almost certainly because old (for some value of old) >> versions of Emacs and XEmacs expect the second value of >> try-completion to be an alist and the car of each element is >> checked for matching. > Okay, fix pushed. I hate that XEmacs. :-) That is almost certainly the wrong fix, since it now breaks if collection is a hash-table or a function. In addition it does needless work if collection is an obarray. Hence why my suggested fix special-cased on collection being a list. Additionally, my misleading lack of comma in the paragraph above has lead to an incorrect comment. It should be something more like: ;; Old versions of Emacs (21.4 and below) and XEmacs expect that ;; a listp collection is actually an alist, the cars of whose ;; elements are tested for completion candidates Lawrence -- Lawrence Mitchell