* Inactive groups got unshown by `l'
@ 2010-09-06 7:55 Katsumi Yamaoka
2010-09-06 20:26 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-06 7:55 UTC (permalink / raw)
To: ding
Hi,
I use the group level 1, 2 and 3 for the mail groups, the interesting
nntp groups, and the other nntp groups respectively. Furthermore,
I use the level 4 for some foreign groups that take time to open.
I usually start Gnus as `C-u 2 M-x gnus', i.e., I usually read only
the mail groups and some news groups. But when I want to read one
of the level 4 groups, I used to type `l' in the group buffer and
find it. Now it doesn't work although the level is less than
`gnus-group-default-list-level'. The server for those groups is not
shown in the server buffer. I can use `L' instead of `l', or
the following advice. But it's a bit inconvenient for me. :<
(defadvice gnus-group-prepare-flat (before list-all-groups activate)
"Force list all groups."
(unless (ad-get-arg 1)
(ad-set-arg
1
(lambda (info)
(<= (gnus-info-level info) (ad-get-arg 0))))))
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-06 7:55 Inactive groups got unshown by `l' Katsumi Yamaoka
@ 2010-09-06 20:26 ` Lars Magne Ingebrigtsen
2010-09-07 4:25 ` Katsumi Yamaoka
0 siblings, 1 reply; 16+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-06 20:26 UTC (permalink / raw)
To: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> I use the group level 1, 2 and 3 for the mail groups, the interesting
> nntp groups, and the other nntp groups respectively. Furthermore,
> I use the level 4 for some foreign groups that take time to open.
> I usually start Gnus as `C-u 2 M-x gnus', i.e., I usually read only
> the mail groups and some news groups. But when I want to read one
> of the level 4 groups, I used to type `l' in the group buffer and
> find it. Now it doesn't work although the level is less than
> `gnus-group-default-list-level'. The server for those groups is not
> shown in the server buffer. I can use `L' instead of `l', or
> the following advice. But it's a bit inconvenient for me. :<
Yes. I've now changed the `g' function to use the explicit level for
foreign groups, too, so that `4 g' should work as advertised.
However, I'm not quite sure that I'm totally seeing what you're seeing.
The `l' command hasn't been changed at all, lately, I think, so there
must be some kind of subtle interaction between `l' and `g' that I'm not
quite handling right now...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-06 20:26 ` Lars Magne Ingebrigtsen
@ 2010-09-07 4:25 ` Katsumi Yamaoka
2010-09-07 5:07 ` Katsumi Yamaoka
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-07 4:25 UTC (permalink / raw)
To: ding
Lars Magne Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> I use the group level 1, 2 and 3 for the mail groups, the interesting
>> nntp groups, and the other nntp groups respectively. Furthermore,
>> I use the level 4 for some foreign groups that take time to open.
>> I usually start Gnus as `C-u 2 M-x gnus', i.e., I usually read only
>> the mail groups and some news groups. But when I want to read one
>> of the level 4 groups, I used to type `l' in the group buffer and
>> find it. Now it doesn't work although the level is less than
>> `gnus-group-default-list-level'. The server for those groups is not
>> shown in the server buffer. I can use `L' instead of `l', or
>> the following advice. But it's a bit inconvenient for me. :<
I got to think I may want to change the lifestyle in Gnus after
all. ;-)
> Yes. I've now changed the `g' function to use the explicit level for
> foreign groups, too,
By the change, Gnus got to show many native groups having no unread
article even though `gnus-permanently-visible-groups' doesn't match
those groups. I think it should be fixed (or reverted?). OTOH, `l'
still doesn't show inactive foreign groups (i.e., groups of which
the server have never been opened).
> so that `4 g' should work as advertised.
As for me that takes a long time because it updates all the level 4
groups and also the level 1, 2, 3 groups (= mostly all the groups).
Instead... the old behavior for years was that `l' shows inactive
groups with `*' (not a number) as the number of articles. And I
was able to update only some groups one by one using `M-g'
(gnus-group-get-new-news-this-group).
> However, I'm not quite sure that I'm totally seeing what you're seeing.
> The `l' command hasn't been changed at all, lately, I think, so there
> must be some kind of subtle interaction between `l' and `g' that I'm not
> quite handling right now...
I haven't yet investigated what changed the behavior. But which
do you think reasonable?
1. `l' shows only active groups of which the levels are less than
or equal to `gnus-group-default-list-level'.
2. `l' shows active and inactive groups of which the levels are
less than or equal to `gnus-group-default-list-level'.
If the former is adopted, only `L' is the means to recall what
inactive groups a user subscribes to are. A user cannot browse
inactive servers (i.e., servers that have never been opened) to
know what groups are there because they are not listed in the
server buffer.
I can live with `L', though. ;-)
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 4:25 ` Katsumi Yamaoka
@ 2010-09-07 5:07 ` Katsumi Yamaoka
2010-09-07 16:25 ` Lars Magne Ingebrigtsen
2010-09-07 5:48 ` Katsumi Yamaoka
2010-09-07 16:24 ` Lars Magne Ingebrigtsen
2 siblings, 1 reply; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-07 5:07 UTC (permalink / raw)
To: ding
Katsumi Yamaoka wrote:
> By the change, Gnus got to show many native groups having no unread
> article even though `gnus-permanently-visible-groups' doesn't match
> those groups. I think it should be fixed (or reverted?).
Please ignore this part. It's due to my failure (defadvice to
gnus-group-prepare-flat). Sorry for the confusion.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 4:25 ` Katsumi Yamaoka
2010-09-07 5:07 ` Katsumi Yamaoka
@ 2010-09-07 5:48 ` Katsumi Yamaoka
2010-09-07 6:39 ` Katsumi Yamaoka
2010-09-07 16:24 ` Lars Magne Ingebrigtsen
2 siblings, 1 reply; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-07 5:48 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
Katsumi Yamaoka wrote:
[...]
> I haven't yet investigated what changed the behavior. But which
> do you think reasonable?
> 1. `l' shows only active groups of which the levels are less than
> or equal to `gnus-group-default-list-level'.
> 2. `l' shows active and inactive groups of which the levels are
> less than or equal to `gnus-group-default-list-level'.
> If the former is adopted, only `L' is the means to recall what
> inactive groups a user subscribes to are. A user cannot browse
> inactive servers (i.e., servers that have never been opened) to
> know what groups are there because they are not listed in the
> server buffer.
> I can live with `L', though. ;-)
The patch below seems to achieve `2', that is the previous
behavior that Gnus has been going for years. When I start Gnus
with the prefix argument 2, the inactive level 4 groups don't
appear in the group buffer, but `l' shows them with `*'s as
numbers of those groups.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 467 bytes --]
--- gnus-group.el~ 2010-09-05 22:46:18 +0000
+++ gnus-group.el 2010-09-07 05:46:35 +0000
@@ -1350,7 +1350,8 @@
group (gnus-info-group info)
params (gnus-info-params info)
newsrc (cdr newsrc)
- unread (gnus-group-unread group))
+ unread (or (gnus-group-unread group)
+ (not (gnus-server-opened (gnus-group-method group)))))
(when not-in-list
(setq not-in-list (delete group not-in-list)))
(when (gnus-group-prepare-logic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 5:48 ` Katsumi Yamaoka
@ 2010-09-07 6:39 ` Katsumi Yamaoka
2010-09-07 7:09 ` Katsumi Yamaoka
2010-09-07 23:31 ` Katsumi Yamaoka
0 siblings, 2 replies; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-07 6:39 UTC (permalink / raw)
To: ding
Katsumi Yamaoka wrote:
> Katsumi Yamaoka wrote:
> [...]
>> I haven't yet investigated what changed the behavior. But which
>> do you think reasonable?
>> 1. `l' shows only active groups of which the levels are less than
>> or equal to `gnus-group-default-list-level'.
>> 2. `l' shows active and inactive groups of which the levels are
>> less than or equal to `gnus-group-default-list-level'.
>> If the former is adopted, only `L' is the means to recall what
>> inactive groups a user subscribes to are. A user cannot browse
>> inactive servers (i.e., servers that have never been opened) to
>> know what groups are there because they are not listed in the
>> server buffer.
>> I can live with `L', though. ;-)
> The patch below seems to achieve `2', that is the previous
> behavior that Gnus has been going for years. When I start Gnus
> with the prefix argument 2, the inactive level 4 groups don't
> appear in the group buffer, but `l' shows them with `*'s as
> numbers of those groups.
Please ignore it, too. Sorry.
By the patch, `l' doesn't show groups that have never been read
if the server is opened for the other groups that the server
provides. (Even if it worked, `gnus-group-method' used in the
patch should have been replaced with `gnus-group-name-to-method'.)
Sigh.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 6:39 ` Katsumi Yamaoka
@ 2010-09-07 7:09 ` Katsumi Yamaoka
2010-09-07 8:48 ` Lawrence Mitchell
2010-09-07 16:26 ` Lars Magne Ingebrigtsen
2010-09-07 23:31 ` Katsumi Yamaoka
1 sibling, 2 replies; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-07 7:09 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]
Katsumi Yamaoka wrote:
> Katsumi Yamaoka wrote:
>> Katsumi Yamaoka wrote:
>> [...]
>>> I haven't yet investigated what changed the behavior. But which
>>> do you think reasonable?
>>> 1. `l' shows only active groups of which the levels are less than
>>> or equal to `gnus-group-default-list-level'.
>>> 2. `l' shows active and inactive groups of which the levels are
>>> less than or equal to `gnus-group-default-list-level'.
>>> If the former is adopted, only `L' is the means to recall what
>>> inactive groups a user subscribes to are. A user cannot browse
>>> inactive servers (i.e., servers that have never been opened) to
>>> know what groups are there because they are not listed in the
>>> server buffer.
>>> I can live with `L', though. ;-)
>> The patch below seems to achieve `2', that is the previous
>> behavior that Gnus has been going for years. When I start Gnus
>> with the prefix argument 2, the inactive level 4 groups don't
>> appear in the group buffer, but `l' shows them with `*'s as
>> numbers of those groups.
> Please ignore it, too. Sorry.
> By the patch, `l' doesn't show groups that have never been read
> if the server is opened for the other groups that the server
> provides. (Even if it worked, `gnus-group-method' used in the
> patch should have been replaced with `gnus-group-name-to-method'.)
> Sigh.
This may be the third time lucky:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 411 bytes --]
--- gnus-group.el~ 2010-09-05 22:46:18 +0000
+++ gnus-group.el 2010-09-07 07:03:23 +0000
@@ -1350,7 +1350,7 @@
group (gnus-info-group info)
params (gnus-info-params info)
newsrc (cdr newsrc)
- unread (gnus-group-unread group))
+ unread (or (gnus-group-unread group) t))
(when not-in-list
(setq not-in-list (delete group not-in-list)))
(when (gnus-group-prepare-logic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 7:09 ` Katsumi Yamaoka
@ 2010-09-07 8:48 ` Lawrence Mitchell
2010-09-07 23:18 ` Katsumi Yamaoka
2010-09-07 16:26 ` Lars Magne Ingebrigtsen
1 sibling, 1 reply; 16+ messages in thread
From: Lawrence Mitchell @ 2010-09-07 8:48 UTC (permalink / raw)
To: ding
Katsumi Yamaoka wrote:
[...]
> --- gnus-group.el~ 2010-09-05 22:46:18 +0000
>>>> gnus-group.el 2010-09-07 07:03:23 +0000
> @@ -1350,7 +1350,7 @@
> group (gnus-info-group info)
> params (gnus-info-params info)
> newsrc (cdr newsrc)
> - unread (gnus-group-unread group))
>> unread (or (gnus-group-unread group) t))
> (when not-in-list
> (setq not-in-list (delete group not-in-list)))
> (when (gnus-group-prepare-logic
(or (gnus-group-unread group) t)
AKA
t
Which at least superficially doesn't seem right.
Lawrence
--
Lawrence Mitchell <wence@gmx.li>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 4:25 ` Katsumi Yamaoka
2010-09-07 5:07 ` Katsumi Yamaoka
2010-09-07 5:48 ` Katsumi Yamaoka
@ 2010-09-07 16:24 ` Lars Magne Ingebrigtsen
2 siblings, 0 replies; 16+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-07 16:24 UTC (permalink / raw)
To: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> By the change, Gnus got to show many native groups having no unread
> article even though `gnus-permanently-visible-groups' doesn't match
> those groups.
Hm... I don't see that...
> I haven't yet investigated what changed the behavior. But which
> do you think reasonable?
>
> 1. `l' shows only active groups of which the levels are less than
> or equal to `gnus-group-default-list-level'.
>
> 2. `l' shows active and inactive groups of which the levels are
> less than or equal to `gnus-group-default-list-level'.
I think 2) is how it's supposed to work. It's what I was aiming for,
anyway. :-)
I'll try restarting Emacs to check whether I have any artifacts going
on...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 5:07 ` Katsumi Yamaoka
@ 2010-09-07 16:25 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 16+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-07 16:25 UTC (permalink / raw)
To: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> By the change, Gnus got to show many native groups having no unread
>> article even though `gnus-permanently-visible-groups' doesn't match
>> those groups. I think it should be fixed (or reverted?).
>
> Please ignore this part. It's due to my failure (defadvice to
> gnus-group-prepare-flat). Sorry for the confusion.
I should read the entire thread before replying. :-)
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 7:09 ` Katsumi Yamaoka
2010-09-07 8:48 ` Lawrence Mitchell
@ 2010-09-07 16:26 ` Lars Magne Ingebrigtsen
2010-09-07 23:08 ` Katsumi Yamaoka
1 sibling, 1 reply; 16+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-07 16:26 UTC (permalink / raw)
To: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> This may be the third time lucky:
> --- gnus-group.el~ 2010-09-05 22:46:18 +0000
> +++ gnus-group.el 2010-09-07 07:03:23 +0000
> @@ -1350,7 +1350,7 @@
> group (gnus-info-group info)
> params (gnus-info-params info)
> newsrc (cdr newsrc)
> - unread (gnus-group-unread group))
> + unread (or (gnus-group-unread group) t))
> (when not-in-list
> (setq not-in-list (delete group not-in-list)))
> (when (gnus-group-prepare-logic
Yeah, try installing that patch and we'll see what happens. :-)
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 16:26 ` Lars Magne Ingebrigtsen
@ 2010-09-07 23:08 ` Katsumi Yamaoka
2010-09-09 6:10 ` Katsumi Yamaoka
0 siblings, 1 reply; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-07 23:08 UTC (permalink / raw)
To: ding
Lars Magne Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> This may be the third time lucky:
>> --- gnus-group.el~ 2010-09-05 22:46:18 +0000
>> +++ gnus-group.el 2010-09-07 07:03:23 +0000
>> @@ -1350,7 +1350,7 @@
>> group (gnus-info-group info)
>> params (gnus-info-params info)
>> newsrc (cdr newsrc)
>> - unread (gnus-group-unread group))
>> + unread (or (gnus-group-unread group) t))
>> (when not-in-list
>> (setq not-in-list (delete group not-in-list)))
>> (when (gnus-group-prepare-logic
> Yeah, try installing that patch and we'll see what happens. :-)
Thanks. I'm going to try it, or similar but better one if any,
later (now I'm not in a usual place).
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 8:48 ` Lawrence Mitchell
@ 2010-09-07 23:18 ` Katsumi Yamaoka
0 siblings, 0 replies; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-07 23:18 UTC (permalink / raw)
To: ding
Lawrence Mitchell wrote:
[...]
> (or (gnus-group-unread group) t)
> AKA
> t
Those aren't the same. `(gnus-group-unread group)' returns a number
or nil. But
> Which at least superficially doesn't seem right.
I suspect it, too. I'll look into old Gnus versions.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 6:39 ` Katsumi Yamaoka
2010-09-07 7:09 ` Katsumi Yamaoka
@ 2010-09-07 23:31 ` Katsumi Yamaoka
1 sibling, 0 replies; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-07 23:31 UTC (permalink / raw)
To: ding
Robert Pluim wrote:
[...]
> Loading cus-dep...
> xemacs exiting.
> Cannot open load file: "advice"make[1]: *** [gnus-load.el] Error 255
> make[1]: Leaving directory `/cygdrive/c/Documents and Settings/RPluim/.xemacs/gnus/lisp'
> make: *** [lick] Error 2
I've introduced defadvice to directory-files in order to exclude
the lisp/.dir-locals.el file. So, I may be the culprit, though
I have no such problem in building the latest Gnus with XEmacs.
I'll look into it further...
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-07 23:08 ` Katsumi Yamaoka
@ 2010-09-09 6:10 ` Katsumi Yamaoka
2010-09-09 13:06 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 16+ messages in thread
From: Katsumi Yamaoka @ 2010-09-09 6:10 UTC (permalink / raw)
To: ding
Katsumi Yamaoka wrote:
> Lars Magne Ingebrigtsen wrote:
>> Yeah, try installing that patch and we'll see what happens. :-)
> Thanks. I'm going to try it, or similar but better one if any,
> later (now I'm not in a usual place).
I found out the cause of `l' not listing inactive groups at last.
This was made in `gnus-get-unread-articles' by the changes:
via 7cce28b2d41e11d65102b8910ee9efc361b720ca (commit)
via bae6dd8488ad8f6e7edacba9cce916ab73f8abf9 (commit)
via cbb6b60d34cf32d84fc608cb96c22f6334ae6515 (commit)
from b40f6569ce2ef62e8a5716cb9ec56cf8de25f195 (commit)
Cf. http://article.gmane.org/gmane.emacs.gnus.cvs/9936
The old version of `gnus-get-unread-articles' set the number of
unread articles of inactive groups to t as follows:
- ;; The group couldn't be reached, so we nix out the number of
- ;; unread articles and stuff.
- (gnus-set-active group nil)
- (let ((tmp (gnus-group-entry group)))
- (when tmp
- (setcar tmp t))))))
So, previously when I started Gnus with the argument 2, it marked
the level 3~5 groups with t, and `gnus-group-prepare-flat' didn't
ignore those inactive groups when the `l' command was invoked.
However, the present code doesn't do it, therefore the form
`(gnus-group-unread "method+inactive_server:a_group")', that
`gnus-group-prepare-flat' runs, always returns nil. I've added
a similar code to `gnus-get-unread-articles'.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Inactive groups got unshown by `l'
2010-09-09 6:10 ` Katsumi Yamaoka
@ 2010-09-09 13:06 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 16+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-09 13:06 UTC (permalink / raw)
To: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> However, the present code doesn't do it, therefore the form
> `(gnus-group-unread "method+inactive_server:a_group")', that
> `gnus-group-prepare-flat' runs, always returns nil. I've added
> a similar code to `gnus-get-unread-articles'.
Great!
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2010-09-09 13:06 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-06 7:55 Inactive groups got unshown by `l' Katsumi Yamaoka
2010-09-06 20:26 ` Lars Magne Ingebrigtsen
2010-09-07 4:25 ` Katsumi Yamaoka
2010-09-07 5:07 ` Katsumi Yamaoka
2010-09-07 16:25 ` Lars Magne Ingebrigtsen
2010-09-07 5:48 ` Katsumi Yamaoka
2010-09-07 6:39 ` Katsumi Yamaoka
2010-09-07 7:09 ` Katsumi Yamaoka
2010-09-07 8:48 ` Lawrence Mitchell
2010-09-07 23:18 ` Katsumi Yamaoka
2010-09-07 16:26 ` Lars Magne Ingebrigtsen
2010-09-07 23:08 ` Katsumi Yamaoka
2010-09-09 6:10 ` Katsumi Yamaoka
2010-09-09 13:06 ` Lars Magne Ingebrigtsen
2010-09-07 23:31 ` Katsumi Yamaoka
2010-09-07 16:24 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).