Gnus development mailing list
 help / color / mirror / Atom feed
* mm-decode.el bugfix patch for ido.el compatibility
@ 2004-04-14 21:19 Karl Chen
  2004-04-14 23:11 ` Katsumi Yamaoka
  0 siblings, 1 reply; 3+ messages in thread
From: Karl Chen @ 2004-04-14 21:19 UTC (permalink / raw)



Dear Gnus/mm-decode.el maintainers:

The patch below fixes an argument error in mm-save-part that
prevents it from working correctly when ido-mode (ido.el) is
enabled.


--- mm-decode.el	01 Sep 2003 08:45:24 -0700	1.14
+++ mm-decode.el	14 Apr 2004 14:14:19 -0700	
@@ -686,10 +686,12 @@
     (when filename
       (setq filename (file-name-nondirectory filename)))
     (setq file
-	  (read-file-name "Save MIME part to: "
-			  (expand-file-name
-			   (or filename name "")
-			   (or mm-default-directory default-directory))))
+          (expand-file-name
+           (read-file-name "Save MIME part to: "
+                           (or mm-default-directory default-directory)
+                           nil
+                           nil
+			   (or filename name))))
     (setq mm-default-directory (file-name-directory file))
     (when (or (not (file-exists-p file))
 	      (yes-or-no-p (format "File %s already exists; overwrite? "


-- 
Karl 2004-04-14 14:14



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mm-decode.el bugfix patch for ido.el compatibility
  2004-04-14 21:19 mm-decode.el bugfix patch for ido.el compatibility Karl Chen
@ 2004-04-14 23:11 ` Katsumi Yamaoka
  2004-05-04 20:21   ` Karl Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Katsumi Yamaoka @ 2004-04-14 23:11 UTC (permalink / raw)
  Cc: ding

Hi,

>>>>> In <quack.20040414T1419.j5oepu8dgu@hkn.eecs.berkeley.edu>
>>>>>	Karl Chen <quarl@hkn.eecs.berkeley.edu> wrote:

> Dear Gnus/mm-decode.el maintainers:

> The patch below fixes an argument error in mm-save-part that
> prevents it from working correctly when ido-mode (ido.el) is
> enabled.

`expand-file-name' has no longer been used since Oort Gnus v0.06
released in May, 2002.

> --- mm-decode.el	01 Sep 2003 08:45:24 -0700	1.14
> +++ mm-decode.el	14 Apr 2004 14:14:19 -0700	
> @@ -686,10 +686,12 @@
[...]
>      (setq file
> -	  (read-file-name "Save MIME part to: "
> -			  (expand-file-name
> -			   (or filename name "")
> -			   (or mm-default-directory default-directory))))
> +          (expand-file-name
> +           (read-file-name "Save MIME part to: "
> +                           (or mm-default-directory default-directory)
> +                           nil
> +                           nil
> +			   (or filename name))))

Here's the latest form:

    (setq file
	  (mm-with-multibyte
	    (read-file-name "Save MIME part to: "
			    (or mm-default-directory default-directory)
			    nil nil (or filename name ""))))

Does it solve your problem?

Regards,
-- 
Katsumi Yamaoka <yamaoka@jpl.org>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mm-decode.el bugfix patch for ido.el compatibility
  2004-04-14 23:11 ` Katsumi Yamaoka
@ 2004-05-04 20:21   ` Karl Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Karl Chen @ 2004-05-04 20:21 UTC (permalink / raw)
  Cc: ding


I upgraded from 5.10.3 to 5.10.6 and it works fine now.  Thanks :)

>>>>> "Katsumi" == Katsumi Yamaoka <yamaoka@jpl.org> writes:
    Katsumi> 
    Katsumi> Hi,
>>>>> In <quack.20040414T1419.j5oepu8dgu@hkn.eecs.berkeley.edu>
    >>>>>> Karl Chen <quarl@hkn.eecs.berkeley.edu> wrote:
    Katsumi> 
    >> Dear Gnus/mm-decode.el maintainers:
    Katsumi> 
    >> The patch below fixes an argument error in mm-save-part
    >> that prevents it from working correctly when ido-mode
    >> (ido.el) is enabled.
    Katsumi> 
    Katsumi> `expand-file-name' has no longer been used since Oort
    Katsumi> Gnus v0.06 released in May, 2002.
    Katsumi> 
    >> --- mm-decode.el 01 Sep 2003 08:45:24 -0700 1.14
    >> +++ mm-decode.el 14 Apr 2004 14:14:19 -0700
    >> @@ -686,10 +686,12 @@
    Katsumi> [...]
    >> (setq file
    >> - (read-file-name "Save MIME part to: "
    >> - (expand-file-name
    >> - (or filename name "")
    >> - (or mm-default-directory default-directory))))
    >> + (expand-file-name
    >> + (read-file-name "Save MIME part to: "
    >> + (or mm-default-directory default-directory)
    >> + nil
    >> + nil
    >> + (or filename name))))
    Katsumi> 
    Katsumi> Here's the latest form:
    Katsumi> 
    Katsumi>     (setq file
    Katsumi> 	  (mm-with-multibyte
    Katsumi> 	    (read-file-name "Save MIME part to: "
    Katsumi> 			    (or mm-default-directory
    Katsumi> 			    default-directory) nil nil (or
    Katsumi> 			    filename name ""))))
    Katsumi> 
    Katsumi> Does it solve your problem?
    Katsumi> 
    Katsumi> Regards, -- Katsumi Yamaoka <yamaoka@jpl.org>
    Katsumi> 
-- 
Karl 2004-05-04 13:20



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-05-04 20:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-14 21:19 mm-decode.el bugfix patch for ido.el compatibility Karl Chen
2004-04-14 23:11 ` Katsumi Yamaoka
2004-05-04 20:21   ` Karl Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).