Re: 5.10 summary menubar broken on XEmacs

[Adrian Aichner <adrian@xemacs.org>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Sat, Apr 02 2005, Adrian Aichner wrote:
>
>> Steve Youngs <steve@youngs.au.com> writes:
> [...]
>>> The menubar in the summary buffer is broken on XEmacs[1] with Gnus
>>> 5.10.7.  Trying to access any menu in the summary buffer with a mouse
>>> gives: 
>>>
>>>   "Unrecognized menu descriptor", t
> [...]
>> The error message is printed by
>>
>>        ;; (t (signal 'error (list "unrecognized menu descriptor" menuitem))))
>>        (t (message "unrecognized menu descriptor %s" (prin1-to-string menuitem))))
> [...]
>> (t ["Respool article..." gnus-summary-respool-article t] 
>

Hi Reiner, thanks for looking at this!

> Does the problem also appear in Gnus 5.10.6?  If not, could you revert

I don't think so.

People are having problems since they sarted using the latest gnus
pre-release package (which is Steve's sync with 5.10.7).

> my 2004-10-18 change[1] in `gnus-sum.el' and see if the problem goes
> away?

Better yet, I found this promising ChangeLog entry:

2004-08-30  Katsumi Yamaoka  <yamaoka@jpl.org>
<24 lines deleted by Adrian Aichner>
	* gnus-sum.el (gnus-summary-make-menu-bar): Avoid the
	"Unrecognized menu descriptor" error in XEmacs.

And sure enough, applying this minimalistic patch to
xemacs-packages/gnus fixes the problem for me:

Index: gnus-sum.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/gnus-sum.el,v
retrieving revision 1.6
diff -u -u -r1.6 gnus-sum.el
--- gnus-sum.el	13 Mar 2005 00:23:28 -0000	1.6
+++ gnus-sum.el	2 Apr 2005 15:25:15 -0000
@@ -2250,7 +2250,7 @@
 	       ,@(if (featurep 'xemacs) '(t)
 		   '(:help "Generate and print a PostScript image"))])
 	     ("Copy, move,... (Backend)"
-	      ,@(if (featurep 'xemacs) '(t)
+	      ,@(if (featurep 'xemacs) nil
 		  '(:help "Copying, moving, expiring articles..."))
 	      ["Respool article..." gnus-summary-respool-article t]
 	      ["Move article..." gnus-summary-move-article

Steve, could you please review your gnus xemacs package sync to make
sure there aren't other things that were missed?  Do you know why this
change from 2004-08-30 did not make it over in your sync?

>
> This is this only change directly related to the summary buffer menu.
> Probably (I don't have CVS access here) it contained this hunk:
>
> ,----[ 5.10.6 vs. current v5-10 ]
> |               ["Print with Muttprint..." gnus-summary-muttprint t]
> | -             ["Print" gnus-summary-print-article t])
> | -            ("Backend"
> | +             ["Print" gnus-summary-print-article
> | +              ,@(if (featurep 'xemacs) '(t)
> | +                  '(:help "Generate and print a PostScript image"))])
> | +            ("Copy, move,... (Backend)"
> | +             ,@(if (featurep 'xemacs) '(t)
> | +                 '(:help "Copying, moving, expiring articles..."))
> |               ["Respool article..." gnus-summary-respool-article t]
> `----
>
> As this change is also in the trunk, I'm quite surprised that we
> didn't get complaints from XEmacs users up to now.
>
> BTW, are these (if (featurep 'xemacs) ...) conditionals still
> necessary?  IOW, does XEmacs' easy-menu-define allow the help text
> (tool tip) argument?

I have not found any evidence that it does.

I think these are still necessary.

Adrian

>
> Bye, Reiner.
>
> [1] 2004-10-18  Reiner Steib  <Reiner.Steib@gmx.de>
> 	* gnus-sum.el (gnus-summary-make-menu-bar): Add help texts.

-- 
Adrian Aichner
 mailto:adrian@xemacs.org
 http://www.xemacs.org/