Gnus development mailing list
 help / color / mirror / Atom feed
* 5.10 summary menubar broken on XEmacs
@ 2005-04-02  0:57 Steve Youngs
  2005-04-02  9:52 ` Adrian Aichner
  0 siblings, 1 reply; 4+ messages in thread
From: Steve Youngs @ 2005-04-02  0:57 UTC (permalink / raw)
  Cc: XEmacs Beta

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

Hi Folks!

The menubar in the summary buffer is broken on XEmacs[1] with Gnus
5.10.7.  Trying to access any menu in the summary buffer with a mouse
gives: 

  "Unrecognized menu descriptor", t

And for some reason, I can't produce a useful backtrace so I'm kinda
stuck with trying to debug this.

Can anyone shed any light?

Other menubars seem to be unaffected... group buffer, server buffer,
message buffer all are fine.

Footnotes: 
[1]  SXEmacs 22.1.2, XEmacs 21.4, and XEmacs 21.5 are affected.
     Apparently XEmacs 21.5 is worst as it is dumping core with this.
     SXEmacs and XEmacs 21.4 just give the error.

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|                   Te audire no possum.                   |
|             Musa sapientum fixa est in aure.             |
|----------------------------------<steve@youngs.au.com>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 5.10 summary menubar broken on XEmacs
  2005-04-02  0:57 5.10 summary menubar broken on XEmacs Steve Youngs
@ 2005-04-02  9:52 ` Adrian Aichner
  2005-04-02 13:20   ` Reiner Steib
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Aichner @ 2005-04-02  9:52 UTC (permalink / raw)
  Cc: XEmacs Beta

[-- Attachment #1: Type: text/plain, Size: 2322 bytes --]

Steve Youngs <steve@youngs.au.com> writes:

> Hi Folks!
>
> The menubar in the summary buffer is broken on XEmacs[1] with Gnus
> 5.10.7.  Trying to access any menu in the summary buffer with a mouse
> gives: 
>
>   "Unrecognized menu descriptor", t
>
> And for some reason, I can't produce a useful backtrace so I'm kinda
> stuck with trying to debug this.
>
> Can anyone shed any light?

Hi Steve, ding, xemacs-beta, I can reproduce this nicely, without
crashes, in
XEmacs 21.5  (beta20) "cilantro" (+CVS-20050330) [Lucid] (i586-pc-win32, Mule) of Thu Mar 31 2005 on D5DC120J
when entering a group from the *Group* buffer using
RET runs the command gnus-group-select-group

The error message is printed by

       ;; (t (signal 'error (list "unrecognized menu descriptor" menuitem))))
       (t (message "unrecognized menu descriptor %s" (prin1-to-string menuitem))))

in

(defun check-menu-syntax (menu &optional menubar-p)

of
xemacs-21.5-clean\lisp\menubar.el
(xemacs-21.5-clean is my xemacs 21.5 (CVS HEAD) workspace directory
reasonably clean of local modifications)

e.g. when the menu argument comes in as:

(t ["Respool article..." gnus-summary-respool-article t] ["Move article..." gnus-summary-move-article (gnus-check-backend-function (quote request-move-article) gnus-newsgroup-name)] ["Copy article..." gnus-summary-copy-article t] ["Crosspost article..." gnus-summary-crosspost-article (gnus-check-backend-function (quote request-replace-article) gnus-newsgroup-name)] ["Import file..." gnus-summary-import-article (gnus-check-backend-function (quote request-accept-article) gnus-newsgroup-name)] ["Create article..." gnus-summary-create-article (gnus-check-backend-function (quote request-accept-article) gnus-newsgroup-name)] ["Check if posted" gnus-summary-article-posted-p t] ["Edit article" gnus-summary-edit-article (not (gnus-group-read-only-p))] ["Delete article" gnus-summary-delete-article (gnus-check-backend-function (quote request-expire-articles) gnus-newsgroup-name)] ["Query respool" gnus-summary-respool-query t] ["Trace respool" gnus-summary-respool-trace t] ["Delete expirable articles" gnus-summary-expire-articles-now (gnus-check-backend-function (quote request-expire-articles) gnus-newsgroup-name)])

Here is the backtrace to fit above case:


[-- Attachment #2: gnus-unrecognized-menu-descriptor.txt --]
[-- Type: text/plain, Size: 27672 bytes --]

  (cond ((edebug-after ... 82 ...) (edebug-after ... 102 ...)) ((edebug-after ... 105 ...) (edebug-after ... 112 ...)) ((edebug-after ... 115 ...) (edebug-after ... 118 ...)) ((edebug-after ... 121 ...) (edebug-after ... 240 ...)) (t (edebug-after ... 245 ...)))
  (while (edebug-after 0 73 menu) (edebug-after (edebug-before 74) 78 (setq menuitem ...)) (edebug-after (edebug-before 79) 246 (cond ... ... ... ... ...)) (edebug-after (edebug-before 247) 251 (setq menu ...)))
  (let (menuitem item) (edebug-after (edebug-before 21) 71 (while ... ... ... ...)) (edebug-after (edebug-before 72) 252 (while ... ... ... ...)))
  check-menu-syntax(("Copy, move,... (Backend)" t ["Respool article..." gnus-summary-respool-article t] ["Move article..." gnus-summary-move-article (gnus-check-backend-function ... gnus-newsgroup-name)] ["Copy article..." gnus-summary-copy-article t] ["Crosspost article..." gnus-summary-crosspost-article (gnus-check-backend-function ... gnus-newsgroup-name)] ["Import file..." gnus-summary-import-article (gnus-check-backend-function ... gnus-newsgroup-name)] ["Create article..." gnus-summary-create-article (gnus-check-backend-function ... gnus-newsgroup-name)] ["Check if posted" gnus-summary-article-posted-p t] ["Edit article" gnus-summary-edit-article (not ...)] ["Delete article" gnus-summary-delete-article (gnus-check-backend-function ... gnus-newsgroup-name)] ["Query respool" gnus-summary-respool-query t] ["Trace respool" gnus-summary-respool-trace t] ["Delete expirable articles" gnus-summary-expire-articles-now (gnus-check-backend-function ... gnus-newsgroup-name)]))
  (cond ((edebug-after ... 82 ...) (edebug-after ... 102 ...)) ((edebug-after ... 105 ...) (edebug-after ... 112 ...)) ((edebug-after ... 115 ...) (edebug-after ... 118 ...)) ((edebug-after ... 121 ...) (edebug-after ... 240 ...)) (t (edebug-after ... 245 ...)))
  (while (edebug-after 0 73 menu) (edebug-after (edebug-before 74) 78 (setq menuitem ...)) (edebug-after (edebug-before 79) 246 (cond ... ... ... ... ...)) (edebug-after (edebug-before 247) 251 (setq menu ...)))
  (let (menuitem item) (edebug-after (edebug-before 21) 71 (while ... ... ... ...)) (edebug-after (edebug-before 72) 252 (while ... ... ... ...)))
  check-menu-syntax(("Article" ("Hide" ["All" gnus-article-hide t] ["Headers" gnus-article-hide-headers t] ["Signature" gnus-article-hide-signature t] ["Citation" gnus-article-hide-citation t] ["List identifiers" gnus-article-hide-list-identifiers t] ["Banner" gnus-article-strip-banner t] ["Boring headers" gnus-article-hide-boring-headers t]) ("Highlight" ["All" gnus-article-highlight t] ["Headers" gnus-article-highlight-headers t] ["Signature" gnus-article-highlight-signature t] ["Citation" gnus-article-highlight-citation t]) ("MIME" ["Words" gnus-article-decode-mime-words t] ["Charset" gnus-article-decode-charset t] ["QP" gnus-article-de-quoted-unreadable t] ["Base64" gnus-article-de-base64-unreadable t] ["View MIME buttons" gnus-summary-display-buttonized t] ["View all" gnus-mime-view-all-parts t] ["Verify and Decrypt" gnus-summary-force-verify-and-decrypt t] ["Encrypt body" gnus-article-encrypt-body:active ...] ["Extract all parts..." gnus-summary-save-parts t] ("Multipart" ... ... ... ... ... ... ... ... ...)) ("Date" ["Local" gnus-article-date-local t] ["ISO8601" gnus-article-date-iso8601 t] ["UT" gnus-article-date-ut t] ["Original" gnus-article-date-original t] ["Lapsed" gnus-article-date-lapsed t] ["User-defined" gnus-article-date-user t]) ("Display" ["Remove images" gnus-article-remove-images t] ["Toggle smiley" gnus-treat-smiley t] ["Show X-Face" gnus-article-display-x-face t] ["Show picons in From" gnus-treat-from-picon t] ["Show picons in mail headers" gnus-treat-mail-picon t] ["Show picons in news headers" gnus-treat-newsgroups-picon t] ("View as different encoding" ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ...)) ("Washing" ("Remove Blanks" ... ... ... ... ... ... ... ...) ["Overstrike" gnus-article-treat-overstrike t] ["Dumb quotes" gnus-article-treat-dumbquotes t] ["Emphasis" gnus-article-emphasize t] ["Word wrap" gnus-article-fill-cited-article t] ["Fill long lines" gnus-article-fill-long-lines t] ["Capitalize sentences" gnus-article-capitalize-sentences t] ["Remove CR" gnus-article-remove-cr t] ["Quoted-Printable" gnus-article-de-quoted-unreadable t] ["Base64" gnus-article-de-base64-unreadable t] ["Rot 13" gnus-summary-caesar-message t] ["Morse decode" gnus-summary-morse-message t] ["Unix pipe..." gnus-summary-pipe-message t] ["Add buttons" gnus-article-add-buttons t] ["Add buttons to head" gnus-article-add-buttons-to-head t] ["Stop page breaking" gnus-summary-stop-page-breaking t] ["Verbose header" gnus-summary-verbose-headers t] ["Toggle header" gnus-summary-toggle-header t] ["Unfold headers" gnus-article-treat-unfold-headers t] ["Fold newsgroups" gnus-article-treat-fold-newsgroups t] ["Html" gnus-article-wash-html t] ["Unsplit URLs" gnus-article-unsplit-urls t] ["Verify X-PGP-Sig" gnus-article-verify-x-pgp-sig t] ["Decode HZ" gnus-article-decode-HZ t] ("(Outlook) Deuglify" ... ... ... ...)) ("Output" ["Save in default format..." gnus-summary-save-article t] ["Save in file..." gnus-summary-save-article-file t] ["Save in Unix mail format..." gnus-summary-save-article-mail t] ["Save in MH folder..." gnus-summary-save-article-folder t] ["Save in VM folder..." gnus-summary-save-article-vm t] ["Save in RMAIL mbox..." gnus-summary-save-article-rmail t] ["Save body in file..." gnus-summary-save-article-body-file t] ["Pipe through a filter..." gnus-summary-pipe-output t] ["Add to SOUP packet" gnus-soup-add-article t] ["Print with Muttprint..." gnus-summary-muttprint t] ["Print" gnus-summary-print-article t]) ("Copy, move,... (Backend)" t ["Respool article..." gnus-summary-respool-article t] ["Move article..." gnus-summary-move-article ...] ["Copy article..." gnus-summary-copy-article t] ["Crosspost article..." gnus-summary-crosspost-article ...] ["Import file..." gnus-summary-import-article ...] ["Create article..." gnus-summary-create-article ...] ["Check if posted" gnus-summary-article-posted-p t] ["Edit article" gnus-summary-edit-article ...] ["Delete article" gnus-summary-delete-article ...] ["Query respool" gnus-summary-respool-query t] ["Trace respool" gnus-summary-respool-trace t] ["Delete expirable articles" gnus-summary-expire-articles-now ...]) ("Extract" ["Uudecode" gnus-uu-decode-uu t] ["Uudecode and save" gnus-uu-decode-uu-and-save t] ["Unshar" gnus-uu-decode-unshar t] ["Unshar and save" gnus-uu-decode-unshar-and-save t] ["Save" gnus-uu-decode-save t] ["Binhex" gnus-uu-decode-binhex t] ["Postscript" gnus-uu-decode-postscript t] ["All MIME parts" gnus-summary-save-parts t]) ("Cache" ["Enter article" gnus-cache-enter-article t] ["Remove article" gnus-cache-remove-article t]) ["Translate" gnus-article-babel t] ["Select article buffer" gnus-summary-select-article-buffer t] ["Enter digest buffer" gnus-summary-enter-digest-group t] ["Isearch article..." gnus-summary-isearch-article t] ["Beginning of the article" gnus-summary-beginning-of-article t] ["End of the article" gnus-summary-end-of-article t] ["Fetch parent of article" gnus-summary-refer-parent-article t] ["Fetch referenced articles" gnus-summary-refer-references t] ["Fetch current thread" gnus-summary-refer-thread t] ["Fetch article with id..." gnus-summary-refer-article t] ["Setup Mailing List Params" gnus-mailing-list-insinuate t] ["Redisplay" gnus-summary-show-article t] ["Raw article" gnus-summary-show-raw-article:keys "C-u g"]) nil)
  add-submenu(nil ("Article" ("Hide" ["All" gnus-article-hide t] ["Headers" gnus-article-hide-headers t] ["Signature" gnus-article-hide-signature t] ["Citation" gnus-article-hide-citation t] ["List identifiers" gnus-article-hide-list-identifiers t] ["Banner" gnus-article-strip-banner t] ["Boring headers" gnus-article-hide-boring-headers t]) ("Highlight" ["All" gnus-article-highlight t] ["Headers" gnus-article-highlight-headers t] ["Signature" gnus-article-highlight-signature t] ["Citation" gnus-article-highlight-citation t]) ("MIME" ["Words" gnus-article-decode-mime-words t] ["Charset" gnus-article-decode-charset t] ["QP" gnus-article-de-quoted-unreadable t] ["Base64" gnus-article-de-base64-unreadable t] ["View MIME buttons" gnus-summary-display-buttonized t] ["View all" gnus-mime-view-all-parts t] ["Verify and Decrypt" gnus-summary-force-verify-and-decrypt t] ["Encrypt body" gnus-article-encrypt-body:active ...] ["Extract all parts..." gnus-summary-save-parts t] ("Multipart" ... ... ... ... ... ... ... ... ...)) ("Date" ["Local" gnus-article-date-local t] ["ISO8601" gnus-article-date-iso8601 t] ["UT" gnus-article-date-ut t] ["Original" gnus-article-date-original t] ["Lapsed" gnus-article-date-lapsed t] ["User-defined" gnus-article-date-user t]) ("Display" ["Remove images" gnus-article-remove-images t] ["Toggle smiley" gnus-treat-smiley t] ["Show X-Face" gnus-article-display-x-face t] ["Show picons in From" gnus-treat-from-picon t] ["Show picons in mail headers" gnus-treat-mail-picon t] ["Show picons in news headers" gnus-treat-newsgroups-picon t] ("View as different encoding" ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ...)) ("Washing" ("Remove Blanks" ... ... ... ... ... ... ... ...) ["Overstrike" gnus-article-treat-overstrike t] ["Dumb quotes" gnus-article-treat-dumbquotes t] ["Emphasis" gnus-article-emphasize t] ["Word wrap" gnus-article-fill-cited-article t] ["Fill long lines" gnus-article-fill-long-lines t] ["Capitalize sentences" gnus-article-capitalize-sentences t] ["Remove CR" gnus-article-remove-cr t] ["Quoted-Printable" gnus-article-de-quoted-unreadable t] ["Base64" gnus-article-de-base64-unreadable t] ["Rot 13" gnus-summary-caesar-message t] ["Morse decode" gnus-summary-morse-message t] ["Unix pipe..." gnus-summary-pipe-message t] ["Add buttons" gnus-article-add-buttons t] ["Add buttons to head" gnus-article-add-buttons-to-head t] ["Stop page breaking" gnus-summary-stop-page-breaking t] ["Verbose header" gnus-summary-verbose-headers t] ["Toggle header" gnus-summary-toggle-header t] ["Unfold headers" gnus-article-treat-unfold-headers t] ["Fold newsgroups" gnus-article-treat-fold-newsgroups t] ["Html" gnus-article-wash-html t] ["Unsplit URLs" gnus-article-unsplit-urls t] ["Verify X-PGP-Sig" gnus-article-verify-x-pgp-sig t] ["Decode HZ" gnus-article-decode-HZ t] ("(Outlook) Deuglify" ... ... ... ...)) ("Output" ["Save in default format..." gnus-summary-save-article t] ["Save in file..." gnus-summary-save-article-file t] ["Save in Unix mail format..." gnus-summary-save-article-mail t] ["Save in MH folder..." gnus-summary-save-article-folder t] ["Save in VM folder..." gnus-summary-save-article-vm t] ["Save in RMAIL mbox..." gnus-summary-save-article-rmail t] ["Save body in file..." gnus-summary-save-article-body-file t] ["Pipe through a filter..." gnus-summary-pipe-output t] ["Add to SOUP packet" gnus-soup-add-article t] ["Print with Muttprint..." gnus-summary-muttprint t] ["Print" gnus-summary-print-article t]) ("Copy, move,... (Backend)" t ["Respool article..." gnus-summary-respool-article t] ["Move article..." gnus-summary-move-article ...] ["Copy article..." gnus-summary-copy-article t] ["Crosspost article..." gnus-summary-crosspost-article ...] ["Import file..." gnus-summary-import-article ...] ["Create article..." gnus-summary-create-article ...] ["Check if posted" gnus-summary-article-posted-p t] ["Edit article" gnus-summary-edit-article ...] ["Delete article" gnus-summary-delete-article ...] ["Query respool" gnus-summary-respool-query t] ["Trace respool" gnus-summary-respool-trace t] ["Delete expirable articles" gnus-summary-expire-articles-now ...]) ("Extract" ["Uudecode" gnus-uu-decode-uu t] ["Uudecode and save" gnus-uu-decode-uu-and-save t] ["Unshar" gnus-uu-decode-unshar t] ["Unshar and save" gnus-uu-decode-unshar-and-save t] ["Save" gnus-uu-decode-save t] ["Binhex" gnus-uu-decode-binhex t] ["Postscript" gnus-uu-decode-postscript t] ["All MIME parts" gnus-summary-save-parts t]) ("Cache" ["Enter article" gnus-cache-enter-article t] ["Remove article" gnus-cache-remove-article t]) ["Translate" gnus-article-babel t] ["Select article buffer" gnus-summary-select-article-buffer t] ["Enter digest buffer" gnus-summary-enter-digest-group t] ["Isearch article..." gnus-summary-isearch-article t] ["Beginning of the article" gnus-summary-beginning-of-article t] ["End of the article" gnus-summary-end-of-article t] ["Fetch parent of article" gnus-summary-refer-parent-article t] ["Fetch referenced articles" gnus-summary-refer-references t] ["Fetch current thread" gnus-summary-refer-thread t] ["Fetch article with id..." gnus-summary-refer-article t] ["Setup Mailing List Params" gnus-mailing-list-insinuate t] ["Redisplay" gnus-summary-show-article t] ["Raw article" gnus-summary-show-raw-article:keys "C-u g"]) nil)
  add-menu(nil "Article" (("Hide" ["All" gnus-article-hide t] ["Headers" gnus-article-hide-headers t] ["Signature" gnus-article-hide-signature t] ["Citation" gnus-article-hide-citation t] ["List identifiers" gnus-article-hide-list-identifiers t] ["Banner" gnus-article-strip-banner t] ["Boring headers" gnus-article-hide-boring-headers t]) ("Highlight" ["All" gnus-article-highlight t] ["Headers" gnus-article-highlight-headers t] ["Signature" gnus-article-highlight-signature t] ["Citation" gnus-article-highlight-citation t]) ("MIME" ["Words" gnus-article-decode-mime-words t] ["Charset" gnus-article-decode-charset t] ["QP" gnus-article-de-quoted-unreadable t] ["Base64" gnus-article-de-base64-unreadable t] ["View MIME buttons" gnus-summary-display-buttonized t] ["View all" gnus-mime-view-all-parts t] ["Verify and Decrypt" gnus-summary-force-verify-and-decrypt t] ["Encrypt body" gnus-article-encrypt-body:active ...] ["Extract all parts..." gnus-summary-save-parts t] ("Multipart" ... ... ... ... ... ... ... ... ...)) ("Date" ["Local" gnus-article-date-local t] ["ISO8601" gnus-article-date-iso8601 t] ["UT" gnus-article-date-ut t] ["Original" gnus-article-date-original t] ["Lapsed" gnus-article-date-lapsed t] ["User-defined" gnus-article-date-user t]) ("Display" ["Remove images" gnus-article-remove-images t] ["Toggle smiley" gnus-treat-smiley t] ["Show X-Face" gnus-article-display-x-face t] ["Show picons in From" gnus-treat-from-picon t] ["Show picons in mail headers" gnus-treat-mail-picon t] ["Show picons in news headers" gnus-treat-newsgroups-picon t] ("View as different encoding" ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ...)) ("Washing" ("Remove Blanks" ... ... ... ... ... ... ... ...) ["Overstrike" gnus-article-treat-overstrike t] ["Dumb quotes" gnus-article-treat-dumbquotes t] ["Emphasis" gnus-article-emphasize t] ["Word wrap" gnus-article-fill-cited-article t] ["Fill long lines" gnus-article-fill-long-lines t] ["Capitalize sentences" gnus-article-capitalize-sentences t] ["Remove CR" gnus-article-remove-cr t] ["Quoted-Printable" gnus-article-de-quoted-unreadable t] ["Base64" gnus-article-de-base64-unreadable t] ["Rot 13" gnus-summary-caesar-message t] ["Morse decode" gnus-summary-morse-message t] ["Unix pipe..." gnus-summary-pipe-message t] ["Add buttons" gnus-article-add-buttons t] ["Add buttons to head" gnus-article-add-buttons-to-head t] ["Stop page breaking" gnus-summary-stop-page-breaking t] ["Verbose header" gnus-summary-verbose-headers t] ["Toggle header" gnus-summary-toggle-header t] ["Unfold headers" gnus-article-treat-unfold-headers t] ["Fold newsgroups" gnus-article-treat-fold-newsgroups t] ["Html" gnus-article-wash-html t] ["Unsplit URLs" gnus-article-unsplit-urls t] ["Verify X-PGP-Sig" gnus-article-verify-x-pgp-sig t] ["Decode HZ" gnus-article-decode-HZ t] ("(Outlook) Deuglify" ... ... ... ...)) ("Output" ["Save in default format..." gnus-summary-save-article t] ["Save in file..." gnus-summary-save-article-file t] ["Save in Unix mail format..." gnus-summary-save-article-mail t] ["Save in MH folder..." gnus-summary-save-article-folder t] ["Save in VM folder..." gnus-summary-save-article-vm t] ["Save in RMAIL mbox..." gnus-summary-save-article-rmail t] ["Save body in file..." gnus-summary-save-article-body-file t] ["Pipe through a filter..." gnus-summary-pipe-output t] ["Add to SOUP packet" gnus-soup-add-article t] ["Print with Muttprint..." gnus-summary-muttprint t] ["Print" gnus-summary-print-article t]) ("Copy, move,... (Backend)" t ["Respool article..." gnus-summary-respool-article t] ["Move article..." gnus-summary-move-article ...] ["Copy article..." gnus-summary-copy-article t] ["Crosspost article..." gnus-summary-crosspost-article ...] ["Import file..." gnus-summary-import-article ...] ["Create article..." gnus-summary-create-article ...] ["Check if posted" gnus-summary-article-posted-p t] ["Edit article" gnus-summary-edit-article ...] ["Delete article" gnus-summary-delete-article ...] ["Query respool" gnus-summary-respool-query t] ["Trace respool" gnus-summary-respool-trace t] ["Delete expirable articles" gnus-summary-expire-articles-now ...]) ("Extract" ["Uudecode" gnus-uu-decode-uu t] ["Uudecode and save" gnus-uu-decode-uu-and-save t] ["Unshar" gnus-uu-decode-unshar t] ["Unshar and save" gnus-uu-decode-unshar-and-save t] ["Save" gnus-uu-decode-save t] ["Binhex" gnus-uu-decode-binhex t] ["Postscript" gnus-uu-decode-postscript t] ["All MIME parts" gnus-summary-save-parts t]) ("Cache" ["Enter article" gnus-cache-enter-article t] ["Remove article" gnus-cache-remove-article t]) ["Translate" gnus-article-babel t] ["Select article buffer" gnus-summary-select-article-buffer t] ["Enter digest buffer" gnus-summary-enter-digest-group t] ["Isearch article..." gnus-summary-isearch-article t] ["Beginning of the article" gnus-summary-beginning-of-article t] ["End of the article" gnus-summary-end-of-article t] ["Fetch parent of article" gnus-summary-refer-parent-article t] ["Fetch referenced articles" gnus-summary-refer-references t] ["Fetch current thread" gnus-summary-refer-thread t] ["Fetch article with id..." gnus-summary-refer-article t] ["Setup Mailing List Params" gnus-mailing-list-insinuate t] ["Redisplay" gnus-summary-show-article t] ["Raw article" gnus-summary-show-raw-article:keys "C-u g"]))
  (cond ((edebug-after ... 47 ...) nil) ((edebug-after ... 53 ...) nil) ((edebug-after ... 56 ...) (edebug-after ... 61 ...)) (t (edebug-after ... 66 ...) (edebug-after ... 74 ...)))
  (progn (edebug-after (edebug-before 3) 12 (unless ... ...)) (edebug-after (edebug-before 13) 43 (setq mode-popup-menu ...)) (edebug-after (edebug-before 44) 75 (cond ... ... ... ...)))
  (if (edebug-after (edebug-before 1) 2 (featurep ...)) (progn (edebug-after ... 12 ...) (edebug-after ... 43 ...) (edebug-after ... 75 ...)))
  (when (edebug-after (edebug-before 1) 2 (featurep ...)) (edebug-after (edebug-before 3) 12 (unless ... ...)) (edebug-after (edebug-before 13) 43 (setq mode-popup-menu ...)) (edebug-after (edebug-before 44) 75 (cond ... ... ... ...)))
  easy-menu-add(("Article" ("Hide" ["All" gnus-article-hide t] ["Headers" gnus-article-hide-headers t] ["Signature" gnus-article-hide-signature t] ["Citation" gnus-article-hide-citation t] ["List identifiers" gnus-article-hide-list-identifiers t] ["Banner" gnus-article-strip-banner t] ["Boring headers" gnus-article-hide-boring-headers t]) ("Highlight" ["All" gnus-article-highlight t] ["Headers" gnus-article-highlight-headers t] ["Signature" gnus-article-highlight-signature t] ["Citation" gnus-article-highlight-citation t]) ("MIME" ["Words" gnus-article-decode-mime-words t] ["Charset" gnus-article-decode-charset t] ["QP" gnus-article-de-quoted-unreadable t] ["Base64" gnus-article-de-base64-unreadable t] ["View MIME buttons" gnus-summary-display-buttonized t] ["View all" gnus-mime-view-all-parts t] ["Verify and Decrypt" gnus-summary-force-verify-and-decrypt t] ["Encrypt body" gnus-article-encrypt-body:active ...] ["Extract all parts..." gnus-summary-save-parts t] ("Multipart" ... ... ... ... ... ... ... ... ...)) ("Date" ["Local" gnus-article-date-local t] ["ISO8601" gnus-article-date-iso8601 t] ["UT" gnus-article-date-ut t] ["Original" gnus-article-date-original t] ["Lapsed" gnus-article-date-lapsed t] ["User-defined" gnus-article-date-user t]) ("Display" ["Remove images" gnus-article-remove-images t] ["Toggle smiley" gnus-treat-smiley t] ["Show X-Face" gnus-article-display-x-face t] ["Show picons in From" gnus-treat-from-picon t] ["Show picons in mail headers" gnus-treat-mail-picon t] ["Show picons in news headers" gnus-treat-newsgroups-picon t] ("View as different encoding" ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ...)) ("Washing" ("Remove Blanks" ... ... ... ... ... ... ... ...) ["Overstrike" gnus-article-treat-overstrike t] ["Dumb quotes" gnus-article-treat-dumbquotes t] ["Emphasis" gnus-article-emphasize t] ["Word wrap" gnus-article-fill-cited-article t] ["Fill long lines" gnus-article-fill-long-lines t] ["Capitalize sentences" gnus-article-capitalize-sentences t] ["Remove CR" gnus-article-remove-cr t] ["Quoted-Printable" gnus-article-de-quoted-unreadable t] ["Base64" gnus-article-de-base64-unreadable t] ["Rot 13" gnus-summary-caesar-message t] ["Morse decode" gnus-summary-morse-message t] ["Unix pipe..." gnus-summary-pipe-message t] ["Add buttons" gnus-article-add-buttons t] ["Add buttons to head" gnus-article-add-buttons-to-head t] ["Stop page breaking" gnus-summary-stop-page-breaking t] ["Verbose header" gnus-summary-verbose-headers t] ["Toggle header" gnus-summary-toggle-header t] ["Unfold headers" gnus-article-treat-unfold-headers t] ["Fold newsgroups" gnus-article-treat-fold-newsgroups t] ["Html" gnus-article-wash-html t] ["Unsplit URLs" gnus-article-unsplit-urls t] ["Verify X-PGP-Sig" gnus-article-verify-x-pgp-sig t] ["Decode HZ" gnus-article-decode-HZ t] ("(Outlook) Deuglify" ... ... ... ...)) ("Output" ["Save in default format..." gnus-summary-save-article t] ["Save in file..." gnus-summary-save-article-file t] ["Save in Unix mail format..." gnus-summary-save-article-mail t] ["Save in MH folder..." gnus-summary-save-article-folder t] ["Save in VM folder..." gnus-summary-save-article-vm t] ["Save in RMAIL mbox..." gnus-summary-save-article-rmail t] ["Save body in file..." gnus-summary-save-article-body-file t] ["Pipe through a filter..." gnus-summary-pipe-output t] ["Add to SOUP packet" gnus-soup-add-article t] ["Print with Muttprint..." gnus-summary-muttprint t] ["Print" gnus-summary-print-article t]) ("Copy, move,... (Backend)" t ["Respool article..." gnus-summary-respool-article t] ["Move article..." gnus-summary-move-article ...] ["Copy article..." gnus-summary-copy-article t] ["Crosspost article..." gnus-summary-crosspost-article ...] ["Import file..." gnus-summary-import-article ...] ["Create article..." gnus-summary-create-article ...] ["Check if posted" gnus-summary-article-posted-p t] ["Edit article" gnus-summary-edit-article ...] ["Delete article" gnus-summary-delete-article ...] ["Query respool" gnus-summary-respool-query t] ["Trace respool" gnus-summary-respool-trace t] ["Delete expirable articles" gnus-summary-expire-articles-now ...]) ("Extract" ["Uudecode" gnus-uu-decode-uu t] ["Uudecode and save" gnus-uu-decode-uu-and-save t] ["Unshar" gnus-uu-decode-unshar t] ["Unshar and save" gnus-uu-decode-unshar-and-save t] ["Save" gnus-uu-decode-save t] ["Binhex" gnus-uu-decode-binhex t] ["Postscript" gnus-uu-decode-postscript t] ["All MIME parts" gnus-summary-save-parts t]) ("Cache" ["Enter article" gnus-cache-enter-article t] ["Remove article" gnus-cache-remove-article t]) ["Translate" gnus-article-babel t] ["Select article buffer" gnus-summary-select-article-buffer t] ["Enter digest buffer" gnus-summary-enter-digest-group t] ["Isearch article..." gnus-summary-isearch-article t] ["Beginning of the article" gnus-summary-beginning-of-article t] ["End of the article" gnus-summary-end-of-article t] ["Fetch parent of article" gnus-summary-refer-parent-article t] ["Fetch referenced articles" gnus-summary-refer-references t] ["Fetch current thread" gnus-summary-refer-thread t] ["Fetch article with id..." gnus-summary-refer-article t] ["Setup Mailing List Params" gnus-mailing-list-insinuate t] ["Redisplay" gnus-summary-show-article t] ["Raw article" gnus-summary-show-raw-article:keys "C-u g"]))
  (while (edebug-after 0 12 menus) (edebug-after (edebug-before 13) 19 (easy-menu-add ...)))
  (if (edebug-after (edebug-before 1) 10 (and ... ...)) (edebug-after (edebug-before 11) 20 (while ... ...)))
  (when (edebug-after (edebug-before 1) 10 (and ... ...)) (edebug-after (edebug-before 11) 20 (while ... ...)))
  gnus-xmas-menu-add-1(summary (gnus-summary-misc-menu gnus-summary-kill-menu gnus-summary-article-menu gnus-summary-thread-menu gnus-summary-post-menu))
  (gnus-xmas-menu-add summary gnus-summary-misc-menu gnus-summary-kill-menu gnus-summary-article-menu gnus-summary-thread-menu gnus-summary-post-menu)
  gnus-xmas-summary-menu-add()
  run-hooks(gnus-xmas-summary-menu-add)
  apply(run-hooks gnus-xmas-summary-menu-add)
  gnus-run-hooks(gnus-summary-mode-hook)
  gnus-summary-mode("nnml:T-Online")
  (if (get-buffer buffer) (progn (set-buffer buffer) (setq gnus-summary-buffer ...) (not gnus-newsgroup-prepared)) (setq gnus-summary-buffer (set-buffer ...)) (gnus-summary-mode group) (when gnus-carpal (gnus-carpal-setup-buffer ...)) (unless gnus-single-article-buffer (make-local-variable ...) (make-local-variable ...) (make-local-variable ...)) (setq gnus-newsgroup-name group) (gnus-summary-set-local-parameters gnus-newsgroup-name) t)
  (let ((buffer ...) (dead-name ...)) (when (gnus-buffer-live-p dead-name) (gnus-kill-buffer dead-name)) (if (get-buffer buffer) (progn ... ... ...) (setq gnus-summary-buffer ...) (gnus-summary-mode group) (when gnus-carpal ...) (unless gnus-single-article-buffer ... ... ...) (setq gnus-newsgroup-name group) (gnus-summary-set-local-parameters gnus-newsgroup-name) t))
  gnus-summary-setup-buffer("nnml:T-Online")
  (let* ((new-group ...) (quit-config ...) (did-select ...)) (cond (... ... ... ... ... ... ... t) (... ... ... nil) (... ... ... ... ...) (t ... ... ... ... ... ... ... ... ... ... ... ...)))
  gnus-summary-read-group-1("nnml:T-Online" nil t nil nil nil)
  (or (gnus-summary-read-group-1 group show-all no-article kill-buffer no-display select-articles) (setq show-all nil select-articles nil))
  (let ((gnus-auto-select-next nil)) (or (gnus-summary-read-group-1 group show-all no-article kill-buffer no-display select-articles) (setq show-all nil select-articles nil)))
  (setq result (let (...) (or ... ...)))
  (null (setq result (let ... ...)))
  (and group (null (setq result ...)) (eq gnus-auto-select-next (quote quietly)))
  (while (and group (null ...) (eq gnus-auto-select-next ...)) (set-buffer gnus-group-buffer) (when backward (gnus-group-prev-unread-group 2)) (if (not ...) (setq group ...) (setq group nil)))
  (let (result) (while (and group ... ...) (set-buffer gnus-group-buffer) (when backward ...) (if ... ... ...)) result)
  gnus-summary-read-group("nnml:T-Online" nil t nil nil nil nil)
  (let ((no-display ...) (group ...) number active marked entry) (when (eq all 0) (setq all nil)) (unless group (error "No group on current line")) (setq marked (gnus-info-marks ...)) (setq number (cond ... ... ...)) (gnus-summary-read-group group (or all ...) no-article nil no-display nil select-articles))
  gnus-group-read-group(nil t)
  gnus-group-select-group(nil)
  call-interactively(gnus-group-select-group)

[-- Attachment #3: Type: text/plain, Size: 474 bytes --]


I'll debug some more after shopping, cooking, perhaps some outdooring
even.

Later,

Adrian

>
> Other menubars seem to be unaffected... group buffer, server buffer,
> message buffer all are fine.
>
> Footnotes: 
> [1]  SXEmacs 22.1.2, XEmacs 21.4, and XEmacs 21.5 are affected.
>      Apparently XEmacs 21.5 is worst as it is dumping core with this.
>      SXEmacs and XEmacs 21.4 just give the error.

-- 
Adrian Aichner
 mailto:adrian@xemacs.org
 http://www.xemacs.org/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 5.10 summary menubar broken on XEmacs
  2005-04-02  9:52 ` Adrian Aichner
@ 2005-04-02 13:20   ` Reiner Steib
  2005-04-02 15:45     ` Adrian Aichner
  0 siblings, 1 reply; 4+ messages in thread
From: Reiner Steib @ 2005-04-02 13:20 UTC (permalink / raw)
  Cc: ding

On Sat, Apr 02 2005, Adrian Aichner wrote:

> Steve Youngs <steve@youngs.au.com> writes:
[...]
>> The menubar in the summary buffer is broken on XEmacs[1] with Gnus
>> 5.10.7.  Trying to access any menu in the summary buffer with a mouse
>> gives: 
>>
>>   "Unrecognized menu descriptor", t
[...]
> The error message is printed by
>
>        ;; (t (signal 'error (list "unrecognized menu descriptor" menuitem))))
>        (t (message "unrecognized menu descriptor %s" (prin1-to-string menuitem))))
[...]
> (t ["Respool article..." gnus-summary-respool-article t] 

Does the problem also appear in Gnus 5.10.6?  If not, could you revert
my 2004-10-18 change[1] in `gnus-sum.el' and see if the problem goes
away?

This is this only change directly related to the summary buffer menu.
Probably (I don't have CVS access here) it contained this hunk:

,----[ 5.10.6 vs. current v5-10 ]
|               ["Print with Muttprint..." gnus-summary-muttprint t]
| -             ["Print" gnus-summary-print-article t])
| -            ("Backend"
| +             ["Print" gnus-summary-print-article
| +              ,@(if (featurep 'xemacs) '(t)
| +                  '(:help "Generate and print a PostScript image"))])
| +            ("Copy, move,... (Backend)"
| +             ,@(if (featurep 'xemacs) '(t)
| +                 '(:help "Copying, moving, expiring articles..."))
|               ["Respool article..." gnus-summary-respool-article t]
`----

As this change is also in the trunk, I'm quite surprised that we
didn't get complaints from XEmacs users up to now.

BTW, are these (if (featurep 'xemacs) ...) conditionals still
necessary?  IOW, does XEmacs' easy-menu-define allow the help text
(tool tip) argument?

Bye, Reiner.

[1] 2004-10-18  Reiner Steib  <Reiner.Steib@gmx.de>
	* gnus-sum.el (gnus-summary-make-menu-bar): Add help texts.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 5.10 summary menubar broken on XEmacs
  2005-04-02 13:20   ` Reiner Steib
@ 2005-04-02 15:45     ` Adrian Aichner
  0 siblings, 0 replies; 4+ messages in thread
From: Adrian Aichner @ 2005-04-02 15:45 UTC (permalink / raw)
  Cc: XEmacs Beta

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Sat, Apr 02 2005, Adrian Aichner wrote:
>
>> Steve Youngs <steve@youngs.au.com> writes:
> [...]
>>> The menubar in the summary buffer is broken on XEmacs[1] with Gnus
>>> 5.10.7.  Trying to access any menu in the summary buffer with a mouse
>>> gives: 
>>>
>>>   "Unrecognized menu descriptor", t
> [...]
>> The error message is printed by
>>
>>        ;; (t (signal 'error (list "unrecognized menu descriptor" menuitem))))
>>        (t (message "unrecognized menu descriptor %s" (prin1-to-string menuitem))))
> [...]
>> (t ["Respool article..." gnus-summary-respool-article t] 
>

Hi Reiner, thanks for looking at this!

> Does the problem also appear in Gnus 5.10.6?  If not, could you revert

I don't think so.

People are having problems since they sarted using the latest gnus
pre-release package (which is Steve's sync with 5.10.7).

> my 2004-10-18 change[1] in `gnus-sum.el' and see if the problem goes
> away?

Better yet, I found this promising ChangeLog entry:

2004-08-30  Katsumi Yamaoka  <yamaoka@jpl.org>
<24 lines deleted by Adrian Aichner>
	* gnus-sum.el (gnus-summary-make-menu-bar): Avoid the
	"Unrecognized menu descriptor" error in XEmacs.

And sure enough, applying this minimalistic patch to
xemacs-packages/gnus fixes the problem for me:

Index: gnus-sum.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/gnus-sum.el,v
retrieving revision 1.6
diff -u -u -r1.6 gnus-sum.el
--- gnus-sum.el	13 Mar 2005 00:23:28 -0000	1.6
+++ gnus-sum.el	2 Apr 2005 15:25:15 -0000
@@ -2250,7 +2250,7 @@
 	       ,@(if (featurep 'xemacs) '(t)
 		   '(:help "Generate and print a PostScript image"))])
 	     ("Copy, move,... (Backend)"
-	      ,@(if (featurep 'xemacs) '(t)
+	      ,@(if (featurep 'xemacs) nil
 		  '(:help "Copying, moving, expiring articles..."))
 	      ["Respool article..." gnus-summary-respool-article t]
 	      ["Move article..." gnus-summary-move-article

Steve, could you please review your gnus xemacs package sync to make
sure there aren't other things that were missed?  Do you know why this
change from 2004-08-30 did not make it over in your sync?

>
> This is this only change directly related to the summary buffer menu.
> Probably (I don't have CVS access here) it contained this hunk:
>
> ,----[ 5.10.6 vs. current v5-10 ]
> |               ["Print with Muttprint..." gnus-summary-muttprint t]
> | -             ["Print" gnus-summary-print-article t])
> | -            ("Backend"
> | +             ["Print" gnus-summary-print-article
> | +              ,@(if (featurep 'xemacs) '(t)
> | +                  '(:help "Generate and print a PostScript image"))])
> | +            ("Copy, move,... (Backend)"
> | +             ,@(if (featurep 'xemacs) '(t)
> | +                 '(:help "Copying, moving, expiring articles..."))
> |               ["Respool article..." gnus-summary-respool-article t]
> `----
>
> As this change is also in the trunk, I'm quite surprised that we
> didn't get complaints from XEmacs users up to now.
>
> BTW, are these (if (featurep 'xemacs) ...) conditionals still
> necessary?  IOW, does XEmacs' easy-menu-define allow the help text
> (tool tip) argument?

I have not found any evidence that it does.

I think these are still necessary.

Adrian

>
> Bye, Reiner.
>
> [1] 2004-10-18  Reiner Steib  <Reiner.Steib@gmx.de>
> 	* gnus-sum.el (gnus-summary-make-menu-bar): Add help texts.

-- 
Adrian Aichner
 mailto:adrian@xemacs.org
 http://www.xemacs.org/



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-04-02 15:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-02  0:57 5.10 summary menubar broken on XEmacs Steve Youngs
2005-04-02  9:52 ` Adrian Aichner
2005-04-02 13:20   ` Reiner Steib
2005-04-02 15:45     ` Adrian Aichner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).