From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/60079 Path: news.gmane.org!not-for-mail From: Adrian Aichner Newsgroups: gmane.emacs.xemacs.beta,gmane.emacs.gnus.general Subject: Re: 5.10 summary menubar broken on XEmacs Date: Sat, 02 Apr 2005 17:45:42 +0200 Organization: The XEmacs Project Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 X-Trace: sea.gmane.org 1112456587 11564 80.91.229.2 (2 Apr 2005 15:43:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 2 Apr 2005 15:43:07 +0000 (UTC) Cc: XEmacs Beta Original-X-From: xemacs-beta-bounces@xemacs.org Sat Apr 02 17:43:03 2005 Return-path: Original-Received: from gwyn.tux.org ([199.184.165.135] ident=ident-user) by ciao.gmane.org with esmtp (Exim 4.43) id 1DHklx-000101-KO for gexb-xemacs-beta@gmane.org; Sat, 02 Apr 2005 17:42:53 +0200 Original-Received: from gwyn.tux.org (ident-user@localhost.localdomain [127.0.0.1]) by gwyn.tux.org (8.12.11/8.12.11) with ESMTP id j32Fi7rE025445; Sat, 2 Apr 2005 10:44:09 -0500 Original-Received: from gwyn.tux.org (ident-user@localhost.localdomain [127.0.0.1]) by gwyn.tux.org (8.12.11/8.12.11) with ESMTP id j32Fi57Q025433 for ; Sat, 2 Apr 2005 10:44:05 -0500 Original-Received: (from xemacweb@localhost) by gwyn.tux.org (8.12.11/8.12.11/Submit) id j32Fi5sl025432 for xemacs-beta-mailman@xemacs.org; Sat, 2 Apr 2005 10:44:05 -0500 Original-Received: from gwyn.tux.org (ident-user@localhost.localdomain [127.0.0.1]) by gwyn.tux.org (8.12.11/8.12.11) with ESMTP id j32FhvBv025398 for ; Sat, 2 Apr 2005 10:43:57 -0500 Original-Received: (from mailnull@localhost) by gwyn.tux.org (8.12.11/8.12.11/Submit) id j32FhvfK025397 for xemacweb@tux.org; Sat, 2 Apr 2005 10:43:57 -0500 Original-Received: from syl.extundo.com (syl.extundo.com [212.32.189.101]) by gwyn.tux.org (8.12.11/8.12.11) with ESMTP id j32Fhush025391; Sat, 2 Apr 2005 10:43:56 -0500 Original-Received: from mailout09.sul.t-online.com (mailout09.sul.t-online.com [194.25.134.84]) by syl.extundo.com (8.12.10/8.12.10) with ESMTP id j32Fo9h2005022; Sat, 2 Apr 2005 17:50:09 +0200 Original-Received: from fwd22.aul.t-online.de by mailout09.sul.t-online.com with smtp id 1DHkmw-000862-00; Sat, 02 Apr 2005 17:43:54 +0200 Original-Received: from D5DC120J.t-online.de (rCh4oTZFweg85nX9M+aMGvalxcMhtkl-M9dAowFVUSTYSNhuD4FR6-@[84.153.99.33]) by fwd22.sul.t-online.de with esmtp id 1DHkmv-04PKc40; Sat, 2 Apr 2005 17:43:53 +0200 Original-To: Ding List X-Attribution: APA X-Face: 4[iHdXiTu\V3u[~\I)*}#kYF[-tYl3VZga/HSOP|K,{L Rtu@f0y/=O&Cu}\:~d|P$JON?pn?j,&CnPb1z#/TL9bkAJwyol&a:SvYj-VYbM=Dtxhk9 =w|R6U3_;SH&B (Reiner Steib's message of "Sat, 02 Apr 2005 15:20:03 +0200") User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.5-b20 (cilantro, windows-nt) X-ID: rCh4oTZFweg85nX9M+aMGvalxcMhtkl-M9dAowFVUSTYSNhuD4FR6-@t-dialin.net X-TOI-MSGID: 0796c62f-9548-45d6-93d3-aeebea537aaa X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gwyn.tux.org [0.0.0.0]); Sat, 02 Apr 2005 10:44:09 -0500 (EST) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gwyn.tux.org [0.0.0.0]); Sat, 02 Apr 2005 10:44:05 -0500 (EST) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gwyn.tux.org [0.0.0.0]); Sat, 02 Apr 2005 10:43:57 -0500 (EST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-1.6 (gwyn.tux.org [199.184.165.136]); Sat, 02 Apr 2005 10:43:57 -0500 (EST) X-Virus-Scanned: ClamAV version 0.83, clamav-milter version 0.83 on gwyn.tux.org X-Virus-Scanned: ClamAV version 0.83, clamav-milter version 0.83 on gwyn.tux.org X-Virus-Scanned: ClamAV version 0.83, clamav-milter version 0.83 on gwyn.tux.org X-Virus-Scanned: ClamAV version 0.83, clamav-milter version 0.83 on gwyn.tux.org X-Virus-Status: Clean X-XEmacs-List: beta X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on gwyn.tux.org X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63 X-BeenThere: xemacs-beta@xemacs.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: XEmacs Beta Testers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Original-Sender: xemacs-beta-bounces@xemacs.org Errors-To: xemacs-beta-bounces@xemacs.org Xref: news.gmane.org gmane.emacs.xemacs.beta:18852 gmane.emacs.gnus.general:60079 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:60079 Reiner Steib writes: > On Sat, Apr 02 2005, Adrian Aichner wrote: > >> Steve Youngs writes: > [...] >>> The menubar in the summary buffer is broken on XEmacs[1] with Gnus >>> 5.10.7. Trying to access any menu in the summary buffer with a mouse >>> gives: >>> >>> "Unrecognized menu descriptor", t > [...] >> The error message is printed by >> >> ;; (t (signal 'error (list "unrecognized menu descriptor" menuitem)))) >> (t (message "unrecognized menu descriptor %s" (prin1-to-string menuitem)))) > [...] >> (t ["Respool article..." gnus-summary-respool-article t] > Hi Reiner, thanks for looking at this! > Does the problem also appear in Gnus 5.10.6? If not, could you revert I don't think so. People are having problems since they sarted using the latest gnus pre-release package (which is Steve's sync with 5.10.7). > my 2004-10-18 change[1] in `gnus-sum.el' and see if the problem goes > away? Better yet, I found this promising ChangeLog entry: 2004-08-30 Katsumi Yamaoka <24 lines deleted by Adrian Aichner> * gnus-sum.el (gnus-summary-make-menu-bar): Avoid the "Unrecognized menu descriptor" error in XEmacs. And sure enough, applying this minimalistic patch to xemacs-packages/gnus fixes the problem for me: Index: gnus-sum.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/gnus-sum.el,v retrieving revision 1.6 diff -u -u -r1.6 gnus-sum.el --- gnus-sum.el 13 Mar 2005 00:23:28 -0000 1.6 +++ gnus-sum.el 2 Apr 2005 15:25:15 -0000 @@ -2250,7 +2250,7 @@ ,@(if (featurep 'xemacs) '(t) '(:help "Generate and print a PostScript image"))]) ("Copy, move,... (Backend)" - ,@(if (featurep 'xemacs) '(t) + ,@(if (featurep 'xemacs) nil '(:help "Copying, moving, expiring articles...")) ["Respool article..." gnus-summary-respool-article t] ["Move article..." gnus-summary-move-article Steve, could you please review your gnus xemacs package sync to make sure there aren't other things that were missed? Do you know why this change from 2004-08-30 did not make it over in your sync? > > This is this only change directly related to the summary buffer menu. > Probably (I don't have CVS access here) it contained this hunk: > > ,----[ 5.10.6 vs. current v5-10 ] > | ["Print with Muttprint..." gnus-summary-muttprint t] > | - ["Print" gnus-summary-print-article t]) > | - ("Backend" > | + ["Print" gnus-summary-print-article > | + ,@(if (featurep 'xemacs) '(t) > | + '(:help "Generate and print a PostScript image"))]) > | + ("Copy, move,... (Backend)" > | + ,@(if (featurep 'xemacs) '(t) > | + '(:help "Copying, moving, expiring articles...")) > | ["Respool article..." gnus-summary-respool-article t] > `---- > > As this change is also in the trunk, I'm quite surprised that we > didn't get complaints from XEmacs users up to now. > > BTW, are these (if (featurep 'xemacs) ...) conditionals still > necessary? IOW, does XEmacs' easy-menu-define allow the help text > (tool tip) argument? I have not found any evidence that it does. I think these are still necessary. Adrian > > Bye, Reiner. > > [1] 2004-10-18 Reiner Steib > * gnus-sum.el (gnus-summary-make-menu-bar): Add help texts. -- Adrian Aichner mailto:adrian@xemacs.org http://www.xemacs.org/