Gnus development mailing list
 help / color / mirror / Atom feed
From: Paul Franklin <paul@cs.washington.edu>
Subject: Re: pop mailboxes
Date: 04 Feb 1997 20:50:03 -0800	[thread overview]
Message-ID: <r9qybd3vouc.fsf@fester.cs.washington.edu> (raw)
In-Reply-To: Daniel Simms's message of 04 Feb 1997 15:55:52 -0800

>>>>> Daniel Simms writes:

 >>>>>> "LMI" == Lars Magne Ingebrigtsen <larsi@ifi.uio.no> writes:

 >   >> ;
 >   >> file-directory-p("po:pop.alink.net:110:apop:n:dsimms%alink.net:*")

 >   LMI> This isn't a valid value from `nnmail-spool-file'.  It should
 >   LMI> be just "po:username".


 > Yes, yes*, it does the same thing with just po:luser too.  

I took a look at the code, convinced that Gnus wouldn't have such an
error in it, since I use pop all of the time, and I periodically get
ange-ftp qutoloaded when I'm foolish enough to try to tab-complete in
the root directory.

Sure enough, there's a bug, at least in 5.4.10.  Sorry Lars.

There's another bug which this doesn't fix but I may fix sometime
tomorrow--it handles nnmail-spool-file set to
	'pop
but not
	'(pop "/some/other/file")

Tue Feb  4 20:26:20 1997  Paul Franklin  <paul@cs.washington.edu>

	* nnmail.el (nnmail-get-spool-files): Don't call file-directory-p
	on pop spool specifiers.

--- nnmail.el	1997/02/05 04:18:56	1.1
+++ nnmail.el	1997/02/05 04:23:31
@@ -1254,19 +1254,19 @@
 		'nconc
 		(mapcar 
 		 (lambda (file)
-		   (if (file-directory-p file)
+		   (if (and (not (string-match "^po:" file))
+			    (file-directory-p file))
 		       (nnheader-directory-regular-files file)
 		     (list file)))
 		 nnmail-spool-file))
 	       procmails))
-	     ((and (stringp nnmail-spool-file)
-		   (not (file-directory-p nnmail-spool-file)))
-	      (cons nnmail-spool-file procmails))
-	     ((and (stringp nnmail-spool-file)
-		   (file-directory-p nnmail-spool-file))
-	      (nconc
-	       (nnheader-directory-regular-files nnmail-spool-file)
-	       procmails))
+	     ((stringp nnmail-spool-file)
+	      (if (and (not (string-match "^po:" nnmail-spool-file))
+		       (file-directory-p nnmail-spool-file))
+		  (nconc 
+		   (nnheader-directory-regular-files nnmail-spool-file)
+		   procmails)
+		(cons nnmail-spool-file procmails)))
 	     ((eq nnmail-spool-file 'pop)
 	      (cons (format "po:%s" (user-login-name)) procmails))
 	     (t


      parent reply	other threads:[~1997-02-05  4:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1997-02-03 23:32 Daniel Simms
1997-02-04 19:41 ` Lars Magne Ingebrigtsen
1997-02-04 23:00   ` Daniel Simms
1997-02-04 23:13     ` Lars Magne Ingebrigtsen
1997-02-04 23:55       ` Daniel Simms
1997-02-05  1:41         ` Lars Magne Ingebrigtsen
1997-02-05  5:03           ` Paul Franklin
1997-02-05  9:01           ` Daniel Simms
1997-02-05  3:08         ` Rich Pieri
1997-02-05  8:35           ` Daniel Simms
1997-02-05 16:13             ` Rich Pieri
1997-02-05  4:50         ` Paul Franklin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=r9qybd3vouc.fsf@fester.cs.washington.edu \
    --to=paul@cs.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).