From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/29547
Path: main.gmane.org!not-for-mail
From: Per Abrahamsen <abraham@dina.kvl.dk>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: major problem with recent cvs
Date: 16 Mar 2000 11:34:04 +0100
Organization: The Church of Emacs
Sender: owner-ding@hpc.uh.edu
Message-ID: <rjhfe7i4pv.fsf@zuse.dina.kvl.dk>
References: <kh7snxuajz3.fsf@acme47.nineco.com> <iluhfeawhgg.fsf@badis.pdc.kth.se> <vafem9dbzei.fsf@lucy.cs.uni-dortmund.de> <ilug0ttu6ac.fsf@badis.pdc.kth.se> <rjhfe8ms39.fsf@zuse.dina.kvl.dk> <bypusw9kfl.fsf@math.ethz.ch>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1035166198 3301 80.91.224.250 (21 Oct 2002 02:09:58 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 02:09:58 +0000 (UTC)
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from lisa.math.uh.edu (lisa.math.uh.edu [129.7.128.49])
	by mailhost.sclp.com (Postfix) with ESMTP id F1AB6D051E
	for <jason@mailhost.sclp.com>; Thu, 16 Mar 2000 05:36:11 -0500 (EST)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by lisa.math.uh.edu (8.9.1/8.9.1) with ESMTP id EAB23882;
	Thu, 16 Mar 2000 04:34:34 -0600 (CST)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 16 Mar 2000 04:34:11 -0600 (CST)
Original-Received: from mailhost.sclp.com (postfix@sclp3.sclp.com [204.252.123.139])
	by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id EAA18953
	for <ding@hpc.uh.edu>; Thu, 16 Mar 2000 04:34:00 -0600 (CST)
Original-Received: from sheridan.dina.kvl.dk (sheridan.dina.kvl.dk [130.225.40.227])
	by mailhost.sclp.com (Postfix) with ESMTP id 34C5AD051E
	for <ding@gnus.org>; Thu, 16 Mar 2000 05:34:10 -0500 (EST)
Original-Received: from zuse.dina.kvl.dk (zuse.dina.kvl.dk [130.225.40.245])
	by sheridan.dina.kvl.dk (8.9.3/8.9.3/Debian/GNU) with ESMTP id LAA00678
	for <ding@gnus.org>; Thu, 16 Mar 2000 11:28:06 +0100
Original-Received: (from abraham@localhost)
	by zuse.dina.kvl.dk (8.9.3+Sun/8.9.1) id LAA12807;
	Thu, 16 Mar 2000 11:34:05 +0100 (MET)
X-Authentication-Warning: zuse.dina.kvl.dk: abraham set sender to abraham@dina.kvl.dk using -f
Original-To: ding@gnus.org
X-Face: +kRV2]2q}lixHkE{U)mY#+6]{AH=yN~S9@IFiOa@X6?GM<U{B+4e{k79.Ya{~':DblFPCg$
 @60,BfLv2@SKZ19cMWK0/C'v;tM:|6B'R}U1rp6CL&kN({9<zF/V{:JCg27yC)9oZjeqcQawzKfiNL
 t9}`vjmK["dRQC/qGFQq"%u|Q`:6{"Rz}b(dnl_"3$Jtqimi>|8MBp/
In-Reply-To: Jan Vroonhof's message of "15 Mar 2000 19:07:10 +0100"
Original-Lines: 20
User-Agent: Gnus/5.0804 (Gnus v5.8.4) Emacs/20.4
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:29547
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:29547

Jan Vroonhof <vroonhof@math.ethz.ch> writes:

> Per Abrahamsen <abraham@dina.kvl.dk> writes:
> 
> > It looks correct to me.  I committed the patch, the problem is close
> > enough to losing mail to be urgent.
> 
> Uhmm.. Why didn't you apply my version (which solves the real problem)
> instead?

I checked the ChangeLog for likely candidates to the change that broke
Gnus, used CVS to find the exact change, added the code so the
semantics were restored (the change in semantics didn't seem
intentional, and the old semantics made perfectly sense), checked that
it worked, saw that Simon Josefsson had came up with the exact same
solution, and that you had some completely different untested changes
in files unrelated to the place in the code that was changed.

Given this, commiting my (and Simons) changes seemed like the safest
course af action.