Re: Quote emphasis

[Per Abrahamsen <abraham@dina.kvl.dk>]

Sudish Joseph <sudish@mindspring.com> writes:

> In article <m2wwv3wcx8.fsf@altair.xemacs.org>,
> Steven L Baur <steve@miranova.com> writes:
> > I played around a bit with it, and while it does add more color, it
> > has the potential for confusing things more in messages which contain
> > code.
> 
> I liked it, but I agree that it can cause havoc for certain messages.

Which?  It works fine with the code snips I have seen.  The strings
gets highlighted, as if the code was font-locked.  

> > It would work best IMO if it were controlled by YAV, and possibly
> > restricted to only original text.  (It clashes at times with the
> > citation highlight :-( ).

I have emphasize before highlight-citation in
`gnus-article-display-hook' (that is the way they are listed in the
customization buffer), so I don't see this.

But I agree it should be on a separate hook function.  What should it
be called?  `highlight-quotes' would be "correct", but may be easy to
confuse with `highlight-citation'.

> I think the general solution to article buffer massagers that get in
> the way for special articles is to provide unmassagers, functions that
> reverse the effects of the massagers.  This would be useful for
> smiley.el as well.  
> 
> If all massagers provided two hook-safe functions, feature-foo-article
> and un-feature-foo-article, we wouldn't need variables.  They could be
> added to the appropriate hook and given bindings in the W keymap.

Too difficult, not all display features can be undone.

Here is an alternative:

Replace the call to `gnus-article-display-hook' with 

	(make-local-variable 'gnus-local-article-display-hook)
        (setq gnus-local-article-display-hook
              (copy-list gnus-article-display-hook))
        (run-hooks 'gnus-local-article-display-hook)

Bind each wash function along these lines:

  (defun gnus-wash-toggle-add-buttons ()
    "Toggle buttons in the current article."
    (interactive)
    (gnus-wash-toggle 'gnus-article-add-buttons))

  (defun gnus-wash-toggle (fun)
     "Toggle argument FUN in and redisplay the article."
     (if (memq fun gnus-local-article-display-hook)
         (remove-hook 'gnus-local-article-display-hook fun)
       (add-hook 'gnus-local-article-display-hook fun)
     ;; The next line is even more pseudo code than the rest...
     (copy-buffer " *Original Article*" "*Article*")
     (run-hooks 'gnus-local-article-display-hook)))

Some benefits would be:

The menu entries for the wash toggle functions would be checkboxes, and
they look *so* cool under XEmacs.

You could have the commands 

  (defun gnus-wash-apply ()
    "Use the current state to the wash toggles for future articles.
  The effect expires when you exit emacs."
    (interactive)
    (setq gnus-article-display-hook
          (copy-list gnus-local-article-display-hook)))

  (defun gnus-wash-set-defeault ()
    "Use the current state to the wash toggles for future articles.
  The effect expires when you exit emacs."
    (interactive)
    (gnus-wash-apply)
    (put 'gnus-article-display-hook 
         'saved-value (list gnus-article-display-hook))
    (custom-save))

with menu entries to make it really easy to customize the washing.