spam-check-BBDB bug?/bbdb whitelist split function

[Bill White <billw@wolfram.com>]

I was futzing around defining my own "if he's in bbdb then he's not
spam" split function when I discovered spam-check-BBDB in spam.el:

----------------------------------------------------------------------
(defun spam-check-BBDB ()
    "Mail from people in the BBDB is never considered spam"
    (let ((who (message-fetch-field "from")))
      (when who
	(setq who (regexp-quote (cadr
				 (gnus-extract-address-components who))))
	(if (bbdb-search-simple nil who)
	    nil spam-split-group))))
----------------------------------------------------------------------

It seems in my tests that bbdb-search-simple does not search for a
regexp but for a simple string representation of an address, so I
suspect the regexp-quote bit should be removed.

I've also adjusted this to return a positive match for bbdb persons;
folks who maintain bbdb as a whitelist might find it useful (adjust
for local conditions, YMMV, etc.):

----------------------------------------------------------------------
(defun billw-BBDB-whitelist ()
  "BBDB is a whitelist."
  (let ((who (message-fetch-field "from")))
    (when who
      (setq who (cadr (gnus-extract-address-components who)))
      (if (bbdb-search-simple nil who)
	  (format-time-string "mail.misc.%Y.%m")
	nil))))

(setq nnmail-split-fancy
      '(|
	("to" ".*billw@wri\\.com" "spamtrap")
        ("List-Id" ".*gnucash-announce\\.lists\\.gnucash\\.org.*" "gnucash-announce")
	("List-Id" ".*gnucash-user\\.lists\\.gnucash\\.org.*" "gnucash-user")
	("List-Id" ".*gnucash-devel\\.lists\\.gnucash\\.org.*" "gnucash-devel")
	("List-Id" ".*gnucash-patches\\.lists\\.gnucash\\.org.*" "gnucash-patches")
        ("List-ID" ".*developer list for mt\\.el.*" "mt-el")

;;      [...]

;; my bbdb is a whitelist: save these
	(: billw-BBDB-whitelist)
;; check for scum       
	(: spam-stat-split-fancy)
;; non-whitelist non-spam: save these
	(: (lambda nil (format-time-string "mail.misc.%Y.%m")))
))
----------------------------------------------------------------------

Cheers -

bw
-- 
Bill White . billw@wolfram.com . http://members.wri.com/billw
"No ma'am, we're musicians."