Gnus development mailing list
 help / color / mirror / Atom feed
From: David Moore <dmoore@UCSD.EDU>
Cc: ding@ifi.uio.no
Subject: Re: Problem with nnvirtual in 0.72?
Date: 10 Dec 1996 14:47:34 -0800	[thread overview]
Message-ID: <rvn2vmkoe1.fsf@sdnp5.ucsd.edu> (raw)
In-Reply-To: "St. Suika Fenderson Roberts"'s message of Tue, 10 Dec 1996 12:46:41 -0600

"St. Suika Fenderson Roberts" <wrobert2@mailhost.tcs.tulane.edu> writes:

> I don't think this problem is in nnvirtual, for the simple reason that
> nnvirtual worked in 0.70 and didn't in 0.72, and no changes were made to
> _it_ in that span.

	Yup.  Fix in red gnus 0.75.

I always wanted to say that. Also, patch for 0.74 below for those who
don't want to wait, or don't want to down grade to 0.70.

*** ChangeLog.orig	Sun Dec  8 21:02:17 1996
--- ChangeLog	Mon Dec  9 21:02:21 1996
***************
*** 1,3 ****
--- 1,11 ----
+ Mon Dec  9 21:00:09 1996  David Moore  <dmoore@ucsd.edu>
+ 
+ 	* gnus-sum.el (gnus-summary-catchup): Out dated catchup code
+ 	removed.
+ 
+ 	* nnvirtual.el (nnvirtual-update-read-and-marked): Work around a
+ 	cache of active count in gnus-update-read-articles.
+ 
  Fri Dec  6 12:47:24 1996  Wes Hardaker  <Wesley.Hardaker@sphys.unil.ch>
  
  	* gnus-picon.el (gnus-picons-insert-face-if-exists): Don't reverse
*** gnus-sum.el.orig	Sun Dec  8 21:01:25 1996
--- gnus-sum.el	Mon Dec  9 21:01:56 1996
***************
*** 7642,7652 ****
  	    (unless to-here
  	      (setq gnus-newsgroup-unreads nil))
  	    (gnus-set-mode-line 'summary))
- 	  (let ((method (gnus-find-method-for-group gnus-newsgroup-name)))
- 	    (when (and (not to-here) (eq 'nnvirtual (car method)))
- 	      (nnvirtual-catchup-group
- 	       (gnus-group-real-name gnus-newsgroup-name)
- 	       (nth 1 method) all)))
  	  t))
      (gnus-summary-position-point)))
  
--- 7642,7647 ----
*** nnvirtual.el.orig	Mon Dec  9 20:57:10 1996
--- nnvirtual.el	Mon Dec  9 20:58:31 1996
***************
*** 401,408 ****
      ;; hits C-g, you won't leave the component groups in a half-way state.
      (gnus-atomic-progn
        ;; move (un)read
!       (while (setq entry (pop unreads))
! 	(gnus-update-read-articles (car entry) (cdr entry)))
  
        ;; clear all existing marks on the component groups
        (setq groups nnvirtual-component-groups)
--- 401,409 ----
      ;; hits C-g, you won't leave the component groups in a half-way state.
      (gnus-atomic-progn
        ;; move (un)read
!       (let ((gnus-newsgroup-active nil)) ;workaround guns-update-read-articles
! 	(while (setq entry (pop unreads))
! 	  (gnus-update-read-articles (car entry) (cdr entry))))
  
        ;; clear all existing marks on the component groups
        (setq groups nnvirtual-component-groups)


  reply	other threads:[~1996-12-10 22:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-12-10 18:46 St. Suika Fenderson Roberts
1996-12-10 22:47 ` David Moore [this message]
  -- strict thread matches above, loose matches on Subject: below --
1996-12-03  2:24 St. Suika Fenderson Roberts
1996-12-03  3:55 ` Jason L Tibbitts III
1996-12-03  5:24   ` Han Pilmeyer
1996-12-02 22:48 Jason L Tibbitts III
1996-12-03  6:00 ` David Moore
1996-12-03  7:15   ` Matt Pharr
1996-12-03 19:14   ` Han Pilmeyer
1996-12-05  1:22   ` Matt Pharr
1996-12-10  2:37     ` Steve Dunham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=rvn2vmkoe1.fsf@sdnp5.ucsd.edu \
    --to=dmoore@ucsd.edu \
    --cc=ding@ifi.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).