nnvirtual bug back in 0.79???

nnvirtual bug back in 0.79???

[Han Pilmeyer]

Today I upgraded to 0.79 and since that time I'm having problems with
my nnvirtual groups (and 1 nndraft group that I still have hanging
around from ages ago because I can't delete it).

Each time I get new mail into my mail groups (using "2g") I noticed
that my nnvirtual groups (news at level 3) revert back to their old
unread count. I then catch them up (with "c"), but as soon as I get
new mail they go back to unread mail again and again.

Is my computer haunted?

Cheers.
-- 
Han Pilmeyer, han@uto.dec.com, Phone: +31 30 2832671, FAX: +31 30 2832686
Digital Equipment B.V., Europalaan 44, 3526 KS Utrecht, The Netherlands
|         Answers are the easy part, questions raise the doubt   -JB          |
All opinions are those of the author, not of Digital Equipment!

Re: nnvirtual bug back in 0.79???

[David Moore]

Han Pilmeyer <han@uto.dec.com> writes:

> Each time I get new mail into my mail groups (using "2g") I noticed
> that my nnvirtual groups (news at level 3) revert back to their old
> unread count. I then catch them up (with "c"), but as soon as I get
> new mail they go back to unread mail again and again.
> 
> Is my computer haunted?

	No, here's a patch to nnvirtual. Basically a line in gnus-start
was changed from (gnus-get-unread-articles-in-group info active) to
(gnus-get-unread-articles-in-group info active t) which caused the
problems.

	If you apply the patches, be sure to re-bytecompile the files.
And you need to entirely quit your emacs, don't try to reload them.
Generally various random nnoo madness results otherwise.


*** ChangeLog.orig	Wed Jan  8 11:34:02 1997
--- ChangeLog	Wed Jan  8 15:20:49 1997
***************
*** 1,3 ****
--- 1,10 ----
+ Wed Jan  8 11:34:07 1997  David Moore  <dmoore@ucsd.edu>
+ 
+ 	* nnvirtual.el (nnvirtual-info-installed): New variable.
+ 	(nnvirtual-open-server): Use it.
+ 	(nnvirtual-request-update-info): ditto.
+ 	(nnvirtual-request-update-info): ditto.
+ 
  Mon Jan  6 11:23:05 1997  Lars Magne Ingebrigtsen  <larsi@ifi.uio.no>
  
  	* nnmail.el (nnmail-process-babyl-mail-format): Widen at the right
*** nnvirtual.el.orig	Wed Jan  8 15:06:29 1997
--- nnvirtual.el	Wed Jan  8 15:09:33 1997
***************
*** 77,82 ****
--- 77,85 ----
  (defvoo nnvirtual-mapping-marks nil
    "Compressed marks alist for the virtual group as computed from the marks of individual component groups.")
  
+ (defvoo nnvirtual-info-installed nil
+   "T if we have already installed the group info for this group, and shouldn't blast over it again.")
+ 
  (defvoo nnvirtual-status-string "")
  
  (eval-and-compile
***************
*** 214,220 ****
  	  nnvirtual-mapping-offsets nil
  	  nnvirtual-mapping-len 0
  	  nnvirtual-mapping-reads nil
! 	  nnvirtual-mapping-marks nil)
      (when nnvirtual-component-regexp
        ;; Go through the newsrc alist and find all component groups.
        (let ((newsrc (cdr gnus-newsrc-alist))
--- 217,224 ----
  	  nnvirtual-mapping-offsets nil
  	  nnvirtual-mapping-len 0
  	  nnvirtual-mapping-reads nil
! 	  nnvirtual-mapping-marks nil
! 	  nnvirtual-info-installed nil)
      (when nnvirtual-component-regexp
        ;; Go through the newsrc alist and find all component groups.
        (let ((newsrc (cdr gnus-newsrc-alist))
***************
*** 285,291 ****
  
  
  (deffoo nnvirtual-request-update-info (group info &optional server)
!   (when (nnvirtual-possibly-change-server server)
      ;; Install the precomputed lists atomically, so the virtual group
      ;; is not left in a half-way state in case of C-g.
      (gnus-atomic-progn
--- 289,296 ----
  
  
  (deffoo nnvirtual-request-update-info (group info &optional server)
!   (when (and (nnvirtual-possibly-change-server server)
! 	     (not nnvirtual-info-installed))
      ;; Install the precomputed lists atomically, so the virtual group
      ;; is not left in a half-way state in case of C-g.
      (gnus-atomic-progn
***************
*** 293,299 ****
        (if (nthcdr 3 info)
  	  (setcar (nthcdr 3 info) nnvirtual-mapping-marks)
  	(when nnvirtual-mapping-marks
! 	  (setcdr (nthcdr 2 info) (list nnvirtual-mapping-marks)))))
      t))
        
  
--- 298,305 ----
        (if (nthcdr 3 info)
  	  (setcar (nthcdr 3 info) nnvirtual-mapping-marks)
  	(when nnvirtual-mapping-marks
! 	  (setcdr (nthcdr 2 info) (list nnvirtual-mapping-marks))))
!       (setq nnvirtual-info-installed t))
      t))
        
  

-- 
David Moore <dmoore@ucsd.edu>       | Computer Systems Lab      __o
UCSD Dept. Computer Science - 0114  | Work: (619) 534-8604    _ \<,_
La Jolla, CA 92093-0114             | Fax:  (619) 534-1445   (_)/ (_)
<URL:http://oj.egbt.org/dmoore/>    |