Re: nnmail-split-it

[David Moore <dmoore@UCSD.EDU>]

joda@pdc.kth.se (Johan Danielsson) writes:

> Nnmail-split-it is currently using re-search-backward, this fails with
> splits like this:
> 
> ("sender" "\\(.*\\)@foo.org" "foo-\\1")
> 
> What will searching forward break?

	If there are multiple headers which match, it'll get the earlier
ones rather than the latter ones.  The problem in this case however is
the two competing .*'s in the regexp.  A better fix is probably just
make the innermost regexp-search-backwards into a forwards, not both of
them.

	And a much better fix would be to preparse the message headers,
to allow much faster comparisons, as it's really slow currently with
lots of split rules.  Something like making a list of header names to
the start/end points of that header's value in the buffer might be
good.  Then you just do string-match of the field designator to each
thing in the list, and the first one which matches, you apply the value
regexp to the buffer limited to the start/end region.

-- 
David Moore <dmoore@ucsd.edu>       | Computer Systems Lab      __o
UCSD Dept. Computer Science - 0114  | Work: (619) 534-8604    _ \<,_
La Jolla, CA 92093-0114             | Fax:  (619) 534-1445   (_)/ (_)
<URL:http://oj.egbt.org/dmoore/>    | In a cloud bones of steel.