* qgnus0.17: no highlighting in message mode
@ 1997-12-03 14:19 Mark Moll
1997-12-04 14:25 ` Fredrik Glöckner
1997-12-06 16:15 ` Lars Magne Ingebrigtsen
0 siblings, 2 replies; 8+ messages in thread
From: Mark Moll @ 1997-12-03 14:19 UTC (permalink / raw)
The patch for qgnus 0.17 contains the following chunk of code:
***************
*** 777,782 ****
--- 775,782 ----
(0 'message-cited-text-face))))
"Additional expressions to highlight in Message mode.")
+ (put 'message-mode 'font-lock-defaults '(message-font-lock-keywords t))
+
(defvar message-face-alist
'((bold . bold-region)
(underline . underline-region)
***************
*** 1262,1269 ****
(setq major-mode 'message-mode)
(setq mode-name "Message")
(setq buffer-offer-save t)
- (make-local-variable 'font-lock-defaults)
- (setq font-lock-defaults '(message-font-lock-keywords t))
(make-local-variable 'facemenu-add-face-function)
(make-local-variable 'facemenu-remove-face-function)
(setq facemenu-add-face-function
This breaks the highlighting in message-mode for me. If I add the two
deleted lines again, everything works as usual. Has anybody else noticed
this? I'm using GNU Emacs 20.2.
--
Mark Moll
e-mail: mmoll@cs.cmu.edu | Carnegie Mellon University
phone: (412) 268 1120 | Dept. of Computer Science
URL: http://www.cs.cmu.edu/~mmoll | 5000 Forbes Avenue
PGP: finger e-mail address | Pittsburgh, PA 15213
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: qgnus0.17: no highlighting in message mode
1997-12-03 14:19 qgnus0.17: no highlighting in message mode Mark Moll
@ 1997-12-04 14:25 ` Fredrik Glöckner
1997-12-06 16:15 ` Lars Magne Ingebrigtsen
1 sibling, 0 replies; 8+ messages in thread
From: Fredrik Glöckner @ 1997-12-04 14:25 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
Mark Moll <mmoll@cs.cmu.edu> writes:
| This breaks the highlighting in message-mode for me. If I add the two
| deleted lines again, everything works as usual. Has anybody else noticed
| this? I'm using GNU Emacs 20.2.
The same thing happens to me. Being naïve, I was kinda waiting for a
new version of qgnus to fix it.
Fredrik
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: qgnus0.17: no highlighting in message mode
1997-12-03 14:19 qgnus0.17: no highlighting in message mode Mark Moll
1997-12-04 14:25 ` Fredrik Glöckner
@ 1997-12-06 16:15 ` Lars Magne Ingebrigtsen
1997-12-07 18:41 ` Fredrik Glöckner
1997-12-08 11:34 ` Dave Love
1 sibling, 2 replies; 8+ messages in thread
From: Lars Magne Ingebrigtsen @ 1997-12-06 16:15 UTC (permalink / raw)
Mark Moll <mmoll@cs.cmu.edu> writes:
> + (put 'message-mode 'font-lock-defaults '(message-font-lock-keywords t))
> +
[...]
> This breaks the highlighting in message-mode for me. If I add the two
> deleted lines again, everything works as usual. Has anybody else noticed
> this? I'm using GNU Emacs 20.2.
Hm. It was a patch I received from someone; it was supposed to be the
new right way of doing things. I dunno. Things seem to work for me
still...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: qgnus0.17: no highlighting in message mode
1997-12-06 16:15 ` Lars Magne Ingebrigtsen
@ 1997-12-07 18:41 ` Fredrik Glöckner
1997-12-18 20:39 ` Hrvoje Niksic
1997-12-08 11:34 ` Dave Love
1 sibling, 1 reply; 8+ messages in thread
From: Fredrik Glöckner @ 1997-12-07 18:41 UTC (permalink / raw)
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
| Hm. It was a patch I received from someone; it was supposed to be the
| new right way of doing things. I dunno.
I dunno too. However, putting this thing in `.gnus' fixes the problem
for me. It may not be an elegant solution, though.
(add-hook 'message-mode-hook
'(lambda ()
(make-local-variable 'font-lock-defaults)
(setq font-lock-defaults '(message-font-lock-keywords t))))
Fredrik
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: qgnus0.17: no highlighting in message mode
1997-12-06 16:15 ` Lars Magne Ingebrigtsen
1997-12-07 18:41 ` Fredrik Glöckner
@ 1997-12-08 11:34 ` Dave Love
1997-12-14 10:37 ` Lars Magne Ingebrigtsen
1 sibling, 1 reply; 8+ messages in thread
From: Dave Love @ 1997-12-08 11:34 UTC (permalink / raw)
>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
Lars> Mark Moll <mmoll@cs.cmu.edu> writes:
>> + (put 'message-mode 'font-lock-defaults '(message-font-lock-keywords t))
>> +
Lars> [...]
>> This breaks the highlighting in message-mode for me. If I add the
>> two deleted lines again, everything works as usual. Has anybody
>> else noticed this? I'm using GNU Emacs 20.2.
Lars> Hm. It was a patch I received from someone; it was supposed to
Lars> be the new right way of doing things. I dunno. Things seem to
Lars> work for me still...
It seems to be an (older?) XEmacs way of doing things. It definitely
isn't Si's way for Emacs 19.34 or Emacs 20.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: qgnus0.17: no highlighting in message mode
1997-12-08 11:34 ` Dave Love
@ 1997-12-14 10:37 ` Lars Magne Ingebrigtsen
1997-12-14 16:57 ` Dave Love
0 siblings, 1 reply; 8+ messages in thread
From: Lars Magne Ingebrigtsen @ 1997-12-14 10:37 UTC (permalink / raw)
Dave Love <d.love@dl.ac.uk> writes:
> It seems to be an (older?) XEmacs way of doing things. It definitely
> isn't Si's way for Emacs 19.34 or Emacs 20.
Hm. Ok. I know noooothing about font-lock, so could someone look at
the problem and mail me a patch?
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: qgnus0.17: no highlighting in message mode
1997-12-14 10:37 ` Lars Magne Ingebrigtsen
@ 1997-12-14 16:57 ` Dave Love
0 siblings, 0 replies; 8+ messages in thread
From: Dave Love @ 1997-12-14 16:57 UTC (permalink / raw)
>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
Lars> Hm. Ok. I know noooothing about font-lock, so could someone
Lars> look at the problem and mail me a patch?
It was gnus-bugged at the time.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: qgnus0.17: no highlighting in message mode
1997-12-07 18:41 ` Fredrik Glöckner
@ 1997-12-18 20:39 ` Hrvoje Niksic
0 siblings, 0 replies; 8+ messages in thread
From: Hrvoje Niksic @ 1997-12-18 20:39 UTC (permalink / raw)
Fredrik "Glöckner" <fredrik.glockner@bio.uio.no> writes:
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
> | Hm. It was a patch I received from someone; it was supposed to be the
> | new right way of doing things. I dunno.
>
> I dunno too. However, putting this thing in `.gnus' fixes the problem
> for me. It may not be an elegant solution, though.
>
> (add-hook 'message-mode-hook
> '(lambda ()
> (make-local-variable 'font-lock-defaults)
> (setq font-lock-defaults '(message-font-lock-keywords t))))
This patch should do it, I think:
--- message.el.orig Thu Dec 18 21:36:29 1997
+++ message.el Thu Dec 18 21:39:24 1997
@@ -774,6 +774,8 @@
(0 'message-cited-text-face))))
"Additional expressions to highlight in Message mode.")
+;; XEmacs does it like this. For Emacs, we have to set the
+;; `font-lock-defaults' buffer-local variable.
(put 'message-mode 'font-lock-defaults '(message-font-lock-keywords t))
(defvar message-face-alist
@@ -1307,7 +1309,10 @@
(mail-abbrevs-setup)
(funcall (intern "mail-aliases-setup"))))
(message-set-auto-save-file-name)
- (run-hooks 'text-mode-hook 'message-mode-hook))
+ (run-hooks 'text-mode-hook 'message-mode-hook)
+ (unless (string-match "XEmacs" emacs-version)
+ (set (make-local-variable 'font-lock-defaults)
+ '(message-font-lock-keywords t))))
\f
--
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Idle RAM is the Devil's playground.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~1997-12-18 20:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1997-12-03 14:19 qgnus0.17: no highlighting in message mode Mark Moll
1997-12-04 14:25 ` Fredrik Glöckner
1997-12-06 16:15 ` Lars Magne Ingebrigtsen
1997-12-07 18:41 ` Fredrik Glöckner
1997-12-18 20:39 ` Hrvoje Niksic
1997-12-08 11:34 ` Dave Love
1997-12-14 10:37 ` Lars Magne Ingebrigtsen
1997-12-14 16:57 ` Dave Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).