From: Julien Danjou <julien@danjou.info>
To: Andrew Cohen <cohen@andy.bu.edu>
Cc: ding@gnus.org
Subject: Re: A T does not work in nnimap
Date: Wed, 13 Oct 2010 15:55:39 +0200 [thread overview]
Message-ID: <sa3pqvetcx0.fsf@cigue.easter-eggs.fr> (raw)
In-Reply-To: <87mxqjvuy8.fsf@andy.bu.edu> (Andrew Cohen's message of "Tue, 12 Oct 2010 19:43:11 -0400")
[-- Attachment #1: Type: text/plain, Size: 1967 bytes --]
On Wed, Oct 13 2010, Andrew Cohen wrote:
> OK here is a first pass at modifying gnus-summary-refer-thread to work
> with imap. It seemed like a good idea to factor out a thread-searching
> function for nnimap, so I did.
Looks good. The only problem I see is that when I press A T, I then get
*only* the thread I'm reading. It kicks all the other messages out of
the *Summary* buffer. :-(
> @@ -8828,28 +8829,35 @@ If LIMIT (the numerical prefix), fetch that many old headers instead
> of what's specified by the `gnus-refer-thread-limit' variable."
> (interactive "P")
> (let ((id (mail-header-id (gnus-summary-article-header)))
> + (refs (split-string (or
> + (mail-header-references (gnus-summary-article-header)) "")))
> (limit (if limit (prefix-numeric-value limit)
> gnus-refer-thread-limit)))
> - (unless (eq gnus-fetch-old-headers 'invisible)
> - (gnus-message 5 "Fetching headers for %s..." gnus-newsgroup-name)
> - ;; Retrieve the headers and read them in.
> - (if (eq (if (numberp limit)
> - (gnus-retrieve-headers
> - (list (min
> - (+ (mail-header-number
> - (gnus-summary-article-header))
> - limit)
> - gnus-newsgroup-end))
> - gnus-newsgroup-name (* limit 2))
> - ;; gnus-refer-thread-limit is t, i.e. fetch _all_
> - ;; headers.
> - (gnus-retrieve-headers (list gnus-newsgroup-end)
> - gnus-newsgroup-name limit))
> - 'nov)
> - (gnus-build-all-threads)
> - (error "Can't fetch thread from back ends that don't support NOV"))
> - (gnus-message 5 "Fetching headers for %s...done" gnus-newsgroup-name))
> - (gnus-summary-limit-include-thread id)))
> + (if (string= (car (gnus-group-method gnus-newsgroup-name))
> "nnimap")
I'm not sure such a backend check is welcome here. Isn't there a more
generic way to handle that?
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-10-13 13:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 11:00 Julien Danjou
2010-10-07 18:13 ` Lars Magne Ingebrigtsen
2010-10-12 13:28 ` Julien Danjou
2010-10-12 13:50 ` Lars Magne Ingebrigtsen
2010-10-12 14:18 ` Julien Danjou
2010-10-12 14:43 ` Andrew Cohen
2010-10-12 23:43 ` Andrew Cohen
2010-10-13 13:55 ` Julien Danjou [this message]
2010-10-13 15:30 ` Andrew Cohen
2010-10-13 15:42 ` Julien Danjou
2010-10-13 17:21 ` Lars Magne Ingebrigtsen
2010-10-13 17:56 ` Andrew Cohen
2010-10-13 18:29 ` Lars Magne Ingebrigtsen
2010-10-13 20:59 ` Andrew Cohen
2010-10-13 21:11 ` Lars Magne Ingebrigtsen
2010-10-13 21:30 ` Andrew Cohen
2010-10-13 21:37 ` Lars Magne Ingebrigtsen
2010-10-13 21:59 ` Andrew Cohen
2010-10-13 22:06 ` Lars Magne Ingebrigtsen
2010-10-14 0:38 ` Andrew Cohen
2010-10-14 12:57 ` Andrew Cohen
2010-10-14 18:00 ` Lars Magne Ingebrigtsen
2010-10-14 18:45 ` Andrew Cohen
2010-10-14 19:02 ` Lars Magne Ingebrigtsen
2010-10-15 11:02 ` Julien Danjou
2010-10-15 11:24 ` Andrew Cohen
2010-10-15 11:29 ` Julien Danjou
2010-10-15 11:53 ` Steinar Bang
2010-10-15 12:01 ` Julien Danjou
2010-10-15 12:00 ` Andrew Cohen
2010-10-15 12:06 ` Julien Danjou
2010-10-15 12:17 ` Andrew Cohen
2010-10-15 12:26 ` Andrew Cohen
2010-10-15 18:26 ` Julien Danjou
2010-10-16 12:58 ` Andrew Cohen
2010-10-16 18:16 ` Lars Magne Ingebrigtsen
2010-10-15 14:03 ` Lars Magne Ingebrigtsen
2010-10-15 12:11 ` Andrew Cohen
2010-10-15 12:28 ` Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sa3pqvetcx0.fsf@cigue.easter-eggs.fr \
--to=julien@danjou.info \
--cc=cohen@andy.bu.edu \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).