From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/72127 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Introduce gnus-completing-read Date: Tue, 28 Sep 2010 18:00:07 +0200 Message-ID: References: <1285688153-19680-1-git-send-email-julien@danjou.info> <87vd5phngn.fsf@uwo.ca> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1285689627 9795 80.91.229.12 (28 Sep 2010 16:00:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 28 Sep 2010 16:00:27 +0000 (UTC) Cc: ding@gnus.org To: Dan Christensen Original-X-From: ding-owner+M20500@lists.math.uh.edu Tue Sep 28 18:00:22 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P0cbN-00069u-7q for ding-account@gmane.org; Tue, 28 Sep 2010 18:00:21 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1P0cbJ-0003zk-Az; Tue, 28 Sep 2010 11:00:17 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1P0cbH-0003zT-H8 for ding@lists.math.uh.edu; Tue, 28 Sep 2010 11:00:15 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1P0cbG-0000LW-7h for ding@lists.math.uh.edu; Tue, 28 Sep 2010 11:00:15 -0500 Original-Received: from coquelicot-s.easter-eggs.com ([213.215.37.94]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1P0cbF-0000Ty-00 for ; Tue, 28 Sep 2010 18:00:13 +0200 Original-Received: from cigue.easter-eggs.fr (cigue.easter-eggs.fr [10.0.0.33]) by rose.easter-eggs.fr (Postfix) with ESMTPS id 868391419E; Tue, 28 Sep 2010 18:00:04 +0200 (CEST) Original-Received: from jdanjou by cigue.easter-eggs.fr with local (Exim 4.72) (envelope-from ) id 1P0cbA-0005HS-Bd; Tue, 28 Sep 2010 18:00:08 +0200 Mail-Followup-To: Dan Christensen , ding@gnus.org In-Reply-To: <87vd5phngn.fsf@uwo.ca> (Dan Christensen's message of "Tue, 28 Sep 2010 11:55:36 -0400") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-Spam-Score: -0.4 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:72127 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Sep 28 2010, Dan Christensen wrote: >> diff --git a/lisp/gnus-agent.el b/lisp/gnus-agent.el >> index 4788deb..1cb3637 100644 >> --- a/lisp/gnus-agent.el >> +++ b/lisp/gnus-agent.el >> @@ -459,10 +459,7 @@ manipulated as follows: >> (let ((def (or (gnus-group-group-name) gnus-newsgroup-name))) >> (when def >> (setq def (gnus-group-decoded-name def))) >> - (gnus-group-completing-read (if def >> - (concat "Group Name (" def "): ") >> - "Group Name: ") >> - nil nil t nil nil def))) >> + (gnus-group-completing-read nil t nil nil def))) > > Should the new code have "Group Name" as the first argument? Good catch, thanks! That gave me the idea to make the prompt optional, since usually it's just "Group". Patch following this mail. =2D-=20 Julien Danjou // =E1=90=B0 http://julien.danjou.info --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkyiEQgACgkQpGK1HsL+5c2ugwCfVD620B3VjXIvCH6cN5wyZHTt r44An2cSI2k026B208zX6mZvBBxZgDsY =jPZo -----END PGP SIGNATURE----- --=-=-=--