Re: Development splash smoothing

[Julien Danjou <julien@danjou.info>]

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

On Sat, Mar 26 2011, Adam Sjøgren wrote:

> Let me know what you think, and please don't hesitate to tear my elisp
> apart. I have no idea what I am doing.

I like it.

> +(defun gnus-splash-svg-color-symbols (list)
> +  "Do color-symbol search-and-replace in svg file"
> +  (let ((type (plist-get (cdr list) :type))
> +        (file (plist-get (cdr list) :file))
> +        (color-symbols (plist-get (cdr list) :color-symbols)))
> +    (if (and (string= type "svg"))

(and) what ? seems the and is useless here. :)

> +        (let ((data (with-temp-buffer (insert-file file) (buffer-string))))
> +          (mapc (lambda (rule)
> +                  (setq data (replace-regexp-in-string
> +                              (concat "fill:" (car rule))
> +                              (concat "fill:" (cdr rule)) data))) color-symbols)
> +          (cons (car list) (list :type type :data data)))
> +       list)))
> +
>  (eval-when (load)
>    (let ((command (format "%s" this-command)))
>      (when (string-match "gnus" command)
> -- 
> 1.7.4.1

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]