From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/59491 Path: main.gmane.org!not-for-mail From: Wes Hardaker Newsgroups: gmane.emacs.gnus.general Subject: Re: bad fixes to a higher level problem Date: Thu, 30 Dec 2004 22:11:02 -0800 Organization: Sparta Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1104474127 6170 80.91.229.6 (31 Dec 2004 06:22:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 31 Dec 2004 06:22:07 +0000 (UTC) Cc: ding@gnus.org Original-X-From: ding-owner+M8031@lists.math.uh.edu Fri Dec 31 07:22:01 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CkGAj-0005zy-00 for ; Fri, 31 Dec 2004 07:22:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1CkG0g-0004Jn-00; Fri, 31 Dec 2004 00:11:38 -0600 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1CkG0P-0004Jh-00 for ding@lists.math.uh.edu; Fri, 31 Dec 2004 00:11:21 -0600 Original-Received: from quimby.gnus.org ([80.91.224.244]) by util2.math.uh.edu with esmtp (Exim 4.30) id 1CkG0J-0004vV-GO for ding@lists.math.uh.edu; Fri, 31 Dec 2004 00:11:15 -0600 Original-Received: from dcn236-43.dcn.davis.ca.us ([168.150.236.43] helo=wes.hardakers.net) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1CkG0E-0003kj-00 for ; Fri, 31 Dec 2004 07:11:10 +0100 Original-Received: by wes.hardakers.net (Postfix, from userid 274) id 9F3BD11D823; Thu, 30 Dec 2004 22:11:02 -0800 (PST) Original-To: drkm Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXotKX87e8eDA4GAQbQgmlzNycHAwizYkruzul2AAACaUlEQVR4nFXUTW/jIBAGYFI56jWutuq1S9b2dddW6dWtQFxbq4jzwq73Glmg+fv7DiT9QJGS+GEGhiER67TWEQ5CtOeh21ZcIIbmOPq5QvMZYlyV6u+/gsJLTSrGIL/CxEPxQuPAcP0JYlQsq3x5B3UJmUaEyB6yZ+CQ+pwXCzKsbXtbIhg4KtZypPz+AVGtlxH69c87qAqRY6Rc5QUmZMGeAj+TfVjjUwE1lflKys5JGXpM+V0hltqCJ0qL7Plkft4wRM6lxi5p3Wyy7O7fB8TgtdZivxy5rvAB6wSYhbA9vn+GOCaOEGJRPO2mHgk+q1Chyf0Up3AG0NjhOXI19ogEFziq6M+ZtN3kUZ13NW4qUCprC3CW668C06M5jihON1Vsjq8F1CPJB8LINNeQfscwxUEvAwM5Xghvsq2pBr3hnKhbDIrMS3cBRDx70uS9JW2dy667gM0AbZFFmyvn3GOBGB8wG9kppaSNz357LaCmUdtSny5LU9qeCrglvJmyH20TwkjnXQE0usscIWayCWZJ7OpZ4QbUVGRnhuTub3cMYRk99oSplDIfibzfn0FyXyk7z8XThuvC0P/dGCwee7O8aZJBmh0vPixy0NrYhDaR02aR3W0BbyT6h23OB5Hzybj+DOm5w6XCOZG13p5Oh/bursJVh9S+bBiFnPCDuntpcTH080AO+7GlW1i3bRphBM04dZ2dI6yMLjmGFqnIok/cB1YU8sJAACTeuHOd5+lumQHfDM6KyLqEm4aWkkcc1m4PqBewZxBZOg44lT+aJiexDteewb oiVhxAjSHxQwhiYJEdCR6tMN1/uckirDRNbsgAAAAASUVORK5CYII= In-Reply-To: (drkm's message of "Thu, 30 Dec 2004 22:43:12 +0100") User-Agent: Gnus/5.110003 (No Gnus v0.3) XEmacs/21.4 (Security Through Obscurity, linux) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: main.gmane.org gmane.emacs.gnus.general:59491 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:59491 >>>>> On Thu, 30 Dec 2004 22:43:12 +0100, drkm said: >> (while (and (not (eobp)) >> - (< level (gnus-summary-thread-level))) >> + (setq thlevel (gnus-summary-thread-level)) >> + (< level thlevel)) drkm> Why introduce `thlevel' if you don't use it ? Are there other drkm> reference to this variable, not shown in the patch ? Welcome to confusing elisp 101. Elisp is naturally obfuscated, fortunately, so I don't have to work hard to make it that way. The (setq thlevel) exists within the and statement, which means the results of the setq is evaluated before the < operation is called. It was the < operation that was causing problems with a nil argument. I had 2 choices: use a temporary variable to store the results (thlevel) or call (gnus-summary-thread-level) twice, once in the and to check that it was !nil and once in the <. I suppose, actually, it would have been better to do something like: (< level (or (gnus-summary-thread-level) 0)) That would have dropped the need for the temp var. -- "In the bathtub of history the truth is harder to hold than the soap, and much more difficult to find." -- Terry Pratchett