From: Wes Hardaker <wes@hardakers.net>
Subject: bad fixes to a higher level problem
Date: Thu, 30 Dec 2004 12:39:58 -0800 [thread overview]
Message-ID: <sdd5wrikpt.fsf@wes.hardakers.net> (raw)
So, I've had odd problems that aren't reproducible when entering a
group. Random nil values being passed around where they shouldn't be.
I have a sneaking suspicion it's related to my use of the
gnus-summary-display-while-building variable (which I admittedly
wrote). I'm not sure other people are using it, and the only reason I
think it might be related is because it was about the same time that I
think the problem started happening (a loooong time ago).
Upon entering a summary buffer (nnimap backend), it would occasionally
crash. Killing the incomplete summary buffer and re-entering
immediately again and it won't crash. That's what's really wierd.
I finally debugged the crashes enough to create a few patches to
gnus-sum.el which have merely moved the crashes to different places
every time i still see them. Thus, I suspect something higher up is
going wrong somewhere and stuff is getting handed downward in the
stack that shouldn't. Thoughts?
[line numbers may be off because there are other font-related patches
of mine in the same file]
@@ -10725,6 +10725,7 @@
;; Go forward until either the buffer ends or the subthread
;; ends.
(when (and (not (eobp))
+ article
(or (zerop (gnus-summary-next-thread 1 t))
(goto-char (point-max))))
(prog1
@@ -10740,12 +10741,14 @@
"Go to the same level (or less) next thread.
If PREVIOUS is non-nil, go to previous thread instead.
Return the article number moved to, or nil if moving was impossible."
- (let ((level (gnus-summary-thread-level))
+ (let ((level (or (gnus-summary-thread-level) 0))
(way (if previous -1 1))
- (beg (point)))
+ (beg (point))
+ thlevel)
(forward-line way)
(while (and (not (eobp))
- (< level (gnus-summary-thread-level)))
+ (setq thlevel (gnus-summary-thread-level))
+ (< level thlevel))
(forward-line way))
(if (eobp)
(progn
--
"In the bathtub of history the truth is harder to hold than the soap,
and much more difficult to find." -- Terry Pratchett
next reply other threads:[~2004-12-30 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-30 20:39 Wes Hardaker [this message]
2004-12-30 21:43 ` drkm
2004-12-31 6:11 ` Wes Hardaker
2004-12-31 6:33 ` drkm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sdd5wrikpt.fsf@wes.hardakers.net \
--to=wes@hardakers.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).