From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/59488 Path: main.gmane.org!not-for-mail From: Wes Hardaker Newsgroups: gmane.emacs.gnus.general Subject: bad fixes to a higher level problem Date: Thu, 30 Dec 2004 12:39:58 -0800 Organization: Sparta Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1104439685 23446 80.91.229.6 (30 Dec 2004 20:48:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 30 Dec 2004 20:48:05 +0000 (UTC) Original-X-From: ding-owner+M8029@lists.math.uh.edu Thu Dec 30 21:47:59 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ck7DD-0000q9-00 for ; Thu, 30 Dec 2004 21:47:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1Ck75y-0003N5-00; Thu, 30 Dec 2004 14:40:30 -0600 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1Ck75u-0003N0-00 for ding@lists.math.uh.edu; Thu, 30 Dec 2004 14:40:26 -0600 Original-Received: from quimby.gnus.org ([80.91.224.244]) by util2.math.uh.edu with esmtp (Exim 4.30) id 1Ck75o-00015r-DV for ding@lists.math.uh.edu; Thu, 30 Dec 2004 14:40:20 -0600 Original-Received: from adsl-64-165-72-150.dsl.scrm01.pacbell.net ([64.165.72.150] helo=wes.hardakers.net) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ck75i-0004uq-00 for ; Thu, 30 Dec 2004 21:40:14 +0100 Original-Received: by wes.hardakers.net (Postfix, from userid 274) id 7B2E411D823; Thu, 30 Dec 2004 12:39:59 -0800 (PST) Original-To: ding@gnus.org Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXotKX87e8eDA4GAQbQgmlzNycHAwizYkruzul2AAACaUlEQVR4nFXUTW/jIBAGYFI56jWutuq1S9b2dddW6dWtQFxbq4jzwq73Glmg+fv7DiT9QJGS+GEGhiER67TWEQ5CtOeh21ZcIIbmOPq5QvMZYlyV6u+/gsJLTSrGIL/CxEPxQuPAcP0JYlQsq3x5B3UJmUaEyB6yZ+CQ+pwXCzKsbXtbIhg4KtZypPz+AVGtlxH69c87qAqRY6Rc5QUmZMGeAj+TfVjjUwE1lflKys5JGXpM+V0hltqCJ0qL7Plkft4wRM6lxi5p3Wyy7O7fB8TgtdZivxy5rvAB6wSYhbA9vn+GOCaOEGJRPO2mHgk+q1Chyf0Up3AG0NjhOXI19ogEFziq6M+ZtN3kUZ13NW4qUCprC3CW668C06M5jihON1Vsjq8F1CPJB8LINNeQfscwxUEvAwM5Xghvsq2pBr3hnKhbDIrMS3cBRDx70uS9JW2dy667gM0AbZFFmyvn3GOBGB8wG9kppaSNz357LaCmUdtSny5LU9qeCrglvJmyH20TwkjnXQE0usscIWayCWZJ7OpZ4QbUVGRnhuTub3cMYRk99oSplDIfibzfn0FyXyk7z8XThuvC0P/dGCwee7O8aZJBmh0vPixy0NrYhDaR02aR3W0BbyT6h23OB5Hzybj+DOm5w6XCOZG13p5Oh/bursJVh9S+bBiFnPCDuntpcTH080AO+7GlW1i3bRphBM04dZ2dI6yMLjmGFqnIok/cB1YU8sJAACTeuHOd5+lumQHfDM6KyLqEm4aWkkcc1m4PqBewZxBZOg44lT+aJiexDteewb oiVhxAjSHxQwhiYJEdCR6tMN1/uckirDRNbsgAAAAASUVORK5CYII= User-Agent: Gnus/5.110003 (No Gnus v0.3) XEmacs/21.4 (Security Through Obscurity, linux) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: main.gmane.org gmane.emacs.gnus.general:59488 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:59488 So, I've had odd problems that aren't reproducible when entering a group. Random nil values being passed around where they shouldn't be. I have a sneaking suspicion it's related to my use of the gnus-summary-display-while-building variable (which I admittedly wrote). I'm not sure other people are using it, and the only reason I think it might be related is because it was about the same time that I think the problem started happening (a loooong time ago). Upon entering a summary buffer (nnimap backend), it would occasionally crash. Killing the incomplete summary buffer and re-entering immediately again and it won't crash. That's what's really wierd. I finally debugged the crashes enough to create a few patches to gnus-sum.el which have merely moved the crashes to different places every time i still see them. Thus, I suspect something higher up is going wrong somewhere and stuff is getting handed downward in the stack that shouldn't. Thoughts? [line numbers may be off because there are other font-related patches of mine in the same file] @@ -10725,6 +10725,7 @@ ;; Go forward until either the buffer ends or the subthread ;; ends. (when (and (not (eobp)) + article (or (zerop (gnus-summary-next-thread 1 t)) (goto-char (point-max)))) (prog1 @@ -10740,12 +10741,14 @@ "Go to the same level (or less) next thread. If PREVIOUS is non-nil, go to previous thread instead. Return the article number moved to, or nil if moving was impossible." - (let ((level (gnus-summary-thread-level)) + (let ((level (or (gnus-summary-thread-level) 0)) (way (if previous -1 1)) - (beg (point))) + (beg (point)) + thlevel) (forward-line way) (while (and (not (eobp)) - (< level (gnus-summary-thread-level))) + (setq thlevel (gnus-summary-thread-level)) + (< level thlevel)) (forward-line way)) (if (eobp) (progn -- "In the bathtub of history the truth is harder to hold than the soap, and much more difficult to find." -- Terry Pratchett