Re: new gnus-highlight

[Wes Hardaker <wes@hardakers.net>]

[-- Attachment #1: Type: text/plain, Size: 2529 bytes --]


Sorry for the delay.

>>>>> On Mon, 01 Mar 2004 20:44:35 +0100, Reiner Steib <4.uce.03.r.s@nurfuerspam.de> said:

Reiner> Does <news:sdn07waufl.fsf@wes.hardakers.net> contain the most recent
Reiner> version?

Don't know.  But I'll attach a current below....

Reiner> - `gnus-summary-highlight-expressions' and
Reiner> `gnus-article-highlight-expressions' are declared with defcustom,
Reiner> but cannot be customized (custom type declarations are
Reiner> missing).

I wasn't sure what it should be a sub-part of when I originally
created it.  Thoughts?

Reiner> - What is the reasoning behind this test in
Reiner> `gnus-treat-highlight-expressions'?

Reiner> (and (or window-system
Reiner> (featurep 'xemacs)
Reiner> (>= (string-to-number emacs-version) 21))
Reiner> t)

I think copied that from somewhere else originally.  I can certainly
replace it with "t" if the code will work in all environments.

Reiner> - Could you run `M-x checkdoc RET' on the file and fix the style
Reiner> errors?

Done.

Reiner> - Opening and closing braces on a single line (as in your doc-strings
Reiner> and sometimes in the code) should be avoided:

Reiner> (setq gnus-treat-highlight-headers 'head)
Reiner> (setq gnus-article-highlight-expressions
Reiner> '(
Reiner> ; highlights "keyword" in any header.
Reiner> (".*\(keyword\)" . "yellow")

...

Reiner> ... should better read ...

Reiner> (setq gnus-treat-highlight-headers 'head)
Reiner> (setq gnus-article-highlight-expressions
Reiner> '(;; highlights "keyword" in any header.
Reiner> (".*\(keyword\)" . "yellow")

I disagree in documentation strings.  It provides a much better visual
separation (IMHO of course) for people trying to get a quick feel for
stuff.

Reiner> - Why do you use '() instead of nil?

Err...  Don't know.  Changed.  I think the original code I wrote
choked due to the way lists were being used.  mapcar is now used, and
this handles a nil ok.

Reiner> - Shouldn't the initialization part (and *-treat-* variables) be moved
Reiner> to `gnus-art.el' (or`gnus-sum.el')?

Yes, which is what I originally did but it wasn't going to be applied
to CVS till No Gnus and thus I pulled it back into the isolated file
so people could still use it without applying a patch.

Reiner> - How about text for the manual (texi/gnus.texi) and the NEWS file
Reiner> (texi/gnus-news.texi)?

As I mentioned in a previous note, I haven't written docs yet.

-- 
"In the bathtub of history the truth is harder to hold than the soap,
 and much more difficult to find."  -- Terry Pratchett

[-- Attachment #2: gnus-highlight.el --]
[-- Type: application/emacs-lisp, Size: 8189 bytes --]