From: Greg Troxel <gdt@work.lexort.com>
To: Julien Danjou <julien@danjou.info>
Cc: ding@gnus.org
Subject: recent imap regression
Date: Mon, 06 Aug 2012 08:00:40 -0400 [thread overview]
Message-ID: <smua9y8dyc7.fsf@linuxpal.mit.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 2227 bytes --]
I just updated to latest git, and it looks like these two changes:
b12f45e int, nnimap: remove to-buffer in request-head
04ef222 gnus-int: add to-buffer parameter to gnus-request-head
which were intended to be a change and a revert, ended up doing:
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 1bf8444..9e1cc6e 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,14 @@
+2012-08-06 Julien Danjou <julien@danjou.info>
+
+ * nnimap.el (nnimap-request-article): Remove to-buffer argument.
+
+ * gnus-int.el (gnus-request-head): Remove to-buffer argument, only
+ supported by nnimap actually. Reverts previous change.
+
+ * gnus-int.el (gnus-request-head): Add an optional to-buffer parameter
+ to mimic `gnus-request-article' and enjoy backends the nn*-request-head
+ to-buffer argument that is already supported.
+
2012-08-05 Julien Danjou <julien@danjou.info>
* gnus-demon.el (gnus-demon-add-handler, gnus-demon-remove-handler):
diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index ebd268e..e195b42 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -597,7 +597,7 @@ textual parts.")
(nnheader-ms-strip-cr)))
(cons group article)))))))
-(deffoo nnimap-request-head (article &optional group server to-buffer)
+(deffoo nnimap-request-head (article &optional group server)
(when group
(setq group (nnimap-decode-gnus-group group)))
(when (nnimap-change-group group server)
@@ -610,7 +610,7 @@ textual parts.")
article (format "UID FETCH %%d %s"
(nnimap-header-parameters)))
(let ((buffer (current-buffer)))
- (with-current-buffer (or to-buffer nntp-server-buffer)
+ (with-current-buffer nntp-server-buffer
(erase-buffer)
(insert-buffer-substring buffer)
(nnheader-ms-strip-cr)
which results in the following when using delete.
nnimap-request-move-article: Wrong number of arguments: #[(article &optional group server) "\bƒ\bÅ\b!Æ\b \"…ArÇ qˆ
;ƒ\x1fÈ\b
#
…@É
ÊËÌ \"\"ˆpr\fqˆÍ ˆÎ\v!ˆÏ ˆ\b
*B)‡" [group server article buffer nntp-server-buffer nnimap-decode-gnus-group nnimap-change-group nnimap-buffer nnimap-find-article-by-message-id nnimap-get-whole-article ...] 5], 4
[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]
next reply other threads:[~2012-08-06 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 12:00 Greg Troxel [this message]
2012-08-06 12:26 ` Julien Danjou
2012-08-06 13:11 ` Greg Troxel
2012-08-06 13:17 ` Julien Danjou
2012-08-06 14:30 ` Greg Troxel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=smua9y8dyc7.fsf@linuxpal.mit.edu \
--to=gdt@work.lexort.com \
--cc=ding@gnus.org \
--cc=julien@danjou.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).