Problems with `require' in recent changes

Problems with `require' in recent changes

[Dave Goldberg]

With the renaming from password.el to password-cache.el, smime.el, sieve-manage.el and mml-sec.el have a sexp like this:

(or (require 'password-cache nil t)
    (require 'password))

This breaks XEmacs 21.4.20 with an error that require does not like
having three arguments.

Since I don't understand what the above call to require is supposed to
do, I cannot produce a proper patch.  For the time being, I've brute
forced a fix by commenting out the above sexp and replacing it with
(require 'password-cache) which is fine for my single user
installation and allows me to do my work today, assuming the issue
remains in 21.4.21 which I have at work.  If I find that it works
there I'll upgrade at home and be done with it, but I wanted to get
the word out early in case it doesn't as I don't have access to my
personal email while at work.

Thanks,

-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: Problems with `require' in recent changes

[Katsumi Yamaoka]

>>>>> Dave Goldberg <david.goldberg6@verizon.net> wrote:

> With the renaming from password.el to password-cache.el, smime.el, sieve-manage.el and mml-sec.el have a sexp like this:

> (or (require 'password-cache nil t)
>     (require 'password))

> This breaks XEmacs 21.4.20 with an error that require does not like
> having three arguments.

The third argument `noerror' is acceptable to only XEmacs 21.5.

> Since I don't understand what the above call to require is supposed to
> do, I cannot produce a proper patch.  For the time being, I've brute
> forced a fix by commenting out the above sexp and replacing it with
> (require 'password-cache) which is fine for my single user
> installation and allows me to do my work today, assuming the issue
> remains in 21.4.21 which I have at work.  If I find that it works
> there I'll upgrade at home and be done with it, but I wanted to get
> the word out early in case it doesn't as I don't have access to my
> personal email while at work.

> Thanks,

> --
> Dave Goldberg
> david.goldberg6@verizon.net

I don't know what (require 'password) is for, too.  And I believe
that no XEmacs user will have difficulty even if changing it into:

(require 'password-cache)

Regards,

Re: Problems with `require' in recent changes

[Glenn Morris]

Katsumi Yamaoka wrote:

> I don't know what (require 'password) is for, too.

Because I didn't know if password will get renamed in Gnus too, or if
Gnus needs to support systems where password-cache is still called
password.

Re: Problems with `require' in recent changes

[Katsumi Yamaoka]

[-- Attachment #1.1: Type: text/plain, Size: 708 bytes --]

>>>>> Glenn Morris wrote:

> Katsumi Yamaoka wrote:

>> I don't know what (require 'password) is for, too.

> Because I didn't know if password will get renamed in Gnus too, or if
> Gnus needs to support systems where password-cache is still called
> password.

Now only password-cache.el exists in the Gnus trunk.  However,
password.el is still in ecrypto that is an official XEmacs Lisp
package.  So, it will override password-cache.el if some program
requires the feature `password'.  I'm not sure what it brings,
but it seems that password-cache.el had better provide also the
feature `password'.  Though it might cause a trouble in programs
that use password functions, I guess it is easy to be solved.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Problems with `require' in recent changes

[Stefan Monnier]

>>> I don't know what (require 'password) is for, too.

>> Because I didn't know if password will get renamed in Gnus too, or if
>> Gnus needs to support systems where password-cache is still called
>> password.

> Now only password-cache.el exists in the Gnus trunk.  However,
> password.el is still in ecrypto that is an official XEmacs Lisp
> package.  So, it will override password-cache.el if some program
> requires the feature `password'.  I'm not sure what it brings,
> but it seems that password-cache.el had better provide also the
> feature `password'.  Though it might cause a trouble in programs
> that use password functions, I guess it is easy to be solved.

I really wish we had kept the name "password.el".  Such name changes are
just a waste of time and energy.


        Stefan

Re: Problems with `require' in recent changes

[Reiner Steib]

On Wed, Dec 12 2007, Stefan Monnier wrote:

>> Now only password-cache.el exists in the Gnus trunk.  However,
>> password.el is still in ecrypto that is an official XEmacs Lisp
>> package.  

I guess even when XEmacs renames password.el as well, there is problem
when a user installs a new Gnus package but has an elder ecrypto
package.

If XEmacs renames it, the following code in `tramp.el' doesn't DTRT:

;; As long as password.el is not part of (X)Emacs, it shouldn't
;; be mandatory
(if (featurep 'xemacs)
    (load "password" 'noerror)
  (or (require 'password-cache nil 'noerror)
      (require 'password nil 'noerror))) ; from No Gnus, also in tar ball

>> So, it will override password-cache.el if some program requires the
>> feature `password'.  I'm not sure what it brings, but it seems that
>> password-cache.el had better provide also the feature `password'.
>> Though it might cause a trouble in programs that use password
>> functions, I guess it is easy to be solved.
>
> I really wish we had kept the name "password.el".  Such name changes are
> just a waste of time and energy.

I agree.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Problems with `require' in recent changes

[Katsumi Yamaoka]

>>>>> Reiner Steib wrote:
> On Wed, Dec 12 2007, Stefan Monnier wrote:

>> I really wish we had kept the name "password.el".  Such name changes are
>> just a waste of time and energy.

> I agree.

I have no opinion about the module name.  But anyway the actual
problem is that No Gnus doesn't start with XEmacs 21.4.

Re: Problems with `require' in recent changes

[Reiner Steib]

On Fri, Dec 14 2007, Katsumi Yamaoka wrote:

> But anyway the actual problem is that No Gnus doesn't start with
> XEmacs 21.4.

I have tried to add compatible calls.  Please test and feel free to
improve it:

--8<---------------cut here---------------start------------->8---
(if (featurep 'xemacs)
    (or (load "password-cache" t)
        ;; Not all XEmacs versions support `noerror' arg of `require'.
	(require 'password))
  (or (require 'password-cache nil t)
      (require 'password)))
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Problems with `require' in recent changes

[Miles Bader]

Reiner Steib <reinersteib+gmane@imap.cc> writes:
> I have tried to add compatible calls.  Please test and feel free to
> improve it:
> (if (featurep 'xemacs)
>     (or (load "password-cache" t)
>         ;; Not all XEmacs versions support `noerror' arg of `require'.
> 	(require 'password))

Hmmm, how about replacing the

  (load "password-cache" t)

in the xemacs case with

   (or (featurep 'password-cache) (load "password-cache" t))

Sort of a "manual" require... :-/

-Miles

-- 
It wasn't the Exxon Valdez captain's driving that caused the Alaskan oil spill.
It was yours.  [Greenpeace advertisement, New York Times, 25 February 1990]

Re: Problems with `require' in recent changes

[Reiner Steib]

On Sun, Dec 16 2007, Miles Bader wrote:

> Hmmm, how about replacing the
>   (load "password-cache" t)
> in the xemacs case with
>    (or (featurep 'password-cache) (load "password-cache" t))
> Sort of a "manual" require... :-/

Yes, that would avoid multiple loads of password-cache.  So now we
have...

(if (featurep 'xemacs)
    ;; Not all XEmacs versions support `noerror' arg of `require'.
    (or (featurep 'password-cache)
	(load "password-cache" t)
	(require 'password))
  (or (require 'password-cache nil t)
      (require 'password)))

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Problems with `require' in recent changes

[Glenn Morris]

Reiner Steib wrote:

> (if (featurep 'xemacs)
>     ;; Not all XEmacs versions support `noerror' arg of `require'.
>     (or (featurep 'password-cache)
> 	(load "password-cache" t)
> 	(require 'password))
>   (or (require 'password-cache nil t)
>       (require 'password)))

(or
 (condition-case nil
     (require 'password-cache)
   (file-error nil))
 (require 'password))

?

Re: Problems with `require' in recent changes

[Glenn Morris]

Glenn Morris wrote:

> (or
>  (condition-case nil
>      (require 'password-cache)
>    (file-error nil))
>  (require 'password))

Or even shorter:

(if (locate-library "password-cache")
    (require 'password-cache)
  (require 'password))

Re: Problems with `require' in recent changes

[Katsumi Yamaoka]

>>>>> Glenn Morris wrote:
> Glenn Morris wrote:

>> (or
>>  (condition-case nil
>>      (require 'password-cache)
>>    (file-error nil))
>>  (require 'password))

> Or even shorter:

> (if (locate-library "password-cache")
>     (require 'password-cache)
>   (require 'password))

Those and the one in CVS are all okay for XEmacs.
If anything I like the last one. :)

Re: Problems with `require' in recent changes

[Reiner Steib]

On Tue, Dec 18 2007, Katsumi Yamaoka wrote:

>>>>>> Glenn Morris wrote:
>> Or even shorter:
>
>> (if (locate-library "password-cache")
>>     (require 'password-cache)
>>   (require 'password))
>
> Those and the one in CVS are all okay for XEmacs.
> If anything I like the last one. :)

Added it to mml-sec.el, sieve-manage.el, and smime.el.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Problems with `require' in recent changes

[Dave Goldberg]

> Yes, that would avoid multiple loads of password-cache.  So now we
> have...

> (if (featurep 'xemacs)
>     ;; Not all XEmacs versions support `noerror' arg of `require'.
>     (or (featurep 'password-cache)
> 	(load "password-cache" t)
> 	(require 'password))
>   (or (require 'password-cache nil t)
>       (require 'password)))

Thanks, that solves the problem for me.
-- 
Dave Goldberg
david.goldberg6@verizon.net