Re: searching by Message-ID after copy/move; speeding things up

[Michael Welsh Duggan <mwd@cert.org>]

Julien Danjou <julien@danjou.info> writes:

> On Thu, Jun 14 2012, Michael Welsh Duggan wrote:
>
>> Honestly, I'd just do a limited search.  You're already doing an
>> EXAMINE, so you just need to parse the results to get the EXISTS count.
>> Then a "UID SEARCH N:* HEADER Message-ID ..."  where N is the exist
>> count minus a small constant.
>>
>> If the limited search fails, just re-call the function with recent set
>> to nil.
>
> Another try.

Thanks for all your work!  This works with a couple of modifications.

> -(defun nnimap-find-article-by-message-id (group server message-id)
> -  "Search for message with MESSAGE-ID in GROUP from SERVER."
> +(defun nnimap-find-article-by-message-id (group server message-id &optional limit)
> +  "Search for message with MESSAGE-ID in GROUP from SERVER.
> +If LIMIT, first try to limit the search to the N last articles."
>    (with-current-buffer (nnimap-buffer)
>      (erase-buffer)
> -    (nnimap-change-group group server nil t)
> -    (let ((sequence
> -	   (nnimap-send-command "UID SEARCH HEADER Message-Id %S" message-id))
> -	  article result)
> -      (setq result (nnimap-wait-for-response sequence))
> -      (when (and result
> -		 (car (setq result (nnimap-parse-response))))
> -	;; Select the last instance of the message in the group.
> -	(and (setq article
> -		   (car (last (cdr (assoc "SEARCH" (cdr result))))))
> -	     (string-to-number article))))))
> +    (let* ((number-of-article
> +           (catch 'found
> +             (dolist (result (cdr (nnimap-change-group group server nil t)))
> +               (when (equal "EXISTS" (cadr result))
> +                 (throw 'found (car result))))))
> +           (sequence
> +            (nnimap-send-command "UID SEARCH%s HEADER Message-Id %S"
> +                                 (if limit

Needs to be (if (and limit number-of-article) ...)

> +                                     (format " %s:*" (- number-of-article limit))

Needs to be (- (string-to-number number-of-article) limit -1)

The need for string-to-number should be obvious.  The -1 is because IMAP
message numbers are one-based rather than zero-based.  

> +                                   "")
> +                                 message-id)))
> +      (when (nnimap-wait-for-response sequence)
> +        (let ((article (car (last (cdr (assoc "SEARCH" (nnimap-parse-response)))))))
> +          (if article
> +              (string-to-number article)
> +            (when limit

Probably should be (and limit number-of-article) just in case.

> +              (nnimap-find-article-by-message-id group server message-id))))))))
>  
>  (defun nnimap-delete-article (articles)
>    (with-current-buffer (nnimap-buffer)
> -- 
> 1.7.10


> While I was at it I modified a bunch of code in nnimap that I pushed
> into master. I hope I didn't break anything, but I think it's a bit
> cleaner that way. If it break something we can beat me and revert
> anyway.

Of course I failed to read this the first time and got confused.  "What
is nnimap-change-group?"  It always helps to read the whole thing.  :)

-- 
Michael Welsh Duggan
(mwd@cert.org)