From: Michael Welsh Duggan <mwd@cert.org>
To: Dave Abrahams <dave@boostpro.com>
Cc: Katsumi Yamaoka <yamaoka@jpl.org>,
ding@gnus.org, Julien Danjou <julien@danjou.info>
Subject: Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry
Date: Fri, 31 Aug 2012 10:34:46 -0400 [thread overview]
Message-ID: <tntbohrgmex.fsf@waterbuck.yellow.cert.org> (raw)
In-Reply-To: <m2harjd0ud.fsf@boostpro.com> (Dave Abrahams's message of "Thu, 30 Aug 2012 23:36:42 -0700")
Dave Abrahams <dave@boostpro.com> writes:
> on Thu Aug 30 2012, Katsumi Yamaoka <yamaoka-AT-jpl.org> wrote:
>
>> Julien Danjou wrote:
>>> On Wed, Aug 29 2012, Dave Abrahams wrote:
>>
>>>> - Log -----------------------------------------------------------------
>>>> commit afdb0e3005c7bc272b37602693eb24169fe9c0de
>>>> Author: Dave Abrahams <dave@boostpro.com>
>>>> Date: Tue Aug 28 12:34:49 2012 -0700
>>>>
>>>> Revert "Add recent argument to nnimap-find-article-by-message-id"
>>>>
>>>> This reverts commit ac8ce21091b89a7a05ad821854f4d3e7ff35a394.
>>>>
>>>> Conflicts:
>>>>
>>>> lisp/ChangeLog
>>>> lisp/nnimap.el
>>
>>> I think you should at least modify the changelog file to add the fact
>>> that you reverted something, and explain why you did it.
>
> Yes, this was a mistake. I'm terribly sorry; by the time I realized
> that I had pushed the change without a decent commit message, it was too
> late. The reason for this
> change is http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12268
I really hope that the reverted commit can be fixed and re-added at some
point. It is an important speed-up (minutes to seconds!) on systems
that have miserable search by message-id times (stupid MS Exchange).
Only reverting this change means that the
nnimap-find-article-by-message-id call in nnimap-request-move-article
has too many arguments.
--
Michael Welsh Duggan
(mwd@cert.org)
next prev parent reply other threads:[~2012-08-31 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1T6mSl-00057h-3s@quimby.gnus.org>
2012-08-29 21:23 ` Julien Danjou
2012-08-31 4:38 ` Katsumi Yamaoka
2012-08-31 6:36 ` Dave Abrahams
2012-08-31 14:34 ` Michael Welsh Duggan [this message]
2012-09-01 5:08 ` Dave Abrahams
2012-09-01 5:08 ` Dave Abrahams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tntbohrgmex.fsf@waterbuck.yellow.cert.org \
--to=mwd@cert.org \
--cc=dave@boostpro.com \
--cc=ding@gnus.org \
--cc=julien@danjou.info \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).