From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/82187 Path: news.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.gnus.general Subject: Re: [gnus git] branch master updated: m0-5-97-gafdb0e3 =6= Revert "Add recent argument to nnimap-find-article-by-message-id" ; Fix for macos keychain access ; gnus-try-warping-via-registry: [bugfix] don't act as though you've found the article when you haven't ; gnus-request-head: when gnus-override-method is set, allow the backend `request-head' function to determine the group name on its own. ; Change gnus-set-difference from O(N^2) to O(N) ; Filter out negative article numbers during expiry Date: Fri, 31 Aug 2012 10:34:46 -0400 Message-ID: References: <87ehmpqto6.fsf@dex.adm.naquadah.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1346423758 880 80.91.229.3 (31 Aug 2012 14:35:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Aug 2012 14:35:58 +0000 (UTC) Cc: Katsumi Yamaoka , ding@gnus.org, Julien Danjou To: Dave Abrahams Original-X-From: ding-owner+M30455@lists.math.uh.edu Fri Aug 31 16:35:56 2012 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T7SK7-00048V-JC for ding-account@gmane.org; Fri, 31 Aug 2012 16:35:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1T7SJU-0004Ig-1o; Fri, 31 Aug 2012 09:35:12 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1T7SJS-0004IT-Rv for ding@lists.math.uh.edu; Fri, 31 Aug 2012 09:35:10 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1T7SJN-0004QB-DI for ding@lists.math.uh.edu; Fri, 31 Aug 2012 09:35:10 -0500 Original-Received: from upton.red.cert.org ([192.88.209.60]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1T7SJL-0007DB-CD for ding@gnus.org; Fri, 31 Aug 2012 16:35:03 +0200 Original-Received: from bucknell.indigo.cert.org (bucknell.indigo.cert.org [10.60.10.121]) by upton.red.cert.org (8.14.4/8.14.4) with ESMTP id q7VEYmGP020265; Fri, 31 Aug 2012 10:34:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cert.org; s=jthatj15xw2j; t=1346423688; bh=Y10toZSG+micOd7XhYzkOybNBn3Uob05cRqAd0dljIY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type:Sender:Reply-To; b=BpXHvXwm2zyKHCgVzHfS1YbsLA5kZFZlNnXqMuLa3hX6gnTnx9P3jw5OKflmuIo4j +GwiibVimV4IEGbnTjNqvx33Gq12KL2uc3JiTpL7xed2y5yGXumkhyxUARfh8lNNi1 4ihO3uTn5gA2P7432G3gEMN7ut+Ih02fMrQvcclA= Original-Received: from waterbuck.yellow.cert.org (waterbuck.yellow.cert.org [10.20.128.84]) by bucknell.indigo.cert.org (8.14.4/8.14.4/2.81) with ESMTP id q7VEYmkn012906; Fri, 31 Aug 2012 10:34:48 -0400 Original-Received: (from mwd@localhost) by waterbuck.yellow.cert.org (8.14.4/8.14.4/Submit/1.6) id q7VEYkZH006696; Fri, 31 Aug 2012 10:34:46 -0400 X-Authentication-Warning: waterbuck.yellow.cert.org: mwd set sender to mwd@cert.org using -f In-Reply-To: (Dave Abrahams's message of "Thu, 30 Aug 2012 23:36:42 -0700") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) X-Spam-Score: -2.2 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:82187 Archived-At: Dave Abrahams writes: > on Thu Aug 30 2012, Katsumi Yamaoka wrote: > >> Julien Danjou wrote: >>> On Wed, Aug 29 2012, Dave Abrahams wrote: >> >>>> - Log ----------------------------------------------------------------- >>>> commit afdb0e3005c7bc272b37602693eb24169fe9c0de >>>> Author: Dave Abrahams >>>> Date: Tue Aug 28 12:34:49 2012 -0700 >>>> >>>> Revert "Add recent argument to nnimap-find-article-by-message-id" >>>> >>>> This reverts commit ac8ce21091b89a7a05ad821854f4d3e7ff35a394. >>>> >>>> Conflicts: >>>> >>>> lisp/ChangeLog >>>> lisp/nnimap.el >> >>> I think you should at least modify the changelog file to add the fact >>> that you reverted something, and explain why you did it. > > Yes, this was a mistake. I'm terribly sorry; by the time I realized > that I had pushed the change without a decent commit message, it was too > late. The reason for this > change is http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12268 I really hope that the reverted commit can be fixed and re-added at some point. It is an important speed-up (minutes to seconds!) on systems that have miserable search by message-id times (stupid MS Exchange). Only reverting this change means that the nnimap-find-article-by-message-id call in nnimap-request-move-article has too many arguments. -- Michael Welsh Duggan (mwd@cert.org)