Re: Dovecot and capabilities

[Michael Welsh Duggan <mwd@cert.org>]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Michael Welsh Duggan <md5i@md5i.com> writes:
>
>> Upon login on Dovecot, an updated set of capabilities may be
>> advertised.  I was able to account for that using the included patch.
>
> Thanks; applied.
>
>> A perhaps-better method might be to re-run CAPABILITY after logging
>> in.
>
> I don't see why -- if the LOGIN responds with a CAPABILITY list, then we
> should use it.  If not, then the capabilities probably haven't changed.
>
> Not issuing another CAPABILITY saves one round trip.  :-)

Only because I don't see any way to guarantee that a server will return
a capability list in response to LOGIN, whereas we know it will return
one in response to CAPABILITY.  My solution will work in Dovecot 2, but
I don't know if it will work anywhere else.  Now, we could certainly use
the capability response if it is there, and re-request capabilities if
it is not.

Either way, my problem is solved with this patch, so it is up to you.

-- 
Michael Welsh Duggan
(mwd@cert.org)