Gnus development mailing list
 help / color / mirror / Atom feed
From: Ken Raeburn <raeburn@cygnus.com>
Subject: Re: two minor patches, and expiry inefficiency
Date: 06 Mar 1998 01:19:53 -0500	[thread overview]
Message-ID: <tx167ls8ho6.fsf@cygnus.com> (raw)
In-Reply-To: Colin Rafferty's message of "05 Mar 1998 12:28:38 -0500"

Colin Rafferty <craffert@ml.com> writes:

> This should probably use `expand-file-name' instead of `concat', so that 
> it totally avoids all the the issues of trailing slashes.

Good point.

Fri Mar  6 01:10:22 1998  Ken Raeburn  <raeburn@cygnus.com>

	* nnml.el (nnml-article-to-file): Build pathname using
	expand-file-name.  (Thanks, Colin Rafferty, for catching
	this.)

Index: nnml.el
===================================================================
RCS file: /home/raeburn/.cvsfiles/lib/elisp/gnus/lisp/nnml.el,v
retrieving revision 1.1.1.39
diff -p -u -r1.1.1.39 nnml.el
--- nnml.el	1998/02/26 04:10:28	1.1.1.39
+++ nnml.el	1998/03/06 06:18:19
@@ -480,8 +480,8 @@ all.  This may very well take some time.
       ;; Just to make sure nothing went wrong when reading over NFS --
       ;; check once more.
       (when (file-exists-p
-	     (setq file (concat nnml-current-directory "/"
-				(number-to-string article))))
+	     (setq file (expand-file-name (number-to-string article)
+					  nnml-current-directory)))
 	(nnml-update-file-alist t)
 	file))))
 


      reply	other threads:[~1998-03-06  6:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-03-05  2:21 Ken Raeburn
1998-03-05 17:28 ` Colin Rafferty
1998-03-06  6:19   ` Ken Raeburn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tx167ls8ho6.fsf@cygnus.com \
    --to=raeburn@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).