From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/14439 Path: main.gmane.org!not-for-mail From: Ken Raeburn Newsgroups: gmane.emacs.gnus.general Subject: Re: two minor patches, and expiry inefficiency Date: 06 Mar 1998 01:19:53 -0500 Sender: owner-ding@hpc.uh.edu Message-ID: References: <9803050221.AA07124@phiphi.cygnus.com> NNTP-Posting-Host: coloc-standby.netfonds.no X-Trace: main.gmane.org 1035153630 16148 80.91.224.250 (20 Oct 2002 22:40:30 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 22:40:30 +0000 (UTC) Return-Path: Original-Received: from xemacs.org (xemacs.cs.uiuc.edu [128.174.252.16]) by altair.xemacs.org (8.8.8/8.8.8) with ESMTP id WAA28592 for ; Thu, 5 Mar 1998 22:26:15 -0800 Original-Received: from gizmo.hpc.uh.edu (gizmo.hpc.uh.edu [129.7.102.31]) by xemacs.org (8.8.5/8.8.5) with ESMTP id AAA09873 for ; Fri, 6 Mar 1998 00:21:36 -0600 (CST) Original-Received: from sina.hpc.uh.edu (sina.hpc.uh.edu [129.7.3.5]) by gizmo.hpc.uh.edu (8.7.6/8.7.3) with ESMTP id AAN14203; Fri, 6 Mar 1998 00:56:56 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Fri, 06 Mar 1998 00:20:33 -0600 (CST) Original-Received: from claymore.vcinet.com (claymore.vcinet.com [208.205.12.23]) by sina.hpc.uh.edu (8.7.3/8.7.3) with SMTP id AAA29493 for ; Fri, 6 Mar 1998 00:20:20 -0600 (CST) Original-Received: (qmail 28982 invoked by uid 504); 6 Mar 1998 06:20:11 -0000 Original-Received: (qmail 28978 invoked from network); 6 Mar 1998 06:20:11 -0000 Original-Received: from tweedledumb.cygnus.com (192.80.44.1) by claymore.vcinet.com with SMTP; 6 Mar 1998 06:20:11 -0000 Original-Received: from kr-pc.cygnus.com (kr-pc.cygnus.com [192.80.44.193]) by tweedledumb.cygnus.com (8.8.5/8.8.5) with ESMTP id BAA27764 for ; Fri, 6 Mar 1998 01:20:09 -0500 (EST) Original-Received: (from raeburn@localhost) by kr-pc.cygnus.com (8.8.8/8.6.9) id BAA05540; Fri, 6 Mar 1998 01:19:53 -0500 (EST) Original-To: (ding) GNUS Mailing List In-Reply-To: Colin Rafferty's message of "05 Mar 1998 12:28:38 -0500" Original-Lines: 31 X-Mailer: Quassia Gnus v0.34/Emacs 19.34 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:14439 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:14439 Colin Rafferty writes: > This should probably use `expand-file-name' instead of `concat', so that > it totally avoids all the the issues of trailing slashes. Good point. Fri Mar 6 01:10:22 1998 Ken Raeburn * nnml.el (nnml-article-to-file): Build pathname using expand-file-name. (Thanks, Colin Rafferty, for catching this.) Index: nnml.el =================================================================== RCS file: /home/raeburn/.cvsfiles/lib/elisp/gnus/lisp/nnml.el,v retrieving revision 1.1.1.39 diff -p -u -r1.1.1.39 nnml.el --- nnml.el 1998/02/26 04:10:28 1.1.1.39 +++ nnml.el 1998/03/06 06:18:19 @@ -480,8 +480,8 @@ all. This may very well take some time. ;; Just to make sure nothing went wrong when reading over NFS -- ;; check once more. (when (file-exists-p - (setq file (concat nnml-current-directory "/" - (number-to-string article)))) + (setq file (expand-file-name (number-to-string article) + nnml-current-directory))) (nnml-update-file-alist t) file))))