hard-newline changes in lisp/gnus/message.el

hard-newline changes in lisp/gnus/message.el

[Reiner Steib]

Hi,

when changing lisp/gnus/*.el, please keep in mind that this directory
is synced by Miles Bader with the (primary) Gnus repository on
gnus.org in order to simplify the process of including a new stable
Gnus version in Emacs.  The stable version of Gnus (the v5-10 branch
in Gnus CVS) should be identical[1] to the version in Emacs CVS and it
should work with Emacs 20.7 and up and XEmacs 21.1 and up.

It would be nice to discuss possibly controversial changes on
emacs-devel and ding@gnus.org (Gnus development list) before
committing.

As for `hard-newline': Obviously `hard-newline' is not defined in
Emacs < 22.  I'm not sure what's the best way to deal with this.  I'd
suggest to define `message-hard-newline' in `message.el' as follows
and use it instead of `hard-newline'.

(defvar message-hard-newline
  (if (featurep 'xemacs)
      "\n" ;; Or better code for XEmacs
    (if (boundp 'hard-newline)
	hard-newline
      (propertize "\n" 'hard t 'rear-nonsticky '(hard)))))

Or:

(defvar message-hard-newline
  (cond ((boundp 'hard-newline) hard-newline)
	((fboundp 'propertize)
	 (propertize "\n" 'hard t 'rear-nonsticky '(hard)))
	(t "\n")))

BTW, maybe `hard-newline' should have a doc string?

Bye, Reiner.

[1] Exception: Version number.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: hard-newline changes in lisp/gnus/message.el

[Romain Francoise]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> As for `hard-newline': Obviously `hard-newline' is not defined in
> Emacs < 22.  I'm not sure what's the best way to deal with this.

Revert this gross `hard-newline' hack, accept that longlines.el won't
work with all modes in Emacs 22, and spend our time on real problems?

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: hard-newline changes in lisp/gnus/message.el

[Sam Steingold]

> * Romain Francoise <ebznva@berobxrpu.pbz> [2005-11-19 12:20:43 
>+0100]:  Reiner Steib <reinersteib+gmane@imap.cc> writes:  > As 
>for `hard-newline': Obviously `hard-newline' is not defined in > 
>Emacs < 22.  I'm not sure what's the best way to deal with this. 
>Revert this gross `hard-newline' hack, accept that longlines.el 
>won't work with all modes in Emacs 22, and spend our time on real 
>problems?   <paragraph> I am not sure what is causing this 
>breakage, but since today emacs cvs head, all mail I send is 
>formatted together with everything I quote in a single paragraph 
>-- even though when I hit C-c C-c in the message buffer the 
>e-mail looks properly formatted.   <paragraph> longlines.el is 
>not loaded at the moment as far as I can tell.   <paragraph> what 
>do I do? 

-- 
Sam Steingold (http://www.podval.org/~sds) running w2k 
http://pmw.org.il/ http://truepeace.org http://ffii.org/ 
http://www.honestreporting.com http://www.palestinefacts.org/ What 
was there first: the Compiler or its Source code?

Re: hard-newline changes in lisp/gnus/message.el

[Chong Yidong]

>> As for `hard-newline': Obviously `hard-newline' is not defined 
   in
>> Emacs < 22.  I'm not sure what's the best way to deal with 
   this.
>
> Revert this gross `hard-newline' hack, accept that longlines.el
> won't work with all modes in Emacs 22, and spend our time on 
  real
> problems?

OK, I've reverted message.el.  I'll see if I can figure out some 
other way to make it work.

Re: hard-newline changes in lisp/gnus/message.el

[Chong Yidong]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> when changing lisp/gnus/*.el, please keep in mind that this directory
> is synced by Miles Bader with the (primary) Gnus repository on
> gnus.org in order to simplify the process of including a new stable
> Gnus version in Emacs.  The stable version of Gnus (the v5-10 branch
> in Gnus CVS) should be identical[1] to the version in Emacs CVS and it
> should work with Emacs 20.7 and up and XEmacs 21.1 and up.
>
> It would be nice to discuss possibly controversial changes on
> emacs-devel and ding@gnus.org (Gnus development list) before
> committing.

Sorry, I wasn't aware of the synching.

> As for `hard-newline': Obviously `hard-newline' is not defined in
> Emacs < 22.  I'm not sure what's the best way to deal with this.  I'd
> suggest to define `message-hard-newline' in `message.el' as follows
> and use it instead of `hard-newline'.

Why not:

(if (not (boundp hard-newline))
    (defvar hard-newline (propertize "\n" 'hard t 'rear-nonsticky '(hard))))

Re: hard-newline changes in lisp/gnus/message.el

[Reiner Steib]

On Sat, Nov 19 2005, Chong Yidong wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> As for `hard-newline': Obviously `hard-newline' is not defined in
>> Emacs < 22.  I'm not sure what's the best way to deal with this.  I'd
>> suggest to define `message-hard-newline' in `message.el' as follows
>> and use it instead of `hard-newline'.
>
> Why not:
>
> (if (not (boundp hard-newline))
>    (defvar hard-newline (propertize "\n" 'hard t 'rear-nonsticky '(hard))))

(Your suggestion should read (unless (boundp 'hard-newline) ...).)

It violates Emacs Lisp coding conventions:

,----[ (info "(elisp)Coding Conventions") ]
|    * If a package needs to define an alias or a new function for
|      compatibility with some other version of Emacs, name it with the
|      package prefix, not with the raw name with which it occurs in the
|      other version.  Here is an example from Gnus, which provides many
|      examples of such compatibility issues.
| 
|           (defalias 'gnus-point-at-bol
|             (if (fboundp 'point-at-bol)
|                 'point-at-bol
|               'line-beginning-position))
`----

The same applies to variables, IMO.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/