Re: gnus-newsgroup-unseen gives gnus-dup-unsuppress-article error

[Kevin Greiner <kgreiner@xpediantsolutions.com>]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Tue, 22 Apr 2003, nk@viteno.net wrote:
>> Ted Zlatanov <tzz@lifelogs.com> writes:
>> 
>>> is outside spam.el, in gnus-dup.el.  I think the arrayp error is
>>> happening when gnus-dup-unsuppress-article runs
>>>
>>> (gnus-data-header (gnus-data-find article))
>>>
>>> and the article is somehow not available.  I recently switched from
>>> running through all the articles sequentially to using
>>> gnus-newsgroup-unseen and gnus-newsgroup-unreads in
>>> spam-mark-junk-as-spam-routine, could that be the problem?
>> 
>> It seems to be the problem.  I've just re-used version 6.92, ie
>> before these changes, of spam.el and everything looks great.
>> 
>> Hmm, is there a file I should, err, bring closer to reality in order
>> to use the new features?
>
> I haven't seen the error you mention.  Maybe it's Agent-related, I
> don't know, but I use the latest spam.el and I get consistently marked
> articles without errors.  I don't use the Agent.
>
> You probably have spam-mark-only-unseen-as-spam set to t (the
> default), right?  In that case the error is with
> gnus-newsgroup-unseen, it's somehow giving us articles that trigger an
> error when I try to apply the spam-mark to them (in
> gnus-dup-unsuppress-article).  Can you try to debug
> gnus-dup-unsuppress-article, using debug statements, to see where the
> arrayp error is occurring?  Since I can't duplicate your problem, you
> need to trace through it on your side.

Personally, I don't see the connection to the agent.  I've put
together this much but I don't use the spam features so this is about
all that I can do.

The macros in gnus-dup-unsupress-article expand as follows:

(defun gnus-dup-unsuppress-article (article)
  "Stop suppression of ARTICLE."
  (let ((id
          (aref
           (nth 3
                (assq article gnus-newsgroup-data))
           4)))
    ((if id
         (progn
           (setq gnus-dup-list-dirty t)
           (setq gnus-dup-list
                 (delete id gnus-dup-list))
           (unintern id gnus-dup-hashtb))))))

There's only the one aref so the error has to result from 
(assq article gnus-newsgroup-data) returning nil.  The invalid article
number that is passed to gnus-dup-unsuppress-article comes from
spam-mark-junk-as-spam-routine and, yes Ted, it gets it from
gnus-newsgroup-unseen.

The initial value of gnus-newsgroup-unseen is computed by
gnus-compute-unseen-list in gnus-sum.el.  That function computes
gnus-newsgroup-unseen as a subset of gnus-newsgroup-articles so the
initial value of gnus-newsgroup-unseen appears to be OK.

Can anyone explain how gnus-newsgroup-articles might be updated?  If
articles were removed from it, then gnus-newsgroup-unseen might become a
superset of gnus-newsgroup-articles and that would cause the arrayp error.

So far, that's all that I can identify.  I hope that this helps.

Kevin