Re: Making Gnus more worm-safe

[Toby Speight <streapadair@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

Florian> Florian Weimer <URL:mailto:fw@deneb.cygnus.argh.org>

0> In article <87hfcdwnwi.fsf@deneb.cygnus.argh.org>, Florian wrote:

Florian> I'd suggest the following change to mailcap.el:
Florian>
Florian> -      ("emacs-lisp"
Florian> -       (viewer . mailcap-maybe-eval)
Florian> -       (type   . "application/emacs-lisp"))
Florian>
Florian> This feature is just too dangerous to be enabled by default.
Florian>
Florian> If there aren't any objections, I'll remove it.


Instead of `mailcap-maybe-eval', I use the following function to
display elisp parts highlighted with the usual font-locking:

.gnus> (defun mm-display-elisp-inline (handle)
.gnus>   (let (text)
.gnus>     (with-temp-buffer
.gnus>       (mm-insert-part handle)
.gnus>       (emacs-lisp-mode)
.gnus>       (font-lock-fontify-buffer)
.gnus>       (setq text (buffer-string)))
.gnus>     (mm-insert-inline handle text)))

Perhaps it's possible to do this without invoking (emacs-lisp-mode),
by `let'ing the appropriate font-lock variables instead.

Could we make this the default?

In fact, you might consider all of the following:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Viewers for elisp and diffs --]
[-- Type: text/x-emacs-lisp, Size: 1212 bytes --]


(defun mm-display-patch-inline (handle)
  (let (text)
    (with-temp-buffer
      (mm-insert-part handle)
      (diff-mode)
      (font-lock-fontify-buffer)
      (setq text (buffer-string)))
    (mm-insert-inline handle text)))

(defun mm-display-elisp-inline (handle)
  (let (text)
    (with-temp-buffer
      (mm-insert-part handle)
      (emacs-lisp-mode)
      (font-lock-fontify-buffer)
      (setq text (buffer-string)))
    (mm-insert-inline handle text)))


(defun mm-add-new-type (type displayer test auto-display inlined attachment-override)
  (push (list type displayer test) mm-inline-media-tests)
  (if auto-display
      (push type mm-automatic-display))
  (if inlined
      (push type mm-inlined-types))
  (if attachment-override
      (push type mm-attachment-override-types)))

(eval-after-load "mm-decode"
  '(progn
     (mm-add-new-type "text/x-patch"        'mm-display-patch-inline '(fboundp 'diff-mode) t t t)
     (mm-add-new-type "application/x-patch" 'mm-display-patch-inline '(fboundp 'diff-mode) t t t)
     (mm-add-new-type "text/x-emacs-lisp"      'mm-display-elisp-inline 'identity t t t)
     (mm-add-new-type "application/emacs-lisp" 'mm-display-elisp-inline 'identity t t t)))