From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/50702 Path: main.gmane.org!not-for-mail From: Kevin Greiner Newsgroups: gmane.emacs.gnus.general Subject: Re: Threading wrong if showing undownloaded articles Date: Sun, 09 Mar 2003 00:20:51 -0600 Sender: owner-ding@hpc.uh.edu Message-ID: References: <84d6ldkc9w.fsf@lucy.is.informatik.uni-duisburg.de> <84bs0wy2mx.fsf@lucy.is.informatik.uni-duisburg.de> <84llzp3hqq.fsf@lucy.is.informatik.uni-duisburg.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1047190894 1173 80.91.224.249 (9 Mar 2003 06:21:34 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 9 Mar 2003 06:21:34 +0000 (UTC) Original-X-From: owner-ding@hpc.uh.edu Sun Mar 09 07:21:33 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18ruBg-0000Ik-00 for ; Sun, 09 Mar 2003 07:21:33 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 18ruBQ-0005MA-00; Sun, 09 Mar 2003 00:21:16 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sun, 09 Mar 2003 00:22:16 -0600 (CST) Original-Received: from sclp3.sclp.com (sclp3.sclp.com [66.230.238.2]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id AAA13030 for ; Sun, 9 Mar 2003 00:22:03 -0600 (CST) Original-Received: (qmail 81513 invoked by alias); 9 Mar 2003 06:20:58 -0000 Original-Received: (qmail 81508 invoked from network); 9 Mar 2003 06:20:58 -0000 Original-Received: from quimby.gnus.org (80.91.224.244) by 66.230.238.6 with SMTP; 9 Mar 2003 06:20:58 -0000 Original-Received: from news by quimby.gnus.org with local (Exim 3.12 #1 (Debian)) id 18ruW9-0001m9-00 for ; Sun, 09 Mar 2003 07:42:41 +0100 Original-To: ding@gnus.org Original-Path: not-for-mail Original-Newsgroups: gnus.ding Original-Lines: 43 Original-NNTP-Posting-Host: 216.12.206.42 Original-X-Trace: quimby.gnus.org 1047192161 6630 216.12.206.42 (9 Mar 2003 06:42:41 GMT) Original-X-Complaints-To: usenet@quimby.gnus.org Original-NNTP-Posting-Date: 9 Mar 2003 06:42:41 GMT User-Agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.2 (windows-nt) Cancel-Lock: sha1:ewTleW2SKPzNSJL3ENo/q7J202g= Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:50702 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:50702 kai.grossjohann@uni-duisburg.de (Kai Großjohann) writes: > Kevin Greiner writes: > >> Right, the function that I provided should be able to refresh the >> undownloaded articles. I suspect that the data structures used by the >> summary are being corrupted. I'd like you to find out if that is >> true. > > I have now tested your function test1 on an article and it doesn't > appear to do anything (except to advance point to the next line). > > I'm not 100% sure if the originally reported behavior was the same as > what I'm seeing now. What I'm seeing now is that all articles are > shown correctly initially (the threading is correct). But when I > select a non-downloaded article, the summary line changes. In > particular, the %B part changes. It appears that the new %B macro > always expands to gnus-sum-thread-tree-single-leaf, preceded by one > or two levels of indentation. (It's always the same number of > levels, but I don't know the number offhand.) > > Hm. The thing that's inserted there is > gnus-tmp-thread-tree-header-string, according to > gnus-summary-line-format-alist. So a hypothesis is that this > variable is b0rked. > > Which function is called to show the summary line when I select an > article? > > Ah. gnus-tmp-thread-tree-header-string is only set in one spot, in > gnus-summary-prepare-threads. Hmm... Oh! Selecting an article > appears to call gnus-summary-update-article-line which calls > gnus-summary-insert-line which does not know about the correct value. > > Is this analysis correct? It sure looks it. Let's try making a small change to gnus-agent-fetch-selected-article :). Replace the entire call to gnus-summary-update-article-line with (gnus-summary-update-line gnus-current-article) Kevin