Re: [PATCH] md4.el and ntlm.el

[Taro Kawagishi <tarok@transpulse.org>]

Hello,

I haven't heard of changes for these files by other people, except for the one
just reported by "Katsumi Yamaoka" <yamaoka@jpl.org> (as attached below).

I am perfectly happy with the modifications you made with names.
Thank you for polishing the code.

I am not involved in maintaining FLIM code, so other people might want to consider
taking your modifications.

--Taro

At Mon, 5 Jan 2004 10:59:39 +0900,
Simon Josefsson wrote:
| 
| Hello, first thanks for assigning the copyright of these two files.
| While writing them, did anyone but you contribute to files?  Have you
| merged patches from anyone else?  According to the FLIM ChangeLog and
| CVS logs, you and Kenichi OKADA have touched them, and we have papers
| for that.
| 
| Also, after installing these files into Gnus, we have made the
| following modifications.  Do you agree with them?  Any suggestions?
| Please consider including them in FLIM.  The patch is against the
| flim-1_14 branch in CVS.
| 
| Thanks,
| Simon
| 
| 2004-01-05  Simon Josefsson  <jas@extundo.com>
| 
| 	* ntlm.el: Fix namespace.  Change smb-passwd-hash into
| 	ntlm-smb-passwd-hash, smb-owf-encrypt into ntlm-smb-owf-encrypt,
| 	smb-passwd-hash into ntlm-smb-passwd-hash, smbdes-e-p16 into
| 	ntlm-smb-des-e-p16, smbdes-e-p24 into ntlm-smb-des-e-p24, smbhash
| 	into ntlm-smb-hash, smb-sp8 into ntlm-smb-sp8, smb-str-to-key into
| 	ntlm-smb-str-to-key, smb-dohash into ntlm-smb-dohash, smb-perm1
| 	into ntlm-smb-perm1, smb-perm2 into ntlm-smb-perm2, smb-perm3 into
| 	ntlm-smb-perm3, smb-perm4 into ntlm-smb-perm4, smb-perm5 into
| 	ntlm-smb-perm5, smb-perm6 into ntlm-smb-perm6, smb-sc into
| 	ntlm-smb-sc, smb-sbox into ntlm-smb-sbox, string-permute into
| 	ntlm-string-permute, string-lshift into ntlm-string-lshift,
| 	string-xor into ntlm-string-xor.  Suggested by
| 	Jesper Harder <harder@myrealbox.com>.
| 
| 	* ntlm.el: Don't include poem.
| 
| 	* md4.el (print-int32, print-string-hexa): Remove.  Suggested by
| 	Jesper Harder <harder@myrealbox.com>.
| 


At Mon, 5 Jan 2004 13:59:48 +0900,
Katsumi Yamaoka wrote:
| 
| Hi,
| 
| >>>>> In [emacs-mime-en : No.00115]
| >>>>>	Simon Josefsson <jas@extundo.com> wrote:
| 
| > Hello, first thanks for assigning the copyright of these two files.
| > While writing them, did anyone but you contribute to files?  Have you
| > merged patches from anyone else?  According to the FLIM ChangeLog and
| > CVS logs, you and Kenichi OKADA have touched them, and we have papers
| > for that.
| 
| > Also, after installing these files into Gnus, we have made the
| > following modifications.  Do you agree with them?  Any suggestions?
| > Please consider including them in FLIM.  The patch is against the
| > flim-1_14 branch in CVS.
| 
| > Thanks,
| > Simon
| 
| [...]
| 
| I also add the following change to ntlm.el in Gnus.  Although
| it is needless if APEL provides `string-as-unibyte' for XEmacs,
| Gnus doesn't use it.
| 
| 2004-01-05  Katsumi Yamaoka  <yamaoka@jpl.org>
| 
| 	* ntlm.el (ntlm-string-as-unibyte): New macro.
| 	(ntlm-build-auth-response): Use it.