Gnus development mailing list
 help / color / mirror / Atom feed
From: Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
Subject: Invalid message-id header when unplugged.
Date: 16 Sep 1998 13:20:37 +0900	[thread overview]
Message-ID: <u67eon0x6.fsf@hv08.hv.epson.co.jp> (raw)

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]


  When gnus is unplugged status , nnmail-check-syntax insert
  Message-ID header like this.

    Message-ID: <86emtfltdv.fsf@totally-fudged-out-message-id>

;; Message-ID is not member of message-required-news-headers.
;; In this case , I want to add Message-ID header by ISP news server.

  In plugged status gnus-agent-send-drafts typing "JS" in group
  buffer, Message-ID header is still above line.

  Is that right ??

  So , I make following patch.
  Please apply in pGnus-0.32.

  Thanks.


[-- Attachment #2: gnus.diff --]
[-- Type: application/octet-stream, Size: 7944 bytes --]

*** ChangeLog.orig	Wed Sep 16 13:17:14 1998
--- ChangeLog	Wed Sep 16 13:17:46 1998
***************
*** 1,3 ****
--- 1,17 ----
+ 1998-09-16  Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
+ 
+ 	* nnmh.el (nnmh-request-accept-article): Do not add message-id
+ 	when posting queue.
+ 
+ 	* gnus-agent.el (gnus-agent-file-coding-system): Renamed from
+ 	gnus-agent-article-file-coding-system and save in no-conversion.
+ 	(gnus-agent-save-group): Ditto.
+ 	(gnus-agent-save-history): Ditto.
+ 	(gnus-agent-fetch-articles): Ditto.
+ 	(gnus-agent-flush-cache): Ditto.
+ 	(gnus-agent-fetch-headers): Ditto.
+ 	(gnus-agent-expire): Ditto.
+ 
  Mon Sep 14 18:55:38 1998  Lars Magne Ingebrigtsen  <larsi@menja.ifi.uio.no>
  
  	* gnus.el: Pterodactyl Gnus v0.31 is released.
*** gnus-agent.el.orig	Wed Sep 16 13:10:22 1998
--- gnus-agent.el	Wed Sep 16 13:10:30 1998
***************
*** 92,98 ****
  (defvar gnus-agent-spam-hashtb nil)
  (defvar gnus-agent-file-name nil)
  (defvar gnus-agent-send-mail-function nil)
! (defvar gnus-agent-article-file-coding-system 'no-conversion)
  
  (defconst gnus-agent-scoreable-headers
    (list
--- 92,98 ----
  (defvar gnus-agent-spam-hashtb nil)
  (defvar gnus-agent-file-name nil)
  (defvar gnus-agent-send-mail-function nil)
! (defvar gnus-agent-file-coding-system 'no-conversion)
  
  (defconst gnus-agent-scoreable-headers
    (list
***************
*** 524,530 ****
      (let* ((gnus-command-method method)
  	   (file (gnus-agent-lib-file "active")))
        (gnus-make-directory (file-name-directory file))
!       (let ((coding-system-for-write gnus-agent-article-file-coding-system))
  	(write-region (point-min) (point-max) file nil 'silent))
        (when (file-exists-p (gnus-agent-lib-file "groups"))
  	(delete-file (gnus-agent-lib-file "groups"))))))
--- 524,530 ----
      (let* ((gnus-command-method method)
  	   (file (gnus-agent-lib-file "active")))
        (gnus-make-directory (file-name-directory file))
!       (let ((coding-system-for-write gnus-agent-file-coding-system))
  	(write-region (point-min) (point-max) file nil 'silent))
        (when (file-exists-p (gnus-agent-lib-file "groups"))
  	(delete-file (gnus-agent-lib-file "groups"))))))
***************
*** 533,541 ****
    (let* ((gnus-command-method method)
  	 (file (gnus-agent-lib-file "groups")))
      (gnus-make-directory (file-name-directory file))
!     (write-region (point-min) (point-max) file nil 'silent))
      (when (file-exists-p (gnus-agent-lib-file "active"))
!       (delete-file (gnus-agent-lib-file "active"))))
  
  (defun gnus-agent-save-group-info (method group active)
    (when (gnus-agent-method-p method)
--- 533,542 ----
    (let* ((gnus-command-method method)
  	 (file (gnus-agent-lib-file "groups")))
      (gnus-make-directory (file-name-directory file))
!     (let ((coding-system-for-write gnus-agent-file-coding-system))
!       (write-region (point-min) (point-max) file nil 'silent))
      (when (file-exists-p (gnus-agent-lib-file "active"))
!       (delete-file (gnus-agent-lib-file "active")))))
  
  (defun gnus-agent-save-group-info (method group active)
    (when (gnus-agent-method-p method)
***************
*** 604,611 ****
    (save-excursion
      (set-buffer gnus-agent-current-history)
      (gnus-make-directory (file-name-directory gnus-agent-file-name))
!     (write-region (1+ (point-min)) (point-max)
! 		  gnus-agent-file-name nil 'silent)))
  
  (defun gnus-agent-close-history ()
    (when (gnus-buffer-live-p gnus-agent-current-history)
--- 605,613 ----
    (save-excursion
      (set-buffer gnus-agent-current-history)
      (gnus-make-directory (file-name-directory gnus-agent-file-name))
!     (let ((coding-system-for-write gnus-agent-file-coding-system))
!       (write-region (1+ (point-min)) (point-max)
! 		    gnus-agent-file-name nil 'silent))))
  
  (defun gnus-agent-close-history ()
    (when (gnus-buffer-live-p gnus-agent-current-history)
***************
*** 703,709 ****
  		(setq id "No-Message-ID-in-article")
  	      (setq id (buffer-substring (match-beginning 1) (match-end 1))))
  	    (let ((coding-system-for-write
! 		   gnus-agent-article-file-coding-system))
  	      (write-region (point-min) (point-max)
  			    (concat dir (number-to-string (caar pos)))
  			    nil 'silent))
--- 705,711 ----
  		(setq id "No-Message-ID-in-article")
  	      (setq id (buffer-substring (match-beginning 1) (match-end 1))))
  	    (let ((coding-system-for-write
! 		   gnus-agent-file-coding-system))
  	      (write-region (point-min) (point-max)
  			    (concat dir (number-to-string (caar pos)))
  			    nil 'silent))
***************
*** 746,755 ****
    (save-excursion
      (while gnus-agent-buffer-alist
        (set-buffer (cdar gnus-agent-buffer-alist))
!       (write-region (point-min) (point-max)
! 		    (gnus-agent-article-name ".overview"
! 					     (caar gnus-agent-buffer-alist))
! 		     nil 'silent)
        (pop gnus-agent-buffer-alist))
      (while gnus-agent-group-alist
        (with-temp-file (caar gnus-agent-group-alist)
--- 748,759 ----
    (save-excursion
      (while gnus-agent-buffer-alist
        (set-buffer (cdar gnus-agent-buffer-alist))
!       (let ((coding-system-for-write
! 	     gnus-agent-file-coding-system))
! 	(write-region (point-min) (point-max)
! 		      (gnus-agent-article-name ".overview"
! 					       (caar gnus-agent-buffer-alist))
! 		      nil 'silent))
        (pop gnus-agent-buffer-alist))
      (while gnus-agent-group-alist
        (with-temp-file (caar gnus-agent-group-alist)
***************
*** 780,786 ****
   	    (gnus-agent-braid-nov group articles file))
   	  (gnus-make-directory (nnheader-translate-file-chars
   				(file-name-directory file)))
!  	  (write-region (point-min) (point-max) file nil 'silent)
   	  (gnus-agent-save-alist group articles nil)
   	  (gnus-agent-enter-history
   	   "last-header-fetched-for-session"
--- 784,792 ----
   	    (gnus-agent-braid-nov group articles file))
   	  (gnus-make-directory (nnheader-translate-file-chars
   				(file-name-directory file)))
! 	  (let ((coding-system-for-write
! 		 gnus-agent-file-coding-system))
! 	    (write-region (point-min) (point-max) file nil 'silent))
   	  (gnus-agent-save-alist group articles nil)
   	  (gnus-agent-enter-history
   	   "last-header-fetched-for-session"
***************
*** 1386,1392 ****
  		 ;; Schedule the history line for nuking.
  		 (push (cdr elem) histories)))
  	     (gnus-make-directory (file-name-directory nov-file))
! 	     (write-region (point-min) (point-max) nov-file nil 'silent)
  	     ;; Delete the unwanted entries in the alist.
  	     (setq gnus-agent-article-alist
  		   (sort gnus-agent-article-alist 'car-less-than-car))
--- 1392,1400 ----
  		 ;; Schedule the history line for nuking.
  		 (push (cdr elem) histories)))
  	     (gnus-make-directory (file-name-directory nov-file))
! 	     (let ((coding-system-for-write
! 		    gnus-agent-file-coding-system))
! 	       (write-region (point-min) (point-max) nov-file nil 'silent))
  	     ;; Delete the unwanted entries in the alist.
  	     (setq gnus-agent-article-alist
  		   (sort gnus-agent-article-alist 'car-less-than-car))
*** nnmh.el.orig	Wed Sep 16 13:06:14 1998
--- nnmh.el	Wed Sep 16 13:19:32 1998
***************
*** 294,300 ****
  
  (deffoo nnmh-request-accept-article (group &optional server last noinsert)
    (nnmh-possibly-change-directory group server)
!   (nnmail-check-syntax)
    (when nnmail-cache-accepted-message-ids
      (nnmail-cache-insert (nnmail-fetch-field "message-id")))
    (nnheader-init-server-buffer)
--- 294,301 ----
  
  (deffoo nnmh-request-accept-article (group &optional server last noinsert)
    (nnmh-possibly-change-directory group server)
!   (if (not (string-equal group "queue"))
!       (nnmail-check-syntax))
    (when nnmail-cache-accepted-message-ids
      (nnmail-cache-insert (nnmail-fetch-field "message-id")))
    (nnheader-init-server-buffer)

[-- Attachment #3: Type: text/plain, Size: 106 bytes --]


-- 
  Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
  # PGP Public Key : See X-Info header in this message.

             reply	other threads:[~1998-09-16  4:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-09-16  4:20 Tatsuya Ichikawa [this message]
1998-09-16  7:32 ` Graham Murray
1998-09-16  8:02   ` Tatsuya Ichikawa
1998-09-16  9:45 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u67eon0x6.fsf@hv08.hv.epson.co.jp \
    --to=ichikawa@hv.epson.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).