rfc2047 patch broke Gnus on XEmacsc

rfc2047 patch broke Gnus on XEmacsc

[Andreas Jaeger]

I now get with XEmacs 21.4 this error with current CVS:
While compiling toplevel forms in file /home/aj/ELisp/pgnus/lisp/spam.el:
  !! Wrong number of arguments ((#<subr make-char-table> 2))
Compiling /home/aj/ELisp/pgnus/lisp/starttls.el...

Reverting Dave's patch:
2003-05-03  Dave Love  <fx@gnu.org>

        * rfc2047.el (rfc2047-point-at-bol, rfc2047-point-at-eol): New.
        Callers of gnus- versions changed to use them.

fixes the problem.  Dave, can you look into this, please?

I did a:
 cvs up -r 6.41 rfc2047.el

and version 6.41 seems to work fine,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

Re: rfc2047 patch broke Gnus on XEmacsc

[Romain FRANCOISE]

There's also a problem with `rfc2047-fold-field' which is undefined,
this patch seems to fix it.

Index: lisp/rfc2047.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/rfc2047.el,v
retrieving revision 6.42
diff -u -r6.42 rfc2047.el
--- lisp/rfc2047.el     2 May 2003 23:25:17 -0000       6.42
+++ lisp/rfc2047.el     3 May 2003 09:53:52 -0000
@@ -472,8 +472,15 @@
        (unless (eobp)
          (forward-char 1))))))
 
-(defun rfc2047-unfold-field ()
+(defun rfc2047-fold-field ()
   "Fold the current line."
+  (save-excursion
+    (save-restriction
+      (rfc2047-narrow-to-field)
+      (rfc2047-fold-region (point-min) (point-max)))))
+
+(defun rfc2047-unfold-field ()
+  "Unfold the current line."
   (save-excursion
     (save-restriction
       (rfc2047-narrow-to-field)

and also a call to a -mule4 function not changed in mm-encode:

Index: lisp/mm-encode.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mm-encode.el,v
retrieving revision 6.14
diff -u -r6.14 mm-encode.el
--- lisp/mm-encode.el   8 Feb 2003 21:20:53 -0000       6.14
+++ lisp/mm-encode.el   3 May 2003 09:56:04 -0000
@@ -95,7 +95,7 @@
 (defun mm-encode-content-transfer-encoding (encoding &optional type)
   (cond
    ((eq encoding 'quoted-printable)
-    (mm-with-unibyte-current-buffer-mule4
+    (mm-with-unibyte-current-buffer
       (quoted-printable-encode-region (point-min) (point-max) t)))
    ((eq encoding 'base64)
     (when (equal type "text/plain")

I'm wondering if Dave's changes really apply as "bugfixes only", they
seem pretty intrusive...

-- 
Romain FRANCOISE <romain@orebokech.com> | With your feet in the air and
it's a miracle -- http://orebokech.com/ | your head on the ground.

Re: rfc2047 patch broke Gnus on XEmacsc

[Raymond Scholz]

* Romain FRANCOISE <romain@orebokech.com> wrote:

> There's also a problem with `rfc2047-fold-field' which is undefined,
> this patch seems to fix it.

It does, please somebody commit :)

Something else broke at least for my GNU Emacs CVS with recent CVS
Gnus:

MIME decoding in the summary buffer seems to be broken. Or Kai changed
his name to =?iso-8859-1?q?Gro=DFjohann?=.  But German authorities are
a bit slow and conservative on that, so I think it's just a Gnus bug.

Cheers, Ray
-- 
http://www.zonix.de/ - (c) 2000 by Yamtaijika Corp.

Re: rfc2047 patch broke Gnus on XEmacsc

[Simon Josefsson]

It also breaks Emacs 20; `with-syntax-table' doesn't exist.

Re: rfc2047 patch broke Gnus on XEmacsc

[Vasily Korytov]

Also Dave's last patch broke building on XEmacs (at least, 21.4
non-MULE). A lot of errors like:

While compiling toplevel forms in file
/home/deskpot/src/gnus/lisp/gnus-delay.el:
  !! error (("Unrecognized char table type" syntax-table))

With this errors, half of the files fail to byte-compile.

Dave, please commit bugfixes, not vice versa. =))

-- 
       I accept RFC3156 and RFC2440-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

Re: rfc2047 patch broke Gnus on XEmacsc

[Dave Love]

Romain FRANCOISE <romain@orebokech.com> writes:

> I'm wondering if Dave's changes really apply as "bugfixes only",

It's clearly a bug to send badly-encoded messages.  MTAs even bounce
them, which is why I went to the trouble to fix it.  I'm also trying
to get it into a better state for inclusion in Emacs, allow using the
components separately, and merge changes which are in the Emacs
sources.  The mess around Gnus 5.9 shouldn't be repeated.

Re: rfc2047 patch broke Gnus on XEmacsc

[Dave Love]

Simon Josefsson <jas@extundo.com> writes:

> It also breaks Emacs 20; `with-syntax-table' doesn't exist.

I've added a definition, but I don't have Emacs 20.  If it's not right
now, please fix it.

Re: rfc2047 patch broke Gnus on XEmacsc

[Andreas Jaeger]

Dave Love <d.love@dl.ac.uk> writes:

> Andreas Jaeger <aj@suse.de> writes:
>
>> I now get with XEmacs 21.4 this error with current CVS:
>> While compiling toplevel forms in file /home/aj/ELisp/pgnus/lisp/spam.el:
>>   !! Wrong number of arguments ((#<subr make-char-table> 2))
>> Compiling /home/aj/ELisp/pgnus/lisp/starttls.el...
>> 
>> Reverting Dave's patch:
>> 2003-05-03  Dave Love  <fx@gnu.org>
>> 
>>         * rfc2047.el (rfc2047-point-at-bol, rfc2047-point-at-eol): New.
>>         Callers of gnus- versions changed to use them.
>> 
>> fixes the problem.  Dave, can you look into this, please?
>
> I assume it's fixed now, but it's nothing to do with the change
> above.  (A backtrace would have helped.)

I invoked make and there you don't easily get a backtrace.  I would
have tried to reproduce one if you asked for it ;-)

Yes, it seems to be fixed now.

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj