.overview file coding system when caching article.

.overview file coding system when caching article.

[Tatsuya Ichikawa]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]


  When gnus-cache-enter-article cache article , .overview file wrote
  in sjis-dos file coding system on mule that works on Microsoft
  Windows.

  I correct this problem following patch.

  Any problem ??


[-- Attachment #2: gnus-util.el.diff --]
[-- Type: application/octet-stream, Size: 974 bytes --]

*** gnus-util.el.orig	Tue Aug 25 17:01:32 1998
--- gnus-util.el	Tue Aug 25 10:39:20 1998
***************
*** 537,542 ****
--- 537,544 ----
  
  (defvar gnus-work-buffer " *gnus work*")
  
+ (defvar gnus-write-file-coding-system 'raw-text)
+ 
  (defun gnus-set-work-buffer ()
    "Put point in the empty Gnus work buffer."
    (if (get-buffer gnus-work-buffer)
***************
*** 605,611 ****
    ;; Make sure the directory exists.
    (gnus-make-directory (file-name-directory file))
    ;; Write the buffer.
!   (write-region (point-min) (point-max) file nil 'quietly))
  
  (defun gnus-delete-file (file)
    "Delete FILE if it exists."
--- 607,614 ----
    ;; Make sure the directory exists.
    (gnus-make-directory (file-name-directory file))
    ;; Write the buffer.
!   (let ((coding-system-for-write gnus-write-file-coding-system))
!     (write-region (point-min) (point-max) file nil 'quietly)))
  
  (defun gnus-delete-file (file)
    "Delete FILE if it exists."

[-- Attachment #3: Type: text/plain, Size: 377 bytes --]


  And I always reading mail from "Multiple" pop3 servers.
  So , I write "Front End" package enable to get mail from multiple
  pop3 servers.

  If someone needs this package , please merge this package.
  Package name is "pop3-fma" (pop3 For Multi Account).

  Thanks.

-- 
  Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
  # PGP Public Key : See X-Info header in this message.

Re: .overview file coding system when caching article.

[Lars Magne Ingebrigtsen]

Tatsuya Ichikawa <ichikawa@hv.epson.co.jp> writes:

>   When gnus-cache-enter-article cache article , .overview file wrote
>   in sjis-dos file coding system on mule that works on Microsoft
>   Windows.
> 
>   I correct this problem following patch.

[...]

> + (defvar gnus-write-file-coding-system 'raw-text)

I don't think this is the right way to do it.  Instead, there should
probably be a gnus-cache-overview-coding-system-for-write thing.  Feel
free to submit a patch for that instead.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: .overview file coding system when caching article.

[Tatsuya Ichikawa]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

>>>>> In <m3vhnhcw16.fsf@sparky.gnus.org>
>>>>>  Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:

Lars> > + (defvar gnus-write-file-coding-system 'raw-text)
Lars> I don't think this is the right way to do it.  Instead, there
Lars> should probably be a gnus-cache-overview-coding-system-for-write
Lars> thing.  Feel free to submit a patch for that instead.

  I see.
  So this patch is better.

  And what do you think about to read mail from Multiple pop3 server
  package??


[-- Attachment #2: gnus-cache.el.diff --]
[-- Type: application/octet-stream, Size: 1050 bytes --]

*** gnus-cache.el.orig	Tue Aug 25 18:00:00 1998
--- gnus-cache.el	Tue Aug 25 18:01:02 1998
***************
*** 82,87 ****
--- 82,88 ----
  (defvar gnus-cache-buffer nil)
  (defvar gnus-cache-active-hashtb nil)
  (defvar gnus-cache-active-altered nil)
+ (defvar gnus-cache-write-file-coding-system 'raw-text)
  
  (eval-and-compile
    (autoload 'nnml-generate-nov-databases-1 "nnml")
***************
*** 121,127 ****
  	  (set-buffer buffer)
  	  (if (> (buffer-size) 0)
  	      ;; Non-empty overview, write it to a file.
! 	      (gnus-write-buffer overview-file)
  	    ;; Empty overview file, remove it
  	    (when (file-exists-p overview-file)
  	      (delete-file overview-file))
--- 122,129 ----
  	  (set-buffer buffer)
  	  (if (> (buffer-size) 0)
  	      ;; Non-empty overview, write it to a file.
! 	      (let ((coding-system-for-write gnus-cache-write-file-coding-system))
! 		(gnus-write-buffer overview-file))
  	    ;; Empty overview file, remove it
  	    (when (file-exists-p overview-file)
  	      (delete-file overview-file))

[-- Attachment #3: Type: text/plain, Size: 107 bytes --]



-- 
  Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
  # PGP Public Key : See X-Info header in this message.