Gnus development mailing list
 help / color / mirror / Atom feed
From: Danny Siu <dsiu@adobe.com>
Subject: [patch] nnimap.el fix for messages missing message-id field
Date: Wed, 31 Jul 2002 14:01:16 -0700	[thread overview]
Message-ID: <uheifsjc3.fsf@adobe.com> (raw)


In nnimap-split-articles, nnmail-cache-insert would fail if splitting
malformed messages¹ contain no message-id field (nnmail-fetch-field returns
nil).

Can someone with CVS write access commit the patch for me?

Thanks,

Index: nnimap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
retrieving revision 6.37
diff -r6.37 nnimap.el
1219,1220c1223,1225
< 			     (nnmail-cache-insert (nnmail-fetch-field
< 						   "message-id") to-group)))
---
>                              (let (msgid)
>                                (and (setq msgid (nnmail-fetch-field "message-id"))
>                                     (nnmail-cache-insert msgid to-group)))))

Index: ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.1460
diff -r6.1460 ChangeLog
0a1,5
> 2002-07-31  Danny Siu  <dsiu@adobe.com>
> 
> 	* nnimap.el (nnimap-split-articles): do not call nnmail-fetch-field 
> 	when splitting malformed messages without message-id
> 


Footnotes: 
¹  usually come for machine generated emails.  in my case, TWiki sent me an 
auto generated email thur Netscape Messaging Server.

-- 
Danny Siu




             reply	other threads:[~2002-07-31 21:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-31 21:01 Danny Siu [this message]
2002-07-31 21:14 ` Simon Josefsson
2002-08-01 19:31 ` Kai Großjohann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uheifsjc3.fsf@adobe.com \
    --to=dsiu@adobe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).